Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 27 Apr 2022 13:05:11 -0700
From:   Zev Weiss <zev@bewilderbeest.net>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        Renze Nicolai <renze@rnplus.nl>,
        Oleksandr Natalenko <oleksandr@natalenko.name>,
        openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/7] dt-bindings: hwmon: Add nuvoton,nct6775
Message-ID: <Ymmh93CW8nIGD0YI@hatter.bewilderbeest.net>
References: <20220427010154.29749-1-zev@bewilderbeest.net>
 <20220427010154.29749-2-zev@bewilderbeest.net>
 <178b9310-a854-dfa6-a4f3-f971b608abe3@linaro.org>
 <YmjmWNUpCAFYesyk@hatter.bewilderbeest.net>
 <5139dc9f-96c3-9f20-4c62-feee902cb5e6@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <5139dc9f-96c3-9f20-4c62-feee902cb5e6@linaro.org>
Precedence: bulk

On Wed, Apr 27, 2022 at 09:37:20AM PDT, Krzysztof Kozlowski wrote:
>On 27/04/2022 08:44, Zev Weiss wrote:
>>>> +  reg:
>>>> +    maxItems: 1
>>>> +
>>>> +  nuvoton,tsi-channel-mask:
>>>> +    description:
>>>> +      Bitmask indicating which TSI temperature sensor channels are
>>>> +      active.  LSB is TSI0, bit 1 is TSI1, etc.
>>>
>>> Need a type/ref.
>>>
>>
>> Ack, thanks.
>
>Did you test the bindings after the changes? Using reviewers time
>instead of testing by yourself with an automated tool is quite a waste.
>

Yeah, sorry about that -- with uint32 $ref added it passes dt_binding_check;
I'll re-send with that change.


Zev