Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: e2MCKyc0Bfsi34lJ5+nAodCxusbv+ecOG7fJVmzZcWrDIukAWY//TNUaRyjESMIGxSdeKhm/b7
 rVBw+haZu2Vk2aFdrDcDFkvjBtzmPWFx5NrUQidnPkDJV2nE+XJx6qzNMgUr2hrWgqCrOe/QK6
 OE1q6jhZVMYIHuQPjHuEigaJo0/Gt02+AMigTqpvRdbHsQ2w6Md+mNYxZcxuBKkVSsDl6fsBHH
 h+pTyD2CHzKxnpgfxpiSThlYut6JLiYLHN6GqLjqeQSK0v41mJYWlPGUz0zye75wRk5ClmEgw7
 VQ4QMOuFhE0zQM81rZcsqiWL
IronPort-SDR: 4xt9UeOVjW8bGrei9l8YUFBLuypmeNiP63iZI1xRmBdNyBdp20dagHFHtCXZWwgzE42xVKNqR8
 LldHsQxMWlsqiFkWgsqlcEz+vTEaSZNoSKou9Bzr/j1vaG+lnk2KedXTlwJsx0XYhC34YhCyA/
 H1YgqIIUeYXUTVMgLNI0/Fcfgp4o/S/WjJ1cPI94enWwgMwI4ciJLUN2MS4GA0HRwuR4MLA5W0
 n07CRYCgqdTxCbKvcmlVLUeASsKIuiDb2loEuhnnX7AADrshlgb5kuu1yfJqlA8kigNOt5rLu7
 SrU=
WDCIronportException: Internal
Message-ID: <3f80a126-e52a-955b-aca4-14218d26faf5@opensource.wdc.com>
Date:   Thu, 28 Apr 2022 06:56:07 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v4 00/10] Add Copy offload support
Content-Language: en-US
To:     Nitesh Shetty <nj.shetty@samsung.com>
Cc:     linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
        dm-devel@redhat.com, linux-nvme@lists.infradead.org,
        linux-fsdevel@vger.kernel.org, nitheshshetty@gmail.com,
        linux-kernel@vger.kernel.org
References: <CGME20220426101804epcas5p4a0a325d3ce89e868e4924bbdeeba6d15@epcas5p4.samsung.com>
 <20220426101241.30100-1-nj.shetty@samsung.com>
 <c02f67e1-2f76-7e52-8478-78e28b96b6a1@opensource.wdc.com>
 <20220427153826.GE9558@test-zns>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220427153826.GE9558@test-zns>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 4/28/22 00:38, Nitesh Shetty wrote:
> On Wed, Apr 27, 2022 at 10:46:32AM +0900, Damien Le Moal wrote:
>> On 4/26/22 19:12, Nitesh Shetty wrote:
>>> The patch series covers the points discussed in November 2021 virtual=
 call
>>> [LSF/MM/BFP TOPIC] Storage: Copy Offload[0].
>>> We have covered the Initial agreed requirements in this patchset.
>>> Patchset borrows Mikulas's token based approach for 2 bdev
>>> implementation.
>>>
>>> Overall series supports =E2=80=93
>>>
>>> 1. Driver
>>> - NVMe Copy command (single NS), including support in nvme-target (fo=
r
>>>     block and file backend)
>>>
>>> 2. Block layer
>>> - Block-generic copy (REQ_COPY flag), with interface accommodating
>>>     two block-devs, and multi-source/destination interface
>>> - Emulation, when offload is natively absent
>>> - dm-linear support (for cases not requiring split)
>>>
>>> 3. User-interface
>>> - new ioctl
>>> - copy_file_range for zonefs
>>>
>>> 4. In-kernel user
>>> - dm-kcopyd
>>> - copy_file_range in zonefs
>>>
>>> For zonefs copy_file_range - Seems we cannot levearge fstest here. Li=
mited
>>> testing is done at this point using a custom application for unit tes=
ting.
>>
>> https://protect2.fireeye.com/v1/url?k=3Db14bf8e1-d0361099-b14a73ae-74f=
e485fffb1-9bd9bbb269af18f9&q=3D1&e=3Db9714c29-ea22-4fa5-8a2a-eeb42ca4bdc1=
&u=3Dhttps%3A%2F%2Fgithub.com%2Fwesterndigitalcorporation%2Fzonefs-tools
>>
>> ./configure --with-tests
>> make
>> sudo make install
>>
>> Then run tests/zonefs-tests.sh
>>
>> Adding test case is simple. Just add script files under tests/scripts
>>
>> I just realized that the README file of this project is not documentin=
g
>> this. I will update it.
>>
>=20
> Thank you. We will try to use this.
> Any plans to integrate this testsuite with fstests(xfstest) ?

No. It is not a good fit since zonefs cannot pass most of the generic tes=
t
cases.

>=20
> --
> Nitesh Shetty
>=20
>=20


--=20
Damien Le Moal
Western Digital Research