Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jens Axboe <axboe@kernel.dk>
To:     tj@kernel.org
Cc:     linux-block@vger.kernel.org, saravanand@fb.com,
        chris.obbard@collabora.com, kernel-team@fb.com,
        linux-kernel@vger.kernel.org
In-Reply-To: <YmmeOLfo5lzc+8yI@slm.duckdns.org>
References: <YmmeOLfo5lzc+8yI@slm.duckdns.org>
Subject: Re: [PATCH block-5.18] Revert "block: inherit request start time from bio for BLK_CGROUP"
Message-Id: <165108909873.140853.15966713411862913960.b4-ty@kernel.dk>
Date:   Wed, 27 Apr 2022 13:51:38 -0600
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 27 Apr 2022 09:49:12 -1000, Tejun Heo wrote:
> This reverts commit 0006707723233cb2a9a23ca19fc3d0864835704c. It has a
> couple problems:
> 
> * bio_issue_time() is stored in bio->bi_issue truncated to 51 bits. This
>   overflows in slightly over 26 days. Setting rq->io_start_time_ns with it
>   means that io duration calculation would yield >26days after 26 days of
>   uptime. This, for example, confuses kyber making it cause high IO
>   latencies.
> 
> [...]

Applied, thanks!

[1/1] Revert "block: inherit request start time from bio for BLK_CGROUP"
      commit: 4cddeacad6d4b23493a108d0705e7d2ab89ba5a3

Best regards,
-- 
Jens Axboe