Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Qian Cai <quic_qiancai@quicinc.com>
CC:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Yu Zhao <yuzhao@google.com>
Subject: Re: [PATCH v8 00/70] Introducing the Maple Tree
Thread-Topic: [PATCH v8 00/70] Introducing the Maple Tree
Thread-Index: AQHYWX8vSnmCSFccn0+psIQVsVvpYa0D76aAgAALhwCAADqogIAAJxEA
Date:   Wed, 27 Apr 2022 22:41:41 +0000
Message-ID: <20220427224134.yurrplclbhmnrloj@revolver>
References: <20220426150616.3937571-1-Liam.Howlett@oracle.com>
 <20220427161033.GA1935@qian> <20220427165139.5s3qcj2u5vqrvwlc@revolver>
 <20220427202145.GA2047@qian>
In-Reply-To: <20220427202145.GA2047@qian>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rvHEQdu2nOjAU7k49bEanoYwd6G730Gl8h8XwQ8fE8lwsNHyDmDhJLpgIuQ8?=
 =?us-ascii?Q?+4VgiP5cXR5CCZ0GYdmxUQftfFVWwGx1mpk16PQOyovw1DhY/L6qL0DhypXy?=
 =?us-ascii?Q?rvU05/ubinH9trU3C9VcdeRoCtptX9QIFj2+lDoj/NSubNK/4X3KtReP9lBQ?=
 =?us-ascii?Q?07P8TJkxEQG/qbvIET8Y3rGf32zixckBYT1iEyyLw14DeGujmS59zPIDoJj7?=
 =?us-ascii?Q?ZbDOWoMo07QGtzqCncSmeGcKyXGNfOJNPb8f1q5ltTSnT1RiWQuxDE3RUCDe?=
 =?us-ascii?Q?jalE6YDgEcaxbqFw3+ngHUCmskQre1KahZNmxsFo2SehV2Cjo0ENmEr5Jonh?=
 =?us-ascii?Q?H7oSaYQf7oCuEPzzstxUn99OuwXpl++jd6/yTeql+dNeXVeKVfoVQmUG4GMM?=
 =?us-ascii?Q?k/VrDC/wYnDplVGsRTfbamOtcS6g2GgsltNQEgPNoMsIcMe3iqPqZrTeEfGP?=
 =?us-ascii?Q?TpGVBEg96IUDJZ8kwghrs4VmObiaswYz2z6BpvTgXsRe4u/qYn+S+tKyyNEZ?=
 =?us-ascii?Q?17GQSzbgK44H+RhlQtCnpTClCoJ5nWTx7ZI3a/83hp9UVkmoJQvS21hJBYHt?=
 =?us-ascii?Q?eZBXS6Z8nPvw9MlUtPKiW9OAP8fdJNcjLJ+tTK8HgYoJYvjNXn0pWV87oXEW?=
 =?us-ascii?Q?9xQytU8o1l8RuYLoiuPHIiddl6Lbe+G5xe7K6YZ2VVmyd7ZWAiTQJsJjWJac?=
 =?us-ascii?Q?eV5ER7uslh2S2BTvA5zdLDcVLZ22YtWtwSvS9RXihR56qXQpoW7clTNQiG67?=
 =?us-ascii?Q?mX3dh+/gDxuqscUYb2ZKmmXdem87c5olEPdM9Ya/ImlKbiZELq0k1MD7lzrh?=
 =?us-ascii?Q?1nxecIo+l7BL56474s0bM+6bGjUQDAHrz9HnSe5cDN0Tc85UNkgIv1C6W+wr?=
 =?us-ascii?Q?IY5FdWxgwldTWZb7Yt+3x5fBVDi9T59yvXOIxaZQdwTfRNulpsQpRua9pO3z?=
 =?us-ascii?Q?vjJFxu1xq40f9gU9n03JBbFYEdiUUDr2FulCA++PNG3IjLuDABYN/Kf77lRY?=
 =?us-ascii?Q?jSDBx8HNdMbVTZkYOhGbo/vd/hYNIkbP0oR/DivX4x7DZnJvoNXRxeAGVfez?=
 =?us-ascii?Q?PERdZCCYUL1EKetMumvAua/cl6wXWfGiFTCqP3jUKPrDihnRuMdvjBRSxyWm?=
 =?us-ascii?Q?5jR/7B9/Fw1l2X4qAwVNzoX5R6zANgb2783daKSNRCiRYjaTUQQf8lmjIt7l?=
 =?us-ascii?Q?gzKMCvs6hV+l8Z7ONHQxeEQNan3Igzx6lPnVQM9258qHYGnl2+NzGU4HT8xU?=
 =?us-ascii?Q?IYJ1pmmDcYc5XkTZyMMKp07WusEKFeLjOmEL3vqAFT7TKFtDQ1P92pykG1HZ?=
 =?us-ascii?Q?wvRtQapexqRFDQyPOx7JpSLtPegDotSMUMTIooxwN8o4sKG7zM1ocimNUuqP?=
 =?us-ascii?Q?SyrREKT00x0CiMrblz01Xm3v9VUOmKTNxi7t3/fPwMGJhFkWar6wPt/xDp2P?=
 =?us-ascii?Q?dr5rplZo3DBTS828H7mWLPVjyXurhdtM8m8bS+5yy+RYhNLm/CGSkpKiVhB/?=
 =?us-ascii?Q?VSVwUoNMDhux7VzHcMxwMTY3R/mgA1lRTZ9LoUGe26IQtXQ461YCwK4ptCUo?=
 =?us-ascii?Q?Aec1PQLz+q8B8CUcemh2FDN0imGrgCsZu3JGqcOsgBR+Um+KO6RgkY1TL1tT?=
 =?us-ascii?Q?lYtNNMsb1NtWH0EamFt+zzGJmv7jnjQb1QDj7E4WQe5RIA3CySm5UtaUr2vt?=
 =?us-ascii?Q?sBbAzzjdUS89+BAWK5U9LZX218usZN2+7Vkk7iBqCaiN/dltii8rxAah6Vsu?=
 =?us-ascii?Q?nq/9YMlR733h8h8BXhG0V9fEe2bkQso=3D?=
Content-Type: multipart/mixed;
        boundary="_002_20220427224134yurrplclbhmnrlojrevolver_"
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d9f92bd-a3d4-4d0c-1eeb-08da289f197a
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 22:41:41.8378
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EOnGrD71BEAW/kvtKfTgvLGda94BblrXH4e3gnD9RJ3tsN3gsjsK65+8DRh3U4qKpsu4LaHO8QQ7GdZUEmwZSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5680
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-27_04:2022-04-27,2022-04-27 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999
 malwarescore=0 mlxscore=0 phishscore=0 bulkscore=0 adultscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204270133
X-Proofpoint-GUID: ReE5g9oHFeip8vz6hwOpJN2CpXcwSR-5
X-Proofpoint-ORIG-GUID: ReE5g9oHFeip8vz6hwOpJN2CpXcwSR-5
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--_002_20220427224134yurrplclbhmnrlojrevolver_
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F10ED4314A48DE4994CC64899D566B19@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable

* Qian Cai <quic_qiancai@quicinc.com> [220427 16:22]:
> On Wed, Apr 27, 2022 at 04:51:50PM +0000, Liam Howlett wrote:
> > Thanks.  This is indeed an issue with 0d43186b36c1 (mm/mlock: use vma
> > iterator and instead of vma linked list)                               =
                 =20
> >=20
> > Andrew, Please include this patch as a fix.
>=20
> Even with the patch applied, there are still thousands of memory leaks
> reports from kmemleak after booting.

Thank you for finding this.

>=20
> unreferenced object 0xffff400259bd6d00 (size 256):
>   comm "multipathd", pid 2577, jiffies 4294915929 (age 2370.384s)
>   hex dump (first 32 bytes):
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>   backtrace:
>      slab_post_alloc_hook
>      kmem_cache_alloc_bulk
>      mas_alloc_nodes
>      mt_alloc_bulk at lib/maple_tree.c:151
>      (inlined by) mas_alloc_nodes at lib/maple_tree.c:1244
>      mas_preallocate
>      __vma_adjust
>      shift_arg_pages
>      setup_arg_pages
>      load_elf_binary
>      search_binary_handler
>      exec_binprm
>      bprm_execve
>      do_execveat_common.isra.0
>      __arm64_sys_execve
>      invoke_syscall
>      el0_svc_common.constprop.0
>      do_el0_svc

__vma_adjust is way too complicated.  This patch should fix the leak.

Andrew, please add this patch to "mm: start tracking VMAs with maple tree"


Thanks,
Liam

--_002_20220427224134yurrplclbhmnrlojrevolver_
Content-Type: text/x-diff;
	name="0001-mm-mmap-Fix-__vma_adjust-memory-leak.patch"
Content-Description: 0001-mm-mmap-Fix-__vma_adjust-memory-leak.patch
Content-Disposition: attachment;
	filename="0001-mm-mmap-Fix-__vma_adjust-memory-leak.patch"; size=877;
	creation-date="Wed, 27 Apr 2022 22:41:41 GMT";
	modification-date="Wed, 27 Apr 2022 22:41:41 GMT"
Content-ID: <4B1F136CDAFD0E44A682F9EFE743576F@namprd10.prod.outlook.com>
Content-Transfer-Encoding: base64

RnJvbSA3NGY1NTEyMjdkNDRiMzUxZDU2ZjRlYzBhMzY1NDJkODcxZjMzN2Q1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQ0KRnJvbTogIkxpYW0gUi4gSG93bGV0dCIgPExpYW0uSG93bGV0dEBvcmFj
bGUuY29tPg0KRGF0ZTogV2VkLCAyNyBBcHIgMjAyMiAxODo0MDowMCAtMDQwMA0KU3ViamVjdDog
W1BBVENIXSBtbS9tbWFwOiBGaXggX192bWFfYWRqdXN0KCkgbWVtb3J5IGxlYWsuDQoNCldoZW4g
c2hpZnRpbmcgdGhlIGFyZyBwYWdlcywgdGhlIG1hcGxlIHN0YXRlIG1heSBiZSBsZWZ0IHdpdGgg
YWxsb2NhdGVkDQptZW1vcnkuICBGcmVlIHRoZSBtZW1vcnkgYnkgY2FsbGluZyBtYXNfZGVzdHJv
eSgpIHVuY29uZGl0aW9uYWxseSBhdCB0aGUNCmVuZCBvZiB0aGUgZnVuY3Rpb24uDQoNCkZpeGVz
OiBiZDZhMWZkNThkYWYgKG1tOiBzdGFydCB0cmFja2luZyBWTUFzIHdpdGggbWFwbGUgdHJlZSkN
ClNpZ25lZC1vZmYtYnk6IExpYW0gUi4gSG93bGV0dCA8TGlhbS5Ib3dsZXR0QG9yYWNsZS5jb20+
DQotLS0NCiBtbS9tbWFwLmMgfCAxICsNCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykN
Cg0KZGlmZiAtLWdpdCBhL21tL21tYXAuYyBiL21tL21tYXAuYw0KaW5kZXggNmEzN2Y1ZDJlNDk2
Li5mNTJiYmY5YWEwMjQgMTAwNjQ0DQotLS0gYS9tbS9tbWFwLmMNCisrKyBiL21tL21tYXAuYw0K
QEAgLTkwNCw2ICs5MDQsNyBAQCBpbnQgX192bWFfYWRqdXN0KHN0cnVjdCB2bV9hcmVhX3N0cnVj
dCAqdm1hLCB1bnNpZ25lZCBsb25nIHN0YXJ0LA0KIAkJdXByb2JlX21tYXAoaW5zZXJ0KTsNCiAJ
fQ0KIA0KKwltYXNfZGVzdHJveSgmbWFzKTsNCiAJdmFsaWRhdGVfbW0obW0pOw0KIA0KIAlyZXR1
cm4gMDsNCi0tIA0KMi4zNS4xDQoNCg==

--_002_20220427224134yurrplclbhmnrlojrevolver_--