Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033537AbXEIDOO (ORCPT ); Tue, 8 May 2007 23:14:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S970510AbXEIDMh (ORCPT ); Tue, 8 May 2007 23:12:37 -0400 Received: from rgminet01.oracle.com ([148.87.113.118]:42734 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S970503AbXEIDMf (ORCPT ); Tue, 8 May 2007 23:12:35 -0400 Date: Tue, 8 May 2007 20:15:42 -0700 From: Randy Dunlap To: David Rientjes Cc: Satyam Sharma , Andrew Morton , Paul Sokolovsky , linux-kernel@vger.kernel.org, jeremy@goop.org Subject: Re: [PATCH] doc: volatile considered evil Message-Id: <20070508201542.3f4ebd5e.randy.dunlap@oracle.com> In-Reply-To: References: <516386418.20070501080839@gmail.com> <20070430235642.e576e917.akpm@linux-foundation.org> <20070508121404.17bd97a6.randy.dunlap@oracle.com> <20070508163452.8b71f682.randy.dunlap@oracle.com> <20070508190800.1334b968.randy.dunlap@oracle.com> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.3.1 (GTK+ 2.8.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Whitelist: TRUE X-Whitelist: TRUE X-Brightmail-Tracker: AAAAAQAAAAI= Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1214 Lines: 36 On Tue, 8 May 2007 19:38:56 -0700 (PDT) David Rientjes wrote: > On Tue, 8 May 2007, Randy Dunlap wrote: > > > "volatile" used on a gcc asm extension is different, granted. > > It's not even a C-language "volatile" keyword AFAICT, so it doesn't > > apply in this context. > > > > Using 'volatile' for an asm construct certainly is a keyword; in fact, C99 > defines 'volatile' as a token which is reserved for use as a keyword. touche' > > Anyway, how is this slightly modified title? > > > > +***** "volatile" considered useless and evil: Just Say NO! ***** > > + > > +Do not use the C-language "volatile" keyword on kernel data > > +(extracted from lkml emails from Linus) > > > > It's still ambiguous. A much more explicit title that nobody could argue > with would be "do not use the 'volatile' keyword as a type qualifier for > an object." OK, I can accept that. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/