Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
To:     David Jeffery <djeffery@redhat.com>, target-devel@vger.kernel.org
Cc:     "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-kernel@vger.kernel.org,
        Laurence Oberman <loberman@redhat.com>,
        linux-scsi@vger.kernel.org
Subject: Re: [PATCH] target: pscsi: set SCF_TREAT_READ_AS_NORMAL flag only if there is valid data
Date:   Wed, 27 Apr 2022 22:55:19 -0400
Message-Id: <165111450538.20789.16658928197210500441.b4-ty@oracle.com>
In-Reply-To: <20220427183250.291881-1-djeffery@redhat.com>
References: <20220427183250.291881-1-djeffery@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 27 Apr 2022 14:32:50 -0400, David Jeffery wrote:

> With tape devices, the SCF_TREAT_READ_AS_NORMAL flag is used by the target
> subsystem to mark commands which have both data to return as well as
> sense data. But with pscsi, SCF_TREAT_READ_AS_NORMAL can be set even if
> there is no data to return. The SCF_TREAT_READ_AS_NORMAL flag causes the
> target core to call iscsit datain callbacks even if there is no data, which
> iscsit does not support. This results in iscsit going into an error state
> requiring recovery and being unable to complete the command to the
> initiator.
> 
> [...]

Applied to 5.18/scsi-fixes, thanks!

[1/1] target: pscsi: set SCF_TREAT_READ_AS_NORMAL flag only if there is valid data
      https://git.kernel.org/mkp/scsi/c/8be70a842f70

-- 
Martin K. Petersen	Oracle Linux Engineering