Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <000000000000a23c8505dda227eb@google.com> <000000000000f28f0005dda29992@google.com>
 <20220427102032.5a87283eb64d06c1a6d682fd@linux-foundation.org>
 <20220427175218.cazytgdlpc6lpn45@revolver> <20220427190622.wgoxjjbmphdo3xxw@revolver>
In-Reply-To: <20220427190622.wgoxjjbmphdo3xxw@revolver>
From:   Dmitry Vyukov <dvyukov@google.com>
Date:   Thu, 28 Apr 2022 07:13:25 +0200
Message-ID: <CACT4Y+YvDPF=_cEZ5bREPN1tgqdMYydiEmDbtzrTq_C2CyyT5w@mail.gmail.com>
Subject: Re: [syzbot] WARNING in vma_merge
To:     Liam Howlett <liam.howlett@oracle.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        syzbot <syzbot+7728e4ab5371cebc9c00@syzkaller.appspotmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "syzkaller-bugs@googlegroups.com" <syzkaller-bugs@googlegroups.com>,
        Peter Xu <peterx@redhat.com>,
        Qian Cai <quic_qiancai@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, 27 Apr 2022 at 21:06, Liam Howlett <liam.howlett@oracle.com> wrote:
>
> * Liam R. Howlett <Liam.Howlett@Oracle.com> [220427 13:52]:
> > * Andrew Morton <akpm@linux-foundation.org> [220427 13:20]:
> > > On Wed, 27 Apr 2022 06:15:20 -0700 syzbot <syzbot+7728e4ab5371cebc9c00@syzkaller.appspotmail.com> wrote:
> > >
> > > > syzbot has found a reproducer for the following issue on:
> > >
> > > Thanks.
> > >
> > > userfaultfd_release() appears to have offended vma_merge().
> >
> > Potentially apply_mlockall_flags() and not userfaultfd_release(). There
> > is a potential that the vma iterator is stale if a split/merge succeeds,
> > although KASAN should pick this up and KASAN is active according to the
> > config below. I've sent a patch for the mlockall issue after Qian Cai's
> > reported it to linux-mm.
> >
> > >
> > > I'm not seeing any changes in that area from Peter, but Liam's
> > > mapletree work changed things around a bit.  Gents, could you please
> > > take a look?
> > >
> > >
> > > > HEAD commit:    f02ac5c95dfd Add linux-next specific files for 20220427
> > > > git tree:       linux-next
> > > > console output: https://syzkaller.appspot.com/x/log.txt?x=105a33a2f00000
> > > > kernel config:  https://syzkaller.appspot.com/x/.config?x=e9256c70f586da8a
> > > > dashboard link: https://syzkaller.appspot.com/bug?extid=7728e4ab5371cebc9c00
> > > > compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> > > > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=15f76f82f00000
> > > > C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=12b42c3cf00000
> > > >
> > > > IMPORTANT: if you fix the issue, please add the following tag to the commit:
> > > > Reported-by: syzbot+7728e4ab5371cebc9c00@syzkaller.appspotmail.com
> > > >
>
> ...
>
> >
> > I cannot get this issue to trigger with the given tree and git repo with
> > my config.  I will try again with the kernel config above.
>
>
> I was able to reproduce the issue using the config from syzkaller in my
> VM and can confirm it was the apply_mlockall_flags() bug also reported
> by Qian Cai [1].  The patch I sent earlier [2] fixes this issue as well.
>
>
> 1. https://lore.kernel.org/linux-mm/20220427161033.GA1935@qian/
> 2. https://lore.kernel.org/linux-mm/20220427165139.5s3qcj2u5vqrvwlc@revolver/
>
> Thanks,
> Liam

Let's tell syzbot about the fix:
#syz fix: mm/mlock: use maple state in apply_mlockall_flags()