Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e4e5bd41-df5b-bb65-b92f-47122d1e7738@amd.com>
Date:   Thu, 28 Apr 2022 10:03:07 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] dma-buf: add the name field to the table header
Content-Language: en-US
To:     Yuanzheng Song <songyuanzheng@huawei.com>, sumit.semwal@linaro.org,
        dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220428063924.3570409-1-songyuanzheng@huawei.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220428063924.3570409-1-songyuanzheng@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1h6SXo4NjVpT1MvVjFFZFBFRUlSajhUclRidHR4czBGZ2NIdzRkckF5SlJk?=
 =?utf-8?B?dTdhSmZ5VFFMM2tFUjZyamNVQUdReE1UaEo4dURtdzl3VXVkOTl3ZTlKVnJ6?=
 =?utf-8?B?TEZRRTRla282blJRb1hacGtmN3JMemVOUE9Ca285ak4xb0FBYXF4UkpvRzBq?=
 =?utf-8?B?L1BqYmk0eE5KVTh4ellnc2E4WUl1NVZrWGNuUXprVGRqT1RmbjNrLzk2MmdP?=
 =?utf-8?B?WFdvNGwreWRPeHdPUTJaVlY5akVxOGpEMzZ4QjRldlNKcXd2SG5MdHRJT3N0?=
 =?utf-8?B?VVczbzcrdThSM1AzLzIxVkZNZXRzbDBNMEhGV0VqYzJqNXJQbStIZGtTc3FV?=
 =?utf-8?B?emxiTmNld1JhaURJUWwyYXRFbFhCNU1TRDI2NXlmdlJ4RFFSZ01LRGgybitT?=
 =?utf-8?B?RkNTaGQvRW9EM29ObUVlQzUzWXNkMmRaTnpaQzZqWEQraEJKc1RVM1FaVGhG?=
 =?utf-8?B?SG1pdkJqeVNsVDNyQzMwU082dTdLYURlQmc0NitOVVRBWkJuL2xlYlMzSGFi?=
 =?utf-8?B?dXZsQlNIN1o1QnpGYjVhc3VVVXgwb3RaOEFqMEJjRWIxYitXYmdENWFPdzlH?=
 =?utf-8?B?RkFsUlNTcG14eVNib2lOL2U4Z1ZoZm9HWDlFLzZLcjdiL251S2I4YzUrZ25v?=
 =?utf-8?B?TkZkeHpLSlhES3JkQWhveWdPS2RIU2t3cHdtOW5aN3B1dklacms4cjBGZUNG?=
 =?utf-8?B?bHZCa1dkNFJwanVldGo1YkkwRlMxSTg2UWVFZG1IYjFBbkh2L0kyQ1pkdWtK?=
 =?utf-8?B?Ujh3M0d1SDhUL0cvODk5Ly81ZmF2YTlNaFNnbDZrUEx2R1YxcnUxOGFUY01o?=
 =?utf-8?B?WkE2cEIxTkczMXdQbmxqU3JJSWFZQ1AzRXJLZHpxak1Rdkc5c0EvSlR3VlRw?=
 =?utf-8?B?SWF2WC8zQldUSlJ4dXQxS3pPRmRlY2l3MDg3MCtZNmthczVEbUlwTG5xQWhv?=
 =?utf-8?B?NE9lMWhDek4wSnduQmhRT1dYRTYvZjJOQWRvTGtTZldoTlBVR1Z1bFFKUWVQ?=
 =?utf-8?B?Zk5GVy9yN3lXeFlKSitXWWxKNHhKbVZDeUtkRWtoUUNyZkswZ3d4dFZkT3pQ?=
 =?utf-8?B?dFhBUDZKcldxaUdGMm1nRk02RjNRMzNHeGw5cmVSYTNiS1lzODI2WUsxK3NW?=
 =?utf-8?B?OXFCa1J3L1E1aTYwMUdrRmIwYkxrRjRPV2tybmxXSCtIaSszWGRtdW5QQ2J3?=
 =?utf-8?B?L2Yrbm1RRjBpOFcwaTExaDZ5TmVZYlFhTGVucU10aVhmd0tJbDFNcUMzcG90?=
 =?utf-8?B?VlJTTDNiUHFBYVd3MDhLcGZFYmxpYk1nWjNmNHJhTG9vcUVDYzZ4QUg2L1Zt?=
 =?utf-8?B?SGpTL2pVZm9QZk4xcUdJVjZCR1F0ckIybEpXcjN3ZEJudXcxOU1lOVMvbDBX?=
 =?utf-8?B?dGtrMnBPMmdxYXAwVnlJWXYvRURJU1k4Wlg5dG1vUWQwT1JjZGdoQzJ0K1VC?=
 =?utf-8?B?WXhuSVN6andMY0xKbUNSOHdSaVEyR1R2T1ZySmFBcDB4Sy9Nd3hTL1VoZFNl?=
 =?utf-8?B?NkRuZ2p5cEhqVS9oOU5LczlzV3VTNVFVcCtOVUUxQ0RWcVV5eENFem5rMGcr?=
 =?utf-8?B?S1VQYnFKc1ZmaG50SUxaU3RDQ2lodE00NE5VaHd4QnZVcklObUxKTEZsZk5p?=
 =?utf-8?B?bnhyeWdCc0VlSDluUWwzVWZVcVlMbGVhL2s1MWJWbEI2Tk9jSXEwRUw2UzAy?=
 =?utf-8?B?cVNFSmlodkNVUjE4aGhnRDFXMWJiajZkYVBpVWJqczI5dVFxcFkvSlhOL1lX?=
 =?utf-8?B?b1Q3WHJ6S0xoRWNuMEtYcmYwTTE4WTRtZU1yaVMxNHFaK3JlR3A2MVl2Q2VF?=
 =?utf-8?B?NU9UT3ZHaWJteFUwTFdoK3lOdFhOaExFZkRBUWxBbERJQVVaeGNpQzBwb2tU?=
 =?utf-8?B?WTNLbUw5VTJ2bWJNdVVLRVJQK3hEMDUxcWhqRzRzbWZaTFRGaVdBRy9wSVpr?=
 =?utf-8?B?bEFwUUNldlhJS2J6bDNSME1BSmh2eDJMRTJNWStyd2wxNWJQMitUekFLQmcv?=
 =?utf-8?B?dzBQeVBEV2NZUzEwT3RTR1hkdVA1THp1ekd5SEx2YTV0eWNlekZlQ0x3bWlt?=
 =?utf-8?B?Z25tcEVPV3FHa1p6L2tXMDdkM3Q5UGIyZkhvOVBzTHB4cXdXUlRBZE5tTEc3?=
 =?utf-8?B?UHJUTTJycEY2ditoYmo5VkNLQVlza2czRlgzdmYzY2o1dDQyVnlkZ2J1Q1Ey?=
 =?utf-8?B?MUF1UDBpNitDZm0zYUpUMStYSXluTVJhTHdZWFYvenNLZkVsY2hxZ1RIakZp?=
 =?utf-8?B?NCtQcEcvN1VUZXBZb3BGYzZhR3NHcU9rN3BvdXE3M0taRjFPVGRkUTNVMDgy?=
 =?utf-8?B?NmZ5TWVBUnJySmhqbjViMldRSWMzTjFrNXdIaFEzYjNyWkFXc1Y5UT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 05c5c62b-a968-4919-a004-08da28ed89cb
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 08:03:11.2561
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9QW8ZBK+vaC+B0x9hepI5Qj0+/Ne1Px6B9tY6RAYSZB8iM6gpktyFU4qTcKbDNZE
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6306
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 28.04.22 um 08:39 schrieb Yuanzheng Song:
> 'cat /sys/kernel/debug/dma_buf/bufinfo' will print the Dma-buf
> Objects' information when the CONFIG_DEBUG_FS=y.
> However, the printed table header information does not contain
> the name field. So we need to add the name field to the table
> header and use the '<none>' to replace the empty buf_obj->name.
>
> Signed-off-by: Yuanzheng Song <songyuanzheng@huawei.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

Sumit do you want to push this or should I go ahead?

> ---
>   drivers/dma-buf/dma-buf.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
> index 79795857be3e..a2f9a1815e38 100644
> --- a/drivers/dma-buf/dma-buf.c
> +++ b/drivers/dma-buf/dma-buf.c
> @@ -1351,7 +1351,7 @@ static int dma_buf_debug_show(struct seq_file *s, void *unused)
>   		return ret;
>   
>   	seq_puts(s, "\nDma-buf Objects:\n");
> -	seq_printf(s, "%-8s\t%-8s\t%-8s\t%-8s\texp_name\t%-8s\n",
> +	seq_printf(s, "%-8s\t%-8s\t%-8s\t%-8s\texp_name\t%-8s\tname\n",
>   		   "size", "flags", "mode", "count", "ino");
>   
>   	list_for_each_entry(buf_obj, &db_list.head, list_node) {
> @@ -1368,7 +1368,7 @@ static int dma_buf_debug_show(struct seq_file *s, void *unused)
>   				file_count(buf_obj->file),
>   				buf_obj->exp_name,
>   				file_inode(buf_obj->file)->i_ino,
> -				buf_obj->name ?: "");
> +				buf_obj->name ?: "<none>");
>   		spin_unlock(&buf_obj->name_lock);
>   
>   		dma_resv_describe(buf_obj->resv, s);