Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Paul Gortmaker <paul.gortmaker@windriver.com>
To:     linux-kernel@vger.kernel.org
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Aubrey Li <aubrey.li@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Len Brown <lenb@kernel.org>, linux-acpi@vger.kernel.org,
        Mark Gross <markgross@kernel.org>,
        platform-driver-x86@vger.kernel.org,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH 0/4] platform: allow ATOM PMC code to be optional
Date:   Thu, 28 Apr 2022 02:24:26 -0400
Message-Id: <20220428062430.31010-1-paul.gortmaker@windriver.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?glZWhnyLNDVrIFNfdmSHna/YPmTtc0+Ffo5b1NblEqYTwTdzK3o4L0nk6tcU?=
 =?us-ascii?Q?tIjfXLicchPdIqsa/HPpJ8n0g2giPjVcW0mV9jpOs3I5D5J0pGTyAnIKENZ5?=
 =?us-ascii?Q?ivEU/to96rdATn2rzBE+3HAKzTsEvggcExZdmffPv14xPT6VUAnoNL7ykHwz?=
 =?us-ascii?Q?dss2qfSlR8AEjpMkDVLQZ/IxFrxPhtFGprsaGEWHZhFdV7iZdry6crrDl+Mi?=
 =?us-ascii?Q?1vDnwp93UhlquKpBM6N3FhIDU79cESkqWolD8knC+KreSnpnHCR+QvAypyjK?=
 =?us-ascii?Q?yoXtSJwQm25cPa5R4DTNTxv3wwfc6Zrtco9qen2Wrv/u8hhzw0LQ1jKENbnQ?=
 =?us-ascii?Q?nI1DbxlGioPIxJsBwqv16ePJhZidbn8XR7hcS5KJF6k9WEMXpQJSUgOFozBj?=
 =?us-ascii?Q?nb/80en2WTwWkdht5mN+uo7BPyyOOgagBwfdF1vKlgI7j68NFxDfDyETwpkN?=
 =?us-ascii?Q?ldYTSwiN0utNcmQw7lSznmLRmYn2i13s8Pd4Pk+JbrJR0QUAvUFR3y7aCFW4?=
 =?us-ascii?Q?gtfLlRDNLcKXs6Rq3+LYmOnjsCG7oV1MucgHPgf1hfs8wm5m3DRvfKjtEt1L?=
 =?us-ascii?Q?yQTgKodhLh+KVddxSnhKEx7n9lzGs+xJTxjeJ5CJwjD/5VqKWDxsoeLkJglu?=
 =?us-ascii?Q?QoiRHyrddIEtAKTyo/HKGD1+oDAKo2Tl8tapaWo6j/hNzdJhTUaLKH6jmYGD?=
 =?us-ascii?Q?eJVR80EC+Stz2U1lOZj9HoKQZ3atcbb41h6R0nziMSsaz42+v9qEjiTlsGfs?=
 =?us-ascii?Q?WuoR+hmtQPP35Xlt9oamyiawvY13lAkyob1O8NqymwOESkZFPK83sOO8rHux?=
 =?us-ascii?Q?LOZUPHJR6rwgZGWK9EoY4dJTo67JixBMYStVyE+vDpXGx5PrLNN64O8huzq8?=
 =?us-ascii?Q?iudzoA2vZt921Dqig5cZLt0KE+Z2iRTgnynsbrH5zfx98yFEzf4BfscDJbOY?=
 =?us-ascii?Q?jAnXYJe5bojORdzcwkcUfQpup8zv+v4QNhAU/loGvc62EtfF9bca3DuIBGjm?=
 =?us-ascii?Q?E6vGImkvY1yxJVwV6bg/GEP1ZR44zdcjgqHeNcqH7zN7rwCEfRIE0dvb3zDG?=
 =?us-ascii?Q?qODWo+LoHvJhDLoiNf5d4wgAFgh5t3nrzhtWD3ISJdbBti9yTGnuAvLtFCD2?=
 =?us-ascii?Q?wU52tPSycPd9IrEC9sWJNnqrAlBIAnNVGQ/3nWYlVWByMx+qgLR6ObXiCuJw?=
 =?us-ascii?Q?cUfiXf2497L6O03cFeAtVQCYM6n/xgvwQvXuJXgKl7FxYIvJ7VWKeKVJfLf8?=
 =?us-ascii?Q?RNGvWu/iz3oqcOjNssdLV1DTX79fNJyEFvjB9mfn+Ims0K7PAyF9jNIpKnsk?=
 =?us-ascii?Q?irCeva3Gvo+5RDDE/Wdh4fAZV5vdZjYU8b0rHMGBY4yhTP8A1Bk0u8Tvhs9n?=
 =?us-ascii?Q?Bk2ZMUF2d6Q5HLhS00TyxUldMDPUSaKsf8r3ZPBPkn1v/Ns0ZYpCv/HvZZ4g?=
 =?us-ascii?Q?txBYx5lN6f+Oe3b1X7lH2vqEAlBRwo6cd7WHccambGLzIhduDUSZCVlgss9M?=
 =?us-ascii?Q?cjBkqR1hXfhiSNV9dKcNmlRt1gNtzHJAHdnh7uPtqrIdBwhy8b/7EOepCzrq?=
 =?us-ascii?Q?y5sfpD/9CeityIyASh8kmXh0pX+ncrqsoHKplx3eYCJRCXMWHYEqxK5kjRmK?=
 =?us-ascii?Q?dfJxA3GwnriNEJhXEeG0DIyQNgkRRk4VZodDm7hP5UDyEBJp3F6PadfItroj?=
 =?us-ascii?Q?6Gg8DzY7ijHQb3FoAWyNNoXZldNwbFpdDR5MjCkZ+tRTxDpvApP5x60GEHSN?=
 =?us-ascii?Q?VufqJtXAVPEKPIwf1bnmYPuSpRhS7wk=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cde7c2fd-9f3d-4211-5820-08da28dfcad2
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4545.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 06:24:47.6477
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oKcxZzVYduYKLkxFNhUFMjSJNrWJUDgznhJhIHUo/8GrA0LpBWblG7ZARucGL1uVLlTDhWutJOIuGXlOjOh0Z4uW/XhoLkkw/CwJMrKda/Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4921
X-Proofpoint-GUID: Ldl7JBRs2VlXkQpVXdjtQ-F_slI3JAoP
X-Proofpoint-ORIG-GUID: Ldl7JBRs2VlXkQpVXdjtQ-F_slI3JAoP
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-04-27_04,2022-04-27_01,2022-02-23_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0
 priorityscore=1501 lowpriorityscore=0 impostorscore=0 phishscore=0
 mlxlogscore=720 malwarescore=0 clxscore=1015 adultscore=0 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204280037
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

A few months back I was doing a test build for "defconfig-like" COTS
hardware and happened to notice some pmc-atom stuff being built.  Fine,
I thought - the defconfig isn't minimal - we all know that - what Kconfig
do I use to turn that off?  Well, imagine my surprise when I found out
you couldn't turn it [Atom Power Management Controller] code off!

Normally we all agree to not use "default y" unless unavoidable, but
somehow this was added as "def_bool y" which is even worse ; you can
see the Kconfig setting but there is *no* way you can turn it off.

After investigating, I found no reason why the atom code couldn't be
opt-out with just minor changes that the original addition overlooked.

And so this series addreses that.  I tried to be sensitive to not
break any existing configs in the process, but the defconfig will
now intentionally be different and exclude this atom specific code.

Using a defconfig on today's linux-next, here is the delta summary:

$ ./scripts/bloat-o-meter -c ../pmc-atom-pre/vmlinux ../pmc-atom-post/vmlinux|grep add/remove
add/remove: 0/410 grow/shrink: 0/7 up/down: 0/-47659 (-47659)
add/remove: 0/105 grow/shrink: 0/1 up/down: 0/-6848 (-6848)
add/remove: 0/56 grow/shrink: 0/1 up/down: 0/-10155 (-10155)

$ ./scripts/bloat-o-meter -c ../pmc-atom-pre/vmlinux ../pmc-atom-post/vmlinux|grep Total
Total: Before=13626994, After=13579335, chg -0.35%
Total: Before=3572137, After=3565289, chg -0.19%
Total: Before=1235335, After=1225180, chg -0.82%

It is hard to reclaim anything against the inevitable growth in
footprint, so I'd say we should be glad to take whatever we can.

Boot tested defconfig on today's linux-next on older non-atom COTS.

Paul.

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Aubrey Li <aubrey.li@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
Cc: Mark Gross <markgross@kernel.org>
Cc: platform-driver-x86@vger.kernel.org
Cc: "Rafael J. Wysocki" <rafael@kernel.org>

---

Paul Gortmaker (4):
  platform/x86: pmc_atom: remove unused pmc_atom_write()
  ACPI: LPSS: make the Kconfig dependency on PMC_ATOM explicit
  platform/x86: pmc_atom: dont export pmc_atom_read - no modular users
  platform/x86: pmc_atom: make the PMC driver actually unselectable

 arch/x86/Kconfig                           |  1 +
 drivers/platform/x86/Kconfig               | 11 ++++++++---
 drivers/platform/x86/pmc_atom.c            | 13 -------------
 include/linux/platform_data/x86/pmc_atom.h |  1 -
 4 files changed, 9 insertions(+), 17 deletions(-)

-- 
2.17.1