Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5c04f8e6-6522-d26c-29fc-60eb18d4ad90@xs4all.nl>
Date:   Thu, 28 Apr 2022 08:50:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] Documentation/media: Remove incorrect statement
Content-Language: en-US
To:     Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@puri.sm
References: <20220422074024.1329082-1-dorota.czaplejewicz@puri.sm>
From:   Hans Verkuil <hverkuil@xs4all.nl>
In-Reply-To: <20220422074024.1329082-1-dorota.czaplejewicz@puri.sm>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Dorota,

On 22/04/2022 09:50, Dorota Czaplejewicz wrote:
> Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
> ---
> Hi,
> 
> I tried to debug streaming in libcamera, where I stumbled upon this. I asked around on IRC where I was told that this statement in the documentation is wrong, so I'm submitting a removal.

For future reference: a patch needs to start with a commit message,
followed by your Signed-off-by, then '---' and the patch itself.

I've taking the paragraph above as the commit message, so no need for
you to do anything here.

Regards,

	Hans

> 
> Cheers,
> Dorota Czaplejewicz
> 
>  Documentation/userspace-api/media/v4l/vidioc-streamon.rst | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Documentation/userspace-api/media/v4l/vidioc-streamon.rst b/Documentation/userspace-api/media/v4l/vidioc-streamon.rst
> index 0bc86f06947b..1a79313a29fa 100644
> --- a/Documentation/userspace-api/media/v4l/vidioc-streamon.rst
> +++ b/Documentation/userspace-api/media/v4l/vidioc-streamon.rst
> @@ -43,8 +43,7 @@ the capture or output process during streaming
>  Capture hardware is disabled and no input buffers are filled (if there
>  are any empty buffers in the incoming queue) until ``VIDIOC_STREAMON``
>  has been called. Output hardware is disabled and no video signal is
> -produced until ``VIDIOC_STREAMON`` has been called. The ioctl will
> -succeed when at least one output buffer is in the incoming queue.
> +produced until ``VIDIOC_STREAMON`` has been called.
>  
>  Memory-to-memory devices will not start until ``VIDIOC_STREAMON`` has
>  been called for both the capture and output stream types.