Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp346620iob; Thu, 28 Apr 2022 03:58:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSIBMop/UhrYRPGoDGe8vFUCLKw4s59JRyv4vQAdiKuZaNHfKiPxPMacShkirvZFJJs0ot X-Received: by 2002:a17:907:7202:b0:6df:83a9:67d2 with SMTP id dr2-20020a170907720200b006df83a967d2mr30475210ejc.327.1651143511066; Thu, 28 Apr 2022 03:58:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651143511; cv=none; d=google.com; s=arc-20160816; b=od+DiA2iOG5RBs2EPrwW220bXO3gYigl1pGRKrhdKqbm01guBYoKKGINK+kmx/r7gl Twnn4ftUrOj3hfg7TQSoYpXH/o3Ulhox7dCA2tLB/Piaka11f0wwXf7iHdFs0pw+1s5S 07akTn4ctenrz4zsSexSDOxM8hZqVNZERTFLlPbmTtspCftXLUVzRW1xas9Em2ZSByno +/vO9Xw60Asy27zXZbO4th2jKMhAOMy40rXnxahSnlvMev8tTiZSZC4gP3wVfomo2ZsK sokiPvb/m9cYxDuRz6q47coG7hX6g8PR/LVDvqdPGyzN/yxuLkDA14M4VzveTxtLzHiw TwKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id; bh=depPIWJpkeJFvb1UuhwXD8PG4Lksbr7cyTqfHWzwCs0=; b=KuUOYiB4jr9Q7X2Y2WEjcaMyIAGotux5vwIctwE35iSUzgmNmGG5bxUBF7s4oYtLT1 VUtIHay5/VW0EuNq4lZcTvFBI6OQhsJQdjwzecUSArPkOUaWDCEqHMeZAXjjbq6BD873 Y5+NM00h4AS/grkQn287GH9mljPK98anQpAOaDADNWcBmTXf8+ljDvekZ4sbRIogAo8I /v60ARGmxrVbhWU8S+1Zz05wivvETeP3ffXY34S8yGGjyvrQ9/nSyDYiij2LeTXoS1BP l8/OizTit+QEemjdPvWosaA9Dhz7egi5jAzEEh8u5xHAP7HsFhWSz9Be59RvEDJEVC2s fwzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o19-20020a17090637d300b006df79ec22fdsi3419929ejc.567.2022.04.28.03.58.08; Thu, 28 Apr 2022 03:58:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230134AbiD1KXG convert rfc822-to-8bit (ORCPT + 99 others); Thu, 28 Apr 2022 06:23:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbiD1KXF (ORCPT ); Thu, 28 Apr 2022 06:23:05 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 879AB294 for ; Thu, 28 Apr 2022 03:19:51 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nk1FJ-0007p7-Ru; Thu, 28 Apr 2022 12:19:37 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nk1FI-005jdQ-Kb; Thu, 28 Apr 2022 12:19:35 +0200 Received: from pza by lupine with local (Exim 4.94.2) (envelope-from ) id 1nk1FG-0006Kp-GQ; Thu, 28 Apr 2022 12:19:34 +0200 Message-ID: <3f40330f76e27dbe3162c31c3e33837e2d0433e0.camel@pengutronix.de> Subject: Re: [PATCH V5] mmc: sdhci-msm: Reset GCC_SDCC_BCR register for SDHC From: Philipp Zabel To: Shaik Sajida Bhanu , agross@kernel.org, bjorn.andersson@linaro.org, adrian.hunter@intel.com, ulf.hansson@linaro.org, chris@printf.net, venkatg@codeaurora.org, gdjakov@mm-sol.com, quic_asutoshd@quicinc.com Cc: linux-arm-msm@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, quic_rampraka@quicinc.com, quic_pragalla@quicinc.com, quic_sartgarg@quicinc.com, quic_nitirawa@quicinc.com, quic_sayalil@quicinc.com Date: Thu, 28 Apr 2022 12:19:34 +0200 In-Reply-To: <1650816153-23797-1-git-send-email-quic_c_sbhanu@quicinc.com> References: <1650816153-23797-1-git-send-email-quic_c_sbhanu@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On So, 2022-04-24 at 21:32 +0530, Shaik Sajida Bhanu wrote: > Reset GCC_SDCC_BCR register before every fresh initilazation. This will > reset whole SDHC-msm controller, clears the previous power control > states and avoids, software reset timeout issues as below. > > [ 5.458061][ T262] mmc1: Reset 0x1 never completed. > [ 5.462454][ T262] mmc1: sdhci: ============ SDHCI REGISTER DUMP =========== > [ 5.469065][ T262] mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00007202 > [ 5.475688][ T262] mmc1: sdhci: Blk size: 0x00000000 | Blk cnt: 0x00000000 > [ 5.482315][ T262] mmc1: sdhci: Argument: 0x00000000 | Trn mode: 0x00000000 > [ 5.488927][ T262] mmc1: sdhci: Present: 0x01f800f0 | Host ctl: 0x00000000 > [ 5.495539][ T262] mmc1: sdhci: Power: 0x00000000 | Blk gap: 0x00000000 > [ 5.502162][ T262] mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00000003 > [ 5.508768][ T262] mmc1: sdhci: Timeout: 0x00000000 | Int stat: 0x00000000 > [ 5.515381][ T262] mmc1: sdhci: Int enab: 0x00000000 | Sig enab: 0x00000000 > [ 5.521996][ T262] mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000 > [ 5.528607][ T262] mmc1: sdhci: Caps: 0x362dc8b2 | Caps_1: 0x0000808f > [ 5.535227][ T262] mmc1: sdhci: Cmd: 0x00000000 | Max curr: 0x00000000 > [ 5.541841][ T262] mmc1: sdhci: Resp[0]: 0x00000000 | Resp[1]: 0x00000000 > [ 5.548454][ T262] mmc1: sdhci: Resp[2]: 0x00000000 | Resp[3]: 0x00000000 > [ 5.555079][ T262] mmc1: sdhci: Host ctl2: 0x00000000 > [ 5.559651][ T262] mmc1: sdhci_msm: ----------- VENDOR REGISTER DUMP----------- > [ 5.566621][ T262] mmc1: sdhci_msm: DLL sts: 0x00000000 | DLL cfg: 0x6000642c | DLL cfg2: 0x0020a000 > [ 5.575465][ T262] mmc1: sdhci_msm: DLL cfg3: 0x00000000 | DLL usr ctl: 0x00010800 | DDR cfg: 0x80040873 > [ 5.584658][ T262] mmc1: sdhci_msm: Vndr func: 0x00018a9c | Vndr func2 : 0xf88218a8 Vndr func3: 0x02626040 > > Fixes: 0eb0d9f4de34 ("mmc: sdhci-msm: Initial support for Qualcomm chipsets") > Signed-off-by: Shaik Sajida Bhanu > --- > > Changes since V4: > - Called reset_control_put() in error path. Reviewed-by: Philipp Zabel regards Philipp