Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Song Liu <songliubraving@fb.com>
To:     Linus Torvalds <torvalds@linux-foundation.org>
CC:     bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Kernel Team <Kernel-team@fb.com>,
        Christoph Hellwig <hch@infradead.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Song Liu <song@kernel.org>
Subject: Re: [PATCH bpf v2 0/3] bpf: invalidate unused part of bpf_prog_pack
Thread-Topic: [PATCH bpf v2 0/3] bpf: invalidate unused part of bpf_prog_pack
Thread-Index: AQHYWOUphDgBQzjiX0ac6c+Sg/0OBq0EVWkA
Date:   Wed, 27 Apr 2022 22:10:29 +0000
Message-ID: <FF2E0EC1-F9D6-4196-8887-919207BDC599@fb.com>
References: <20220425203947.3311308-1-song@kernel.org>
In-Reply-To: <20220425203947.3311308-1-song@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eLlAFkpy+R97OtvaXbplECFspHVg6FuKZiglWaSQNZfbGyQvgvRqrXCGl1O0?=
 =?us-ascii?Q?lixs8+1b1VxEqxazd0lw7oH7gjGczw7TwFgDLxu6/J353lWtYfquVmA21iWK?=
 =?us-ascii?Q?HL6jXAerQUMcfKPi9UqOpKjoS1di7LLUniZ35ENf2EZwbWOSTAeqN9JhfC3v?=
 =?us-ascii?Q?gQRfRt8IDEvdCxZNkhZSI/ecifMcFOVMZ/4vvBLhDpuIsg7FufLg/fKc2gws?=
 =?us-ascii?Q?nnglrnpQlU0Um6WyAtAUmhZXCnuge4vKHcoIOYSCkWQ3xDNA9O88Kt4vQUhH?=
 =?us-ascii?Q?rQhO0WriaYMQLrjJIY/nqYqBiK3x1ZDUzdKW66gCFV71PRieIT6w8qKUYyuB?=
 =?us-ascii?Q?MhS54YfQQVhE2Hu8DzsigEifLEc4W8RwwbXBvnFwU7f9cdHznMfmKM3rPnub?=
 =?us-ascii?Q?L8cT//QHFbtuc1lZD6HKed/qnHWKw/ia4DjsQj4vfRtsu3p6ZOtCm+yktLqV?=
 =?us-ascii?Q?xQ0AJGnjP2nxBQc1jaoen37y3erd2cK4m5FQsvaGhGuSTSgh2141MI7M0Rbz?=
 =?us-ascii?Q?G/jgNjoQPsxlTZ4Q+Gc6oDA7y7beFmrnrWKluVOubsv6GQ2JN8tg2RQ3o3uE?=
 =?us-ascii?Q?TfJRoTUcpzHO4UeuVwdNHWdZYkI+h69uVQjnjmf7fppmaFW0LbviFKcgCVz3?=
 =?us-ascii?Q?S4cdVf0wsTCXVmTk9NnfNMMoLgwJ+PEgXmhSt+M8/MJQbkSkrKWQoDuUzMLN?=
 =?us-ascii?Q?8io423LKou/pk1yPFThLk2kb9+wQdovXK0858St9QWX+d3ABmh4GR750rZmN?=
 =?us-ascii?Q?Y7IBgMGJq2FDlHGAX+puc9lHdFRyfZjlPJ4JB7RkHF5INwizAk6SiBqsTmFK?=
 =?us-ascii?Q?+85uSDcExHEloilaICqDp2iA5DEugo8Yi2oG3J1y3zDA8+OEolkQWKSZt3Ae?=
 =?us-ascii?Q?7+7Rw3I/JjrDwRZdrOiFsippLkFcxmTuTTEUDU83W04a4v0oOzRHpfyQSACN?=
 =?us-ascii?Q?+qaAVH/tgxs9PE3ul+1wsPzkS6EWjeY1n5Oe0GIp4qmy73NK3+7qfJH7pGH8?=
 =?us-ascii?Q?wYpEi25wakxQBH7pTBw7W58LDNK9NGbUex8519+gHrRoXekEFSWtqGoFmNpK?=
 =?us-ascii?Q?TuqjVDf6blPVA8x4VeiH/MvOBmZVMtS0PjS9debxLWqw099wljtvvNldqnw/?=
 =?us-ascii?Q?mXmoJN3G6Uy7EWmuXzMZjSMHadmYP87snsYTZQjwQgRg3scD25ZCiXO4JPeg?=
 =?us-ascii?Q?qd0jK0lmjsSPB+/Au2clXwRt+WusHpWxH7Ot6F1pXHNP84MftEJBTIPuqfHX?=
 =?us-ascii?Q?wz0axwDWUJPHDLVrPL7I+NUQoIEJvTlcz6IHdqf/l/R4td/A26uzT6btWuQB?=
 =?us-ascii?Q?tnkKofyV4fzKmDNEV6NQBqiA65nmZGHFIDGNmoYL8BZb2j0NbvOoHnVC++CR?=
 =?us-ascii?Q?6a9ZvLVv936i4rzHSAhHj8mmwZLsY7OlTjuDThoCIEU2wX2As4j3PWHPsIeI?=
 =?us-ascii?Q?uK4/LeYysS7EbsG1cbwJnASsHbBxRmBj5hBl3SWrWVvKKw84E2ImMUweBUxX?=
 =?us-ascii?Q?4oX9zIvQFpBOaVKUnARnzKsZiRtb0jafwjweSSHNwpYR0nvQN9lGTmQFEsWF?=
 =?us-ascii?Q?ghKyNiKa1gMHe2I89O8Biy5NxujNmelc3/JuCyG68eu7rECkdZzrCtqAkXoy?=
 =?us-ascii?Q?eWwKw0N9QLEPmnLwdUQNEq8F07u5B2Lb+wjoiAOkwX7MnlBFB15aw8+spFrL?=
 =?us-ascii?Q?3tzSW32eli2NCA8ToyeXkMePwXrKO3888JjgTvBTclPBp6UvfS1HRsxi4ZX+?=
 =?us-ascii?Q?TRk7QbF4pSPsa/LAlnfv4vpNKWABlp3d1YBKEB0/oV6ia0iyctuZ?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <87A5FEB731A2C14EAE380B04BF2F7D2F@namprd15.prod.outlook.com>
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf7e484b-f10c-4e05-94ae-08da289abd8a
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 22:10:29.6084
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RSBCyeiDDsJF9BsxPL92QpLWxILjDlFI7LfRpfcAfburG1/45ewriV1VOdosPmclHMZyNnifOs/ookp6MBpysg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1266
X-Proofpoint-GUID: 7GH8w3TO3SD4tjc4GjEAaYVgbhRMi6zV
X-Proofpoint-ORIG-GUID: 7GH8w3TO3SD4tjc4GjEAaYVgbhRMi6zV
X-Proofpoint-UnRewURL: 0 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-04-27_04,2022-04-27_01,2022-02-23_01
X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Linus,

> On Apr 25, 2022, at 1:39 PM, Song Liu <song@kernel.org> wrote:
> 
> Note: while prefixed with "bpf", this set is based on Linus' master branch.
> 
> This is v2 of [1]. It is revised based on Peter's feedback. The patch is
> also split into 3.
> 
> [1] https://lore.kernel.org/linux-mm/20220421072212.608884-1-song@kernel.org/

Could you please share your suggestions on this set? Shall we ship it 
with 5.18?

Thanks,
Song

> 
> Song Liu (3):
>  bpf: fill new bpf_prog_pack with illegal instructions
>  x86/alternative: introduce text_poke_set
>  bpf: introduce bpf_arch_text_invalidate for bpf_prog_pack
> 
> arch/x86/include/asm/text-patching.h |  1 +
> arch/x86/kernel/alternative.c        | 70 ++++++++++++++++++++++++----
> arch/x86/net/bpf_jit_comp.c          |  5 ++
> include/linux/bpf.h                  |  1 +
> kernel/bpf/core.c                    | 18 +++++--
> 5 files changed, 81 insertions(+), 14 deletions(-)
> 
> --
> 2.30.2