Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp460667iob; Thu, 28 Apr 2022 06:19:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyq8nzHM7EiQyU8JzY4u452e1jphr8+Im97sbRjziAHKInMSR+9AffA214t8jv21j3I4Yl2 X-Received: by 2002:a17:907:94c2:b0:6f3:7424:1a2 with SMTP id dn2-20020a17090794c200b006f3742401a2mr25662969ejc.660.1651151956046; Thu, 28 Apr 2022 06:19:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651151956; cv=none; d=google.com; s=arc-20160816; b=ynhYxta2edaP11BWj6V4JEnTefEKgh0pSc4rbpCrCYUC3p+XyzHlkPV3hB1n7rxLC/ aVA3I7BIH+9JSPSbePQ/rKiQrvk1lzPhv2Z9ncFfNVi+Cyu8EW8eBW1fkzp57u7SvFl0 //Hjlx3aVt3u+wc2a1/CjQeb6/a4IJyGnaDirS8985FgU4GkmwA211AnXU12Z6NoIsL9 GaS2J4/I9VZSztJ8aOjFNxL7xI+OGfjK8jK7XmIF0dOe2i751njvD8dxEqc80lFTNxWQ a+mmOZTHtnAd37toA9J8gYoGfGkMXn/2kFw3hr5ppmZtPrfH55iJrTbkaS9KZN645sVM Jt2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=fhO5OWNs7ldbb0025j9mY6KX+Symbg/QpoLGDSOJ+uE=; b=rU2SZJbE+agg4JjuDR/GjCLslIdbJwQlaNMjuJVYAdhwluOb+bWx1qv+hos9GQ1B3h D4mXhqjmE9iuqout/7MPHoBKLnEKYcNAelElVwILIFdQX3UxO19MZHTH3p7FLB3seVv5 02OyR1eLUn8RiMLljI3bSRG/OGhmAcdu1TnQjZzvbEfTYs2XzPoEMkWdrhNguaoV4W8e sB5DrhmxHMPXXa2fpxsHK7yQcV9FeskjuwYhiC37EMO0nLI7QP4Slac3loeHSvKSLEOr MQY2jDQdpra7V27uGuWApTpC4IV4rzRE0PJgAvioCN8tM6qU+r0cUKn0hkZhhX7iOmDY Zlug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=enTIccuO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c17-20020a170906d19100b006f380ed6549si3674586ejz.309.2022.04.28.06.18.51; Thu, 28 Apr 2022 06:19:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=enTIccuO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345040AbiD1JXF (ORCPT + 99 others); Thu, 28 Apr 2022 05:23:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231823AbiD1JQr (ORCPT ); Thu, 28 Apr 2022 05:16:47 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 523A55DE40 for ; Thu, 28 Apr 2022 02:13:33 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23S85oPm014938; Thu, 28 Apr 2022 04:12:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=fhO5OWNs7ldbb0025j9mY6KX+Symbg/QpoLGDSOJ+uE=; b=enTIccuO6DnllbRS7rvvcVza73OAWwSHdlFrRddxjsHM8oHoiLCvVyF86O2c5uWo10tM setgC0y2gGV9AQ3RbFBqfB/ZGI2sAoJTzfwFMK6W0HFwsw0iGZGPDRmm93ciffyhh8AT p/bmFvcamhpZqtBZWmpOpUj+H0DsdWECX1OW0M2B7JKgcAmm9fHgSiaSJXTTah5SLCMB a6xaLBUkJGFqJAqVxpUW9krzeOW4T1LU6CgkuahSFmSlY/7NBspqAhgadCjEhIT7HAW+ otd/OawR1ZwBXYuiatGBpO663Mjdh0jZlg7dysV6QBW+6UVWaVeXq+v7OqOS8frYhwKC Ew== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3fprt61w5e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 28 Apr 2022 04:12:50 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 28 Apr 2022 10:12:48 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Thu, 28 Apr 2022 10:12:48 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 9276146C; Thu, 28 Apr 2022 09:12:48 +0000 (UTC) Date: Thu, 28 Apr 2022 09:12:48 +0000 From: Charles Keepax To: Vitaly Rodionov CC: Jaroslav Kysela , Takashi Iwai , Mark Brown , , , , Stefan Binding Subject: Re: [PATCH 20/26] ASoC: cs35l41: Add common cs35l41 enter hibernate function Message-ID: <20220428091248.GP38351@ediswmail.ad.cirrus.com> References: <20220427150720.9194-1-vitalyr@opensource.cirrus.com> <20220427150720.9194-21-vitalyr@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220427150720.9194-21-vitalyr@opensource.cirrus.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: GQdJADMGzk9gxOMYQuqQXSy4g2VGf6d1 X-Proofpoint-ORIG-GUID: GQdJADMGzk9gxOMYQuqQXSy4g2VGf6d1 X-Proofpoint-Spam-Reason: safe X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 27, 2022 at 04:07:14PM +0100, Vitaly Rodionov wrote: > From: Stefan Binding > > Since the CS35L41 HDA driver also support hibernation, it > makes sense to move code from the ASoC driver to enter > hibernation into common code. > > Since HDA must support laptops which do not support hibernation > due to lack of external boost GPIO it is necessary to > ensure the function returns an error when an unsupported > boost type is in use. > > Signed-off-by: Stefan Binding > Signed-off-by: Vitaly Rodionov > --- Acked-by: Charles Keepax Thanks, Charles