Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Paul Gortmaker <paul.gortmaker@windriver.com>
To:     linux-kernel@vger.kernel.org
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Aubrey Li <aubrey.li@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Len Brown <lenb@kernel.org>, linux-acpi@vger.kernel.org,
        Mark Gross <markgross@kernel.org>,
        platform-driver-x86@vger.kernel.org,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH 4/4] platform/x86: pmc_atom: make the PMC driver actually unselectable
Date:   Thu, 28 Apr 2022 02:24:30 -0400
Message-Id: <20220428062430.31010-5-paul.gortmaker@windriver.com>
In-Reply-To: <20220428062430.31010-1-paul.gortmaker@windriver.com>
References: <20220428062430.31010-1-paul.gortmaker@windriver.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lvUreOB5YZ8AC9MhMIG3o6S/XQJ/SslJr4zCkW6l+VXa362njxA1jxtfKBY9?=
 =?us-ascii?Q?ce1ar/pnhlB8skIVlRXZ2VAre2+C40672q/UFgIWRIVYmJpuKvfFU/9uBdhr?=
 =?us-ascii?Q?qTGaqpIyHwMhRDcQGqBaybtjGcha9MgQEGEAj1SC0XHPdYJva1G9VWoQt8XL?=
 =?us-ascii?Q?ZmglhhWwGkbimWmY+MdFEVPh1TtI6fiIPy6dkgK/IKGfqC28Q46snhLzQRnj?=
 =?us-ascii?Q?3iYwmkVyL9brjI1Bpam8/0mnBQ++vcMbZ+BT8KpcWUFIevqAd/b6t6L1ah0J?=
 =?us-ascii?Q?OjcUxVvb4520LDPxBFByKETd+qqzEVVCExC5ig4QHbho9IOuAIJrCoZuYiSW?=
 =?us-ascii?Q?LPQH4zyjSvN0sbK48gHP2QBNB7hOfnBi+5rae7n1Fn4HboEsa+5S1hqnNbsX?=
 =?us-ascii?Q?JewcDqDRtuJv2+ChTkL2FDI12O9Ls8/FeNs18BzT3/d2diQP0eC+/6xespE8?=
 =?us-ascii?Q?DsGFDMYiMEQx56hWLTbxhOZxNpuFf5v2IMdkLDZBdgw1b1Qkt0m/GyNPO/TU?=
 =?us-ascii?Q?5NSC6monpyA7FvV9NqX3b5HuW1k+LyigmaDH6bFieCtcbqi8PEJFd85MQBEd?=
 =?us-ascii?Q?3zEgUn8eE0I60BVcbXfD7Wetxt9147fR8JTpJ0m4mJ3qAPTcfY5gXNvDrP96?=
 =?us-ascii?Q?zT+H6JXUg4AvvTLfjArO3B2UkkikctDDzzsOU6GHylpZ8siOxrhpJt64wpbe?=
 =?us-ascii?Q?yyRfIm7eY82os8/J2RIiI1wLaSxoiBIUimHbTCInRBAXquX7LXQ5LvFt5wLW?=
 =?us-ascii?Q?YlTZjmdgyj+PjL6YFQ2hzkm1tAsTgZI8bOwC5smjE8fRpNZAjCQ/nE1+8dkS?=
 =?us-ascii?Q?RlCdZFSbdd8vJxyb9osuPI6GSFmPaTA+XBqTiVdDASCD57B+2SULyToDWRAM?=
 =?us-ascii?Q?EwoPvb5Kgnzf3Qen/rL9jRA0sVwtaYmplBZXdqAP+n8CyBLlKEhW1s0y27Z5?=
 =?us-ascii?Q?qD5Srx2jZPSljjeGyDa8WVvzFCnsYDKXNCv69L3vrQ64CVBl55Gj2q63N9jf?=
 =?us-ascii?Q?LcP+t9KfOWKe2YoR+zjn5BA/snEvf63V+75jbr+Koy42Y0NNIXyP71aJL0Ds?=
 =?us-ascii?Q?UXFWxBIPHD57AWudwcgRMHhFq4Voflp3vEXYg95h7d7AdicxzUpjS2+5eOdo?=
 =?us-ascii?Q?Emv50OHXTj96x8B4JGukjNXceZCR6/ypby/9Qzi0Hedukywui5H2sB2yN7zH?=
 =?us-ascii?Q?lZo+4gPnfHvwVsv6Dp40xMMjlL2Z7EkQYkZsSfqtbpQrCxterGDUeHy0FYL4?=
 =?us-ascii?Q?MeSbkK/s6gEN5AZwVRWMCDpc+dk1triptECfRKd90ZT6IgjHQE7rgYxyvd+c?=
 =?us-ascii?Q?BMXhAVAB2qw9DLyl0E9CU8fXnnGBlerHi/LUcPRtbT1KVV0AbFX8mRKcjS5v?=
 =?us-ascii?Q?NUOr4ZQwhIECxuSkiXCRGA3YvTP/80/8qMUk/8/qW0Kmhph7CD1H47tGYBcY?=
 =?us-ascii?Q?iHrYDaOf5jqhfQ3MPRvBAJaQkvOaN5x9uvzXFY8XRAT9oOyvLLwKZ5AHsAzy?=
 =?us-ascii?Q?ozmdFd7cdRzhRo2CGBPpahposXVqTxopn6uyKn3+e6/QnJir/0ykn3RcY21c?=
 =?us-ascii?Q?e+HwKWfhY9bGW+89W00uVhPR+EFuVG1TklA2NUA6h/8ah+yZbtQWEx2Lys1+?=
 =?us-ascii?Q?sD55n9NLoJU68dyeQIxw5RroOd55Eh8+5f/nqXRgfX8cN5ILcdoBcLInnzaV?=
 =?us-ascii?Q?FqAdBQVaIRspzLRn3jhLOGX+qnS3h8wffGy77l4VxVBvsbfJTE2j9X/jWiO2?=
 =?us-ascii?Q?If/H6ygZR1rtUA+NRoSe1QQap3tpBUU=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2cfa4685-ca95-415d-243b-08da28dfccb2
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4545.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 06:24:50.4328
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qbupXlzWtQVA9ufug5k/xiiQ7oocjySYJErQs05nxOTHbkdi39OE4z43qdba+YtYHv+jpBWzs/SpAPGkDF8JsM/PLd5Gqt3zUS+i1br4L/A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4921
X-Proofpoint-GUID: Ht-H5As48OOpJMxmyqvRlmbO51TLGpmM
X-Proofpoint-ORIG-GUID: Ht-H5As48OOpJMxmyqvRlmbO51TLGpmM
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-04-27_04,2022-04-27_01,2022-02-23_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0
 priorityscore=1501 lowpriorityscore=0 impostorscore=0 phishscore=0
 mlxlogscore=910 malwarescore=0 clxscore=1015 adultscore=0 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204280037
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This caught my eye when I saw it was def_bool and hence largely
pointless to have a Kconfig for it at all.

Yet there is no reason why you shouldn't be able to opt out of Atom
platform support if you only care about desktop and server class CPUs.

It was introduced as def_bool, but there is no obvious reason as to why
it was forcibly built-in for everyone, other than LPSS implicitly
relying on it (which is now fixed).  So here we fix up the Kconfig and
open the door for people to opt out.

Since putting "default y" on anything that isn't absolutely essential is
generally frowned upon, I made the default be CONFIG_MATOM.  People who
use "make oldconfig" or similar won't notice any difference.

The two "unchanged" lines for PCI and COMMON_CLK appear in the diff from
fixing a whitespace issue that somehow managed to live on despite being
moved between two different Kconfig files since its introduction.

Cc: Aubrey Li <aubrey.li@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Gross <markgross@kernel.org>
Cc: platform-driver-x86@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/platform/x86/Kconfig | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index f08ad85683cb..86459e99d831 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1163,6 +1163,11 @@ config WINMATE_FM07_KEYS
 endif # X86_PLATFORM_DEVICES
 
 config PMC_ATOM
-       def_bool y
-       depends on PCI
-       select COMMON_CLK
+	bool "Intel Atom SOC Power Management Controller driver"
+	default MATOM
+	depends on PCI
+	select COMMON_CLK
+	help
+	  This enables support for the Atom SOC Power Management Controller
+	  driver, and associated platform clocks.  If you intend to boot this
+	  kernel on platforms with an intel Atom CPU, say Y here.
-- 
2.17.1