Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220428063924.3570409-1-songyuanzheng@huawei.com> <e4e5bd41-df5b-bb65-b92f-47122d1e7738@amd.com>
In-Reply-To: <e4e5bd41-df5b-bb65-b92f-47122d1e7738@amd.com>
From:   Sumit Semwal <sumit.semwal@linaro.org>
Date:   Thu, 28 Apr 2022 15:24:49 +0530
Message-ID: <CAO_48GG6vX35HTZNXz5Bqf341K9+6a5M63Jxb+nYSbpWDqMH=w@mail.gmail.com>
Subject: Re: [PATCH] dma-buf: add the name field to the table header
To:     =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Cc:     Yuanzheng Song <songyuanzheng@huawei.com>,
        dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Christian,

On Thu, 28 Apr 2022 at 13:33, Christian K=C3=B6nig <christian.koenig@amd.co=
m> wrote:
>
> Am 28.04.22 um 08:39 schrieb Yuanzheng Song:
> > 'cat /sys/kernel/debug/dma_buf/bufinfo' will print the Dma-buf
> > Objects' information when the CONFIG_DEBUG_FS=3Dy.
> > However, the printed table header information does not contain
> > the name field. So we need to add the name field to the table
> > header and use the '<none>' to replace the empty buf_obj->name.
> >
> > Signed-off-by: Yuanzheng Song <songyuanzheng@huawei.com>
>
> Reviewed-by: Christian K=C3=B6nig <christian.koenig@amd.com>
>
> Sumit do you want to push this or should I go ahead?

No worries, I can push it out.

Thanks :)
>
> > ---
> >   drivers/dma-buf/dma-buf.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
> > index 79795857be3e..a2f9a1815e38 100644
> > --- a/drivers/dma-buf/dma-buf.c
> > +++ b/drivers/dma-buf/dma-buf.c
> > @@ -1351,7 +1351,7 @@ static int dma_buf_debug_show(struct seq_file *s,=
 void *unused)
> >               return ret;
> >
> >       seq_puts(s, "\nDma-buf Objects:\n");
> > -     seq_printf(s, "%-8s\t%-8s\t%-8s\t%-8s\texp_name\t%-8s\n",
> > +     seq_printf(s, "%-8s\t%-8s\t%-8s\t%-8s\texp_name\t%-8s\tname\n",
> >                  "size", "flags", "mode", "count", "ino");
> >
> >       list_for_each_entry(buf_obj, &db_list.head, list_node) {
> > @@ -1368,7 +1368,7 @@ static int dma_buf_debug_show(struct seq_file *s,=
 void *unused)
> >                               file_count(buf_obj->file),
> >                               buf_obj->exp_name,
> >                               file_inode(buf_obj->file)->i_ino,
> > -                             buf_obj->name ?: "");
> > +                             buf_obj->name ?: "<none>");
> >               spin_unlock(&buf_obj->name_lock);
> >
> >               dma_resv_describe(buf_obj->resv, s);
>

Best,
Sumit.