Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
To:     menglong8.dong@gmail.com, edumazet@google.com
Cc:     rostedt@goodmis.org, mingo@redhat.com, davem@davemloft.net,
        yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org,
        pabeni@redhat.com, benbjiang@tencent.com, flyingpeng@tencent.com,
        imagedong@tencent.com, kafai@fb.com, talalahmad@google.com,
        keescook@chromium.org, mengensun@tencent.com,
        dongli.zhang@oracle.com, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net: tcp: add skb drop reasons to
 route_req()
In-Reply-To: <20220428073340.224391-3-imagedong@tencent.com>
References: <20220428073340.224391-1-imagedong@tencent.com>
 <20220428073340.224391-3-imagedong@tencent.com>
Date:   Thu, 28 Apr 2022 15:22:04 +0200
Message-ID: <87fslxgx6r.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

menglong8.dong@gmail.com writes:

> From: Menglong Dong <imagedong@tencent.com>
>
> Add skb drop reasons to the route_req() in struct tcp_request_sock_ops.
> Following functions are involved:
>
>   tcp_v4_route_req()
>   tcp_v6_route_req()
>   subflow_v4_route_req()
>   subflow_v6_route_req()
>
> And the new reason SKB_DROP_REASON_SECURITY is added, which is used when
> skb is dropped by LSM.

Could we maybe pick a slightly less generic name? If I saw
"SKB_DROP_REASON_SECURITY" my first thought would be something related
to *network* security, like a firewall. Maybe just SKB_DROP_REASON_LSM?

-Toke