Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220420211105.14654-1-jagathjog1996@gmail.com>
 <20220420211105.14654-6-jagathjog1996@gmail.com> <CAHp75Ve8mruPEyorSmydAHM27rnL9Wv+qNdWyQ9tVxz-+JJYiQ@mail.gmail.com>
In-Reply-To: <CAHp75Ve8mruPEyorSmydAHM27rnL9Wv+qNdWyQ9tVxz-+JJYiQ@mail.gmail.com>
From:   Jagath Jog J <jagathjog1996@gmail.com>
Date:   Thu, 28 Apr 2022 02:31:47 +0530
Message-ID: <CAM+2EuJ3n4RVHVh9ZH-HkkjUm+zLLt=g34H5aOxPiDW673NOrw@mail.gmail.com>
Subject: Re: [PATCH v4 5/9] iio: accel: bma400: Add separate channel for step counter
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Dan Robertson <dan@dlrobertson.com>,
        Jonathan Cameron <jic23@kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Andy,

On Wed, Apr 27, 2022 at 6:04 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Wed, Apr 20, 2022 at 11:11 PM Jagath Jog J <jagathjog1996@gmail.com> wrote:
> >
> > Added channel for step counter which can be enable or disable
> > through the sysfs interface.
>
> ...
>
> > +static int bma400_enable_steps(struct bma400_data *data, int val)
> > +{
> > +       int ret;
> > +
> > +       if (data->steps_enabled == val)
> > +               return 0;
> > +
> > +       ret = regmap_update_bits(data->regmap, BMA400_INT_CONFIG1_REG,
> > +                                BMA400_STEP_INT_MSK,
> > +                                FIELD_PREP(BMA400_STEP_INT_MSK, !!val));
>
> > +       data->steps_enabled = val;
>
> This will update the value even if we got an error and actual device
> state is unknown here. Does this make sense?

I will correct this in the next series.

>
> > +       return ret;
> > +}
>
> ...
>
> I perhaps missed why kmalloc() is needed now. Any pointers to the discussion?

Here step is a 24-bit value and since this is a sysfs channel read (slow path),
kmalloc() is used to make the buffer DMA safe to read the multibyte value
using regmap_bulk_read().

>
> --
> With Best Regards,
> Andy Shevchenko

Thank you,
Jagath