Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Aleksey Romanov <AVRomanov@sberdevices.ru>
To:     Sergey Senozhatsky <senozhatsky@chromium.org>,
        "minchan@kernel.org" <minchan@kernel.org>
CC:     "minchan@kernel.org" <minchan@kernel.org>,
        "ngupta@vflare.org" <ngupta@vflare.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "axboe@chromium.org" <axboe@chromium.org>,
        kernel <kernel@sberdevices.ru>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "mnitenko@gmail.com" <mnitenko@gmail.com>,
        Dmitry Rokosov <DDRokosov@sberdevices.ru>
Subject: Re: [PATCH v2] zram: remove double compression logic
Thread-Topic: [PATCH v2] zram: remove double compression logic
Thread-Index: AQHYWh39fkxoPWqFH028+oB3r+sQB60Dbc4AgAIhEIA=
Date:   Thu, 28 Apr 2022 20:01:12 +0000
Message-ID: <20220428200107.hz65qvxf2aoz27q2@cab-wsm-0029881>
References: <20220427100345.29461-1-avromanov@sberdevices.ru>
 <YmkpSC/gJf7Cg2Ym@google.com>
In-Reply-To: <YmkpSC/gJf7Cg2Ym@google.com>
Accept-Language: ru-RU, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <93E992117724AD41B9856520CDF1E0BD@sberdevices.ru>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

Thanks for the reply!

On Wed, Apr 27, 2022 at 08:30:16PM +0900, Sergey Senozhatsky wrote:
> On (22/04/27 13:03), Alexey Romanov wrote:
> > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_dr=
v.c
> > index cb253d80d72b..4be6caf43b1d 100644
> > --- a/drivers/block/zram/zram_drv.c
> > +++ b/drivers/block/zram/zram_drv.c
> > @@ -1153,9 +1153,8 @@ static ssize_t debug_stat_show(struct device *dev=
,
> > =20
> >  	down_read(&zram->init_lock);
> >  	ret =3D scnprintf(buf, PAGE_SIZE,
> > -			"version: %d\n%8llu %8llu\n",
> > +			"version: %d\n%8llu\n",
> >  			version,
> > -			(u64)atomic64_read(&zram->stats.writestall),
> >  			(u64)atomic64_read(&zram->stats.miss_free));
> >  	up_read(&zram->init_lock);
>=20
> I think this also has to bump `version` to 2, since format of the
> file has changed.

Yes, I'll do that in the next patch.

Minchan, do you have any suggestions on this patch?=20
I want to fix Sergey suggestion and sumbit next patch.=