Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Prakash Sangappa <prakash.sangappa@oracle.com>,
        linux-kernel@vger.kernel.org
Cc:     akpm@linux-foundation.org, peterz@infradead.org, dave@stgolabs.net,
        manfred@colorfullife.com,
        Prakash Sangappa <prakash.sangappa@oracle.com>
Subject: Re: [PATCH v2] ipc: Update semtimedop() to use hrtimer
In-Reply-To: <1651158422-28014-1-git-send-email-prakash.sangappa@oracle.com>
References: <1651158422-28014-1-git-send-email-prakash.sangappa@oracle.com>
Date:   Thu, 28 Apr 2022 21:26:55 +0200
Message-ID: <874k2dovpc.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Prakash,

On Thu, Apr 28 2022 at 08:07, Prakash Sangappa wrote:
> semtimedop() should be converted to use hrtimer like it has been done
> for most of the system calls with timeouts. This system call already
> takes a struct timespec as an argument and can therefore provide finer
> granularity timed wait.

almost perfect :)

The v1->v2: description wants to be below the '---' separator. It's not
part of the changelog and just helpful for reviewers to assess the
history of the patch(set).

> v1->v2:
>   - Use timespec64_valid() to validate timeout
>      and other changes as suggested by Thomas Gleixner
>
> Signed-off-by: Prakash Sangappa <prakash.sangappa@oracle.com>
> ---
...
> @@ -2210,7 +2209,7 @@ long __do_semtimedop(int semid, struct sembuf *sops,
>  		/*
>  		 * If an interrupt occurred we have to clean up the queue.
>  		 */
> -		if (timeout && jiffies_left == 0)
> +		if (timed_out)
>  			error = -EAGAIN;
>  	} while (error == -EINTR && !signal_pending(current)); /* spurious */

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>