Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1252374iob; Fri, 29 Apr 2022 00:44:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkHWGotYBAuiUimb6gDFFLOmuF7oBsjnB1UV3zR68DVcGlJllDfizbd0xEJ+ydFtRW6lhU X-Received: by 2002:a05:6512:1291:b0:472:242c:c897 with SMTP id u17-20020a056512129100b00472242cc897mr10423569lfs.668.1651218296512; Fri, 29 Apr 2022 00:44:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651218296; cv=none; d=google.com; s=arc-20160816; b=gy/R3x6E/BDlRQzYS18fJlncT5FA72FU/A9QbUNDOehaoqpIUF6+HxdIOFgTkJEOfL IKpIFWdmTd1GFPi5RXtkOiTjRs6N/BAu8fjBFJj3KzVcnQmAlYwuCZd7jikDik2R05Nh xBJAGl3EMjZB0mxeciOiD7FrnojB58JKtpcvBGRBmOPxJ3Qm0oM4VNgv2ZLSKlt1CLpE ERhpgbvYq4qz0WlYlHlGyQZ8+i5EvlfWAEW1afQOcn31WKLagtRYGbMCrEhhhm4CEWzY WtjxTgiULxoyaBHVb9c9e/s7p8vFeuUn0N1GOxGvEnD6kHoXon1iyFwKcjOJ6Xfs4d4k dlZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=endm34N778Y0yPQpBj2UP5snb4XdIvtKjFf8w3OhWl8=; b=TLFLVrk6gvBIxzq0gWkZ5S57tAYpHo3b/Cw6MGFaXPdUjxmGvA6Svpde52+PwHoE+E xUGMH3x0lm+L/6gOsewaa6oXjWAnBStzov/c67Bh/E8yJ7g+Gt8Qo9uKDNEfmpvtEATG ZOKcQoEU8AqghHxVm/PPSspsO21JTs413m4x7yu4CT6jYY4N5J+VMfwg0afeiaRMa1bv yQrsrkXCkLAQfMXCiK0Uny230pteeKASHqJfnzvoa4QYbXcsaJlE6F8Ewe4Nyaqt3b3C qnCyo1vTR5OfnmXbQLjuuuBDwTkNZ+lim+PVuW8KMK3fdmutR0qF3zL9AlIdPnRZobfm D3Ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=LLeap5fb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h17-20020a2e3a11000000b0024f2d084714si5976143lja.219.2022.04.29.00.44.20; Fri, 29 Apr 2022 00:44:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=LLeap5fb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354280AbiD2FxO (ORCPT + 99 others); Fri, 29 Apr 2022 01:53:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354289AbiD2FxN (ORCPT ); Fri, 29 Apr 2022 01:53:13 -0400 Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BA47B18AB for ; Thu, 28 Apr 2022 22:49:55 -0700 (PDT) Received: by mail-qv1-xf30.google.com with SMTP id iy15so4701590qvb.9 for ; Thu, 28 Apr 2022 22:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=endm34N778Y0yPQpBj2UP5snb4XdIvtKjFf8w3OhWl8=; b=LLeap5fbMQ7b+CBIddQvpBa4S02DmgF9iWKlwwlY7N/Ft27Cf49xhkkH0FUBnoepSd yg2kvR+WLjB1EXt1DIp5XFbBMTOMYuts6P64qmU+fN3/kRke/u3r77g+atqGw9Ne6b3X f+HWlYDHVmhXMoKop4bbdBqyL+UgbHod2Y5HuaLbnx0AXMg23T6jwfHUYi6hfxZY+d6c P4e5BsNc6sozibBpMFDVLvCdij+x3IFCtgHc0seTmei1OZxmy2i3fq/5RoD/tIazF/7z nmyqLRu2GeTAwFVCYr+bLOiLCvNxB7J3ygB07QJ5YoDBBBo9i6ptDB7l2Yro46eMvRNa 0fRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=endm34N778Y0yPQpBj2UP5snb4XdIvtKjFf8w3OhWl8=; b=Qy4MYKam2Q6LmKbyqZSoSbsSPy1uCYojOqlXabzkE8JOnsr8zjCa2Xd8YkwWrUSkA3 E7J6KUcg1pCHhZc5fc6y7A77F2bfefD1yLXkl2FCG8eFy17XsAbskCy2eCKtshfZJcaT CUJ5/hEyJWS+FOmptxAzhJaFrPE4WkJVabQCD2XP/lmHXgz5KoGshDP/F1FCwxa89ZY9 OddHc7b+atfVKsZrKKVTLH/kZF6W9Nwhoxx9+/lIEamZ9e6z+LF8xJuUofMezlO/MwE9 jM5NyjK03NISoP9My6Zc89I38kTsL5lhVqYRM+b0MwIDFlbCClDI8fpCfE1PYAJ5VoO1 xazw== X-Gm-Message-State: AOAM530Imvr6OcEOFNauvQGd/QMekhn5UlbdRQrGZY4Q4Ln/VIAMTjYn D/a7tNP2BJyZ/MRJzeu1HQo= X-Received: by 2002:ad4:576a:0:b0:456:54f0:824f with SMTP id r10-20020ad4576a000000b0045654f0824fmr6965315qvx.31.1651211394421; Thu, 28 Apr 2022 22:49:54 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id h23-20020ac85697000000b002f387e4000dsm1146595qta.11.2022.04.28.22.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Apr 2022 22:49:54 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: chi.minghao@zte.com.cn To: emma@anholt.net Cc: mripard@kernel.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Minghao Chi , Zeal Robot Subject: [PATCH] drm/vc4: simplify the return expression of vc4_prepare_fb() Date: Fri, 29 Apr 2022 05:49:45 +0000 Message-Id: <20220429054945.3852039-1-chi.minghao@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Minghao Chi Simplify the return expression. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/gpu/drm/vc4/vc4_plane.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c index 920a9eefe426..b3438f4a81ce 100644 --- a/drivers/gpu/drm/vc4/vc4_plane.c +++ b/drivers/gpu/drm/vc4/vc4_plane.c @@ -1350,7 +1350,6 @@ static int vc4_prepare_fb(struct drm_plane *plane, struct drm_plane_state *state) { struct vc4_bo *bo; - int ret; if (!state->fb) return 0; @@ -1362,11 +1361,7 @@ static int vc4_prepare_fb(struct drm_plane *plane, if (plane->state->fb == state->fb) return 0; - ret = vc4_bo_inc_usecnt(bo); - if (ret) - return ret; - - return 0; + return vc4_bo_inc_usecnt(bo); } static void vc4_cleanup_fb(struct drm_plane *plane, -- 2.25.1