Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1338010iob; Fri, 29 Apr 2022 03:19:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXRYAPDdh80VnvHXM7fGsOgLtySqHYXwtXTRQ0MdcGSaGGUXjM/eg7ks8QjJkbD8zwMnHs X-Received: by 2002:a63:3f4e:0:b0:3aa:193b:8c5d with SMTP id m75-20020a633f4e000000b003aa193b8c5dmr32415815pga.624.1651227580611; Fri, 29 Apr 2022 03:19:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651227580; cv=none; d=google.com; s=arc-20160816; b=gkk7oSPTzNLUGFLC9i0nRFYVo2bCCuK1yuyzu0x3x5JTP2EsDI6w5Z28YSkFwU5Xwz guSpCM+2fG+ahswRPwzvUSrNvWwL1YJr7hvXSEERa7NtIsFDs4w/dUW/F1tc0GDoZFOm zfGJr7N4Qz3xeqxH7CKk5IUXayMnifNjVK/Hk0sD9sGWQ7MS5BV6OEFTBooav/Pi5Ebd IZ/Ji3S0aMX/XE3xVJEMCLjdEG9d/9+IyTINS2sDjmTGg/HYut4+SplUPs3nVDHgb5XN io6XdwX9819p/mkZLezLWU/EjnKR8B1oA0v8V1Ndl0uzWIQW62Yo3fuNTq2CN6h2anMt HB/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ywIQvVwgag1com6bDxPqmKMeB7A08MtYuevMsyOSOPQ=; b=JMGYfFUJaJR4EeXb9qJRRMpMK7HY8rzIo8uqQ0i++TtLJ95mzn3qjf17smymqHlTkl wSXxAxOg6tDWtOfHXedDJgwuh5Mq/gc7UP1tMiD/2o6QEeBfnZxLemDgw6aSh86/Z8ne fsoc6ye3tE6QfNoh/gWRJ6mU3d0GQzzsEnALlmF1Rx1qwP3xKkzVVT9I3cItvtBZ6kG3 RGaac1XCBNJYVUVHulFXisiTTamKHCIhYS30BEXTbH3yaph1mV8zWSF6/slcoQZ5giq9 CnLhAK+TCqJ/DfCt6Evu75IHMu+nx3Cx6FIGWjUU+xb6mAdmTk+mbHYS8hmTJga/w/xJ zu7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=8QDJnLhA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j12-20020a170902c3cc00b00158b259cf77si6391266plj.169.2022.04.29.03.19.25; Fri, 29 Apr 2022 03:19:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=8QDJnLhA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350522AbiD1Rbl (ORCPT + 99 others); Thu, 28 Apr 2022 13:31:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350510AbiD1Rbi (ORCPT ); Thu, 28 Apr 2022 13:31:38 -0400 Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D17DB45AC5 for ; Thu, 28 Apr 2022 10:28:23 -0700 (PDT) Received: by mail-qv1-xf36.google.com with SMTP id b17so3695149qvf.12 for ; Thu, 28 Apr 2022 10:28:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ywIQvVwgag1com6bDxPqmKMeB7A08MtYuevMsyOSOPQ=; b=8QDJnLhAmNHGsLaBQmDqBrcILYyDP9jv4WD9nDDyluZQ3AyEx3MdCGQSDqxW70SGO6 dHjEacPn670Cttc+vma5fsmybXQrEWDwOSriDm4M1zh/p8R0cfGR+P2UeAOOswBdPoPN UymIxmq005YN0pWaKnhy3Qt5T8fMP40inSpO/g4yKZyoeuGW2l3pub90YoPGUGQkiuLX cmUr1lNoAFW3vWIR6Ju6NmnMFVQlilVHADUJd9/Hwy6MK77xIUrA6Iyos41ScIK3y026 cbYAaiaMgarYe1E4TgstRbzWse+RFycZstcjBiJwinrr2bYwiHSWcfz1tz0VoDWKMy1B frzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ywIQvVwgag1com6bDxPqmKMeB7A08MtYuevMsyOSOPQ=; b=31xBM6fBnMw0wN5bTImKu7Y1b+gYAONCaZzoBvh2f0puxSAbNnARtm6RckCUOH/hki j1pz6LIkI9iHrwk1RygWMaJ1VNLl/cd22WGcon2aSjdYO/RAn8XEtrTJ59+OEfQWV7gT bThaeecriFQkS+DF5vQ4J8vRRZF2ecE92zpaY8gPHCEVrOj5RfjzqxRSdVqiicCN0+Jm rVB4IOTEsgpKmkjJPA7XpDwDKIewTmJG0Ua0Q3PBFw3PoiaGzktI+T7iC8raOH8S7PtH QUNnTmoYtKFBN9GCp/pKi1do2MTYbIRGin+mhiahR2DcQfOZOSyhrY6CFx5H8DYj2PHw 3XpA== X-Gm-Message-State: AOAM533uw+cnengI2NoOz2iBkRC+IMoPPsb6XQTUii69qUg7XZlubGDX rW+WKvwW1YKaU+F/rMn0B6ARyQ== X-Received: by 2002:ad4:5f05:0:b0:456:306d:333d with SMTP id fo5-20020ad45f05000000b00456306d333dmr18665310qvb.16.1651166902753; Thu, 28 Apr 2022 10:28:22 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:d588]) by smtp.gmail.com with ESMTPSA id 15-20020ac8594f000000b002f200ea2518sm327527qtz.59.2022.04.28.10.28.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Apr 2022 10:28:22 -0700 (PDT) Date: Thu, 28 Apr 2022 13:27:46 -0400 From: Johannes Weiner To: Minchan Kim Cc: Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Seth Jennings , Dan Streetman , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 4/5] mm: zswap: add basic meminfo and vmstat coverage Message-ID: References: <20220427160016.144237-1-hannes@cmpxchg.org> <20220427160016.144237-5-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 28, 2022 at 10:02:46AM -0700, Minchan Kim wrote: > On Thu, Apr 28, 2022 at 10:05:13AM -0400, Johannes Weiner wrote: > > But I'd ack a patch that adds a combined "Compressed" counter for zram > > + zswap if you send it, Minchan. > > If we really want to go separate stat for zswap and zram, it would > be better to use direct name "Zram: " instead of comrpessed. That works for me as well.