Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Guenter Roeck <linux@roeck-us.net>
CC:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Yu Zhao <yuzhao@google.com>
Subject: Re: [PATCH v8 23/70] mm/mmap: change do_brk_flags() to expand
 existing VMA and add do_brk_munmap()
Thread-Topic: [PATCH v8 23/70] mm/mmap: change do_brk_flags() to expand
 existing VMA and add do_brk_munmap()
Thread-Index: AQHYWX84+45146fpu0iPsmgBhR+6Va0FgcaAgAAHGAA=
Date:   Thu, 28 Apr 2022 16:35:21 +0000
Message-ID: <20220428163512.kmx3yvghn3txpjee@revolver>
References: <20220426150616.3937571-1-Liam.Howlett@oracle.com>
 <20220426150616.3937571-24-Liam.Howlett@oracle.com>
 <20220428160949.GA2923383@roeck-us.net>
In-Reply-To: <20220428160949.GA2923383@roeck-us.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xuzeY3VIHjKu2M9fuVVtrUBu6I+aahlggt/IHvA/TzxARNt5YobbYdsLPKsP?=
 =?us-ascii?Q?/heStdCztKPP2HGOsuU/JFS3H+Uqkir7aHUf1PnBPppD0mG//rOTyTzC7CaK?=
 =?us-ascii?Q?cZypKZW1v8sggIgzoZhqdqAT/A5WXrIdaYTPvZ0wvvKWqJ/E374DEifP2YMn?=
 =?us-ascii?Q?7hcMvAxdcOT0zGD5uN2u5CAaxt2wUHDePrKXjXQV7nOcjpzxL5BHm6gSxTv3?=
 =?us-ascii?Q?8Ffj8ZkidGiV5YUMLKbDrVlv1GK6OZJxwEMgHGr6IOegicNVuGN5+cGFaEoq?=
 =?us-ascii?Q?ahseDEmQuRfLBUboEu2dz7sgIJAzOOxSjMMjMAboVlFGOGlCj1lNFRv2SsAN?=
 =?us-ascii?Q?i+TR7QPAyCefOZJ6D+w+cbeHPf5ATlICLHUPbhJcis/jDZCb4xktE/BEo0Iy?=
 =?us-ascii?Q?QXqEeGLJEk7UCDPuTuC2GPbv7hHQhoy7iZRRLLA3EPu9c35ANsnz25RFpzmR?=
 =?us-ascii?Q?KTawa8wYA7eiF8Wa1jacAuExvRt5y3v+cBGj/OAfk7K4LsmBaDuByMOP4pZL?=
 =?us-ascii?Q?XwY9l6qc4psRiKeyZp/CLzMOWQUBDfjO5oCO64S2tlvqUzWAbOzMLrDwUFf0?=
 =?us-ascii?Q?8ImwtY3ZgZGKkr73Hb4EOGJYtNwyDUuaDi0w3hH195gL0srLjC4a2JQ9ghVb?=
 =?us-ascii?Q?6UMd9rULGVoBBUsnd1uWhfGqv+cEDoc6X6TuzUHRpR2FI67lGnFDDbpTP3Ek?=
 =?us-ascii?Q?PySNATvHD1sslJDlkMoAeGxUYZ1RMSsEEOqK0ajlm2UO4ag/I75vEkRdG+Xs?=
 =?us-ascii?Q?SzCkY0qz0/n0xCNdLTrNzn0q54aJVR/dEwGCeyQfee2d+n/slQSS1pmWShQY?=
 =?us-ascii?Q?yrmG2arTfwnT80bNTMGbHqFWLARWUd4VhKL1RRxiGW33f/oljNpeQwE5R9W6?=
 =?us-ascii?Q?7Pmqiq6F7VJy6A5cYvEMNTqlDcHuXrszLjJoO3WF3S+ybHovK8hnvNDkW3g0?=
 =?us-ascii?Q?g8LD5A7J3h2VpkaUA4dwruojAlVjPfKX/pCu8c2IItuGyxKHOsuJinXgA2NY?=
 =?us-ascii?Q?GBLwWa25VxZ3APhqQRGzHg+EY1NrmVD9BllkLLDOIv112Ugm26XLyZZlXafm?=
 =?us-ascii?Q?BEIc8IuPngKdlQBGAp6667nrAatJMNm3jAb0c0CXWk6cZzY+gaMUKZQZrGGF?=
 =?us-ascii?Q?60UgY70yNXtZViyHJ7M3Aq+F7hKOV8Qv1vT1T/SpFbvmyy4lSzut2mnJmdvR?=
 =?us-ascii?Q?KXoRLrX8hBACObitLu41W4tgvonMgx9JOLwh0Oq4PDi/v/SRHWz/9x7kSoJl?=
 =?us-ascii?Q?vnO5GRWF+Fopx1vrUit25iQRrOmu1DFQmZfdFnCLEPk5DJJUuPatLmPQPjQU?=
 =?us-ascii?Q?a9C7BZKJzDAYe6oi3Gzi77/4IL1rH4luZnutK2/uxcJOTeK34m3CkaKeAR/4?=
 =?us-ascii?Q?p03bWx56IDuOycIfhVwvJYhKT0j5M4cy7YYhnYyDVTv8nrVUxvlR3aBZJ/HS?=
 =?us-ascii?Q?1PtxMOOAxHd7jqApEUtNlWUSli0wr/ePQqA7xu4L7AOYfNDmU1hpaxY6ydYk?=
 =?us-ascii?Q?7c3bx3mvUB1QcljtW/UBY2oaWlZPPwHmtytlOSZPtwkWoCsQ71s6zPC7WKk5?=
 =?us-ascii?Q?24ehlmqYkUB8lOk/qcHpGGM6GFXud3Jt/J+XL7D6EH1wUjX8xgxcQDA7w9G+?=
 =?us-ascii?Q?UtmAVt+mGlxxrj1v7SUG5lX+MqBWrNaxfstSLBXtQ3TmlX97C8yniuaBHzP6?=
 =?us-ascii?Q?uRNQ4DF51ovIVM1chJFVxA+F/qFJ4KiERAjJGRneV3lx8/03hRS0A3ddSPE5?=
 =?us-ascii?Q?2vaiBDEgfYLPEIST69+sf4svmUZU4Xk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <61A02ECC22E3DB449913CDB5C13BB35D@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 75bc4e68-4f37-472e-2b82-08da293516ad
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2022 16:35:21.6643
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: E510naZa1rMmzNXoIZH1nzD8ujgkarKuEiXF2YayhUl88AsoAtFBHqvP8Iu2gJmxmnEpKfzCEorDjk5OWVOODg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB5920
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-28_02:2022-04-28,2022-04-28 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999
 malwarescore=0 mlxscore=0 phishscore=0 bulkscore=0 adultscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204280099
X-Proofpoint-ORIG-GUID: ZVjJCyEzB0LPCxVt6yVAcwPrE4zSZkLj
X-Proofpoint-GUID: ZVjJCyEzB0LPCxVt6yVAcwPrE4zSZkLj
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Guenter Roeck <linux@roeck-us.net> [220428 12:10]:
> On Tue, Apr 26, 2022 at 03:06:35PM +0000, Liam Howlett wrote:
> > From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
> >=20
> > Avoid allocating a new VMA when it a vma modification can occur.  When =
a
> > brk() can expand or contract a VMA, then the single store operation wil=
l
> > only modify one index of the maple tree instead of causing a node to sp=
lit
> > or coalesce.  This avoids unnecessary allocations/frees of maple tree
> > nodes and VMAs.
> >=20
> > Move some limit & flag verifications out of the do_brk_flags() function=
 to
> > use only relevant checks in the code path of bkr() and vm_brk_flags().
> >=20
> > Set the vma to check if it can expand in vm_brk_flags() if extra criter=
ia
> > are met.
> >=20
> > Drop userfaultfd from do_brk_flags() path and only use it in
> > vm_brk_flags() path since that is the only place a munmap will happen.
> >=20
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
>=20
> This patch results in boot failures on alpha. Trying to revert it results
> in conflicts, so I was unable to cross-check. Bisect log attached. The fa=
ilure
> is silent - boot simply stalls after "random: crng init done", so attachi=
ng
> a boot log doesn't add value.

Thanks.  I can only find Gentoo iso for testing, is there any other
options?

>=20
> Guenter
>=20
> ---
> # bad: [bdc61aad77faf67187525028f1f355eff3849f22] Add linux-next specific=
 files for 20220428
> # good: [af2d861d4cd2a4da5137f795ee3509e6f944a25b] Linux 5.18-rc4
> git bisect start 'HEAD' 'v5.18-rc4'
> # good: [a6ffa4aa7e81a54632f3370f4c93fce603160192] Merge branch 'master' =
of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
> git bisect good a6ffa4aa7e81a54632f3370f4c93fce603160192
> # good: [cd63f17e3bb63006f9f88bf7f5947b8e1601bcd9] Merge branch 'edac-for=
-next' of git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git
> git bisect good cd63f17e3bb63006f9f88bf7f5947b8e1601bcd9
> # good: [cee7bbed3e5cc089b5c364ac8ad4a186c2a28bb6] Merge branch 'next' of=
 git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git
> git bisect good cee7bbed3e5cc089b5c364ac8ad4a186c2a28bb6
> # good: [d5a23156ea99f10b584221893a6a7d6f6554cde8] Merge branch 'for-next=
' of git://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git
> git bisect good d5a23156ea99f10b584221893a6a7d6f6554cde8
> # good: [2f1fde90d983bc404503100c9c4bbbf1e191bcf4] selftests: cgroup: fix=
 alloc_anon_noexit() instantly freeing memory
> git bisect good 2f1fde90d983bc404503100c9c4bbbf1e191bcf4
> # good: [fca1db6ff251278c532231552e840c7dc36dfa76] Merge branch 'bitmap-f=
or-next' of https://github.com/norov/linux.git
> git bisect good fca1db6ff251278c532231552e840c7dc36dfa76
> # bad: [40b39116fe8e6fb66e3166ea40138eec506dfd91] perf: use VMA iterator
> git bisect bad 40b39116fe8e6fb66e3166ea40138eec506dfd91
> # good: [3f2187cf9b93a58343dd01273afdab9df04b0ca3] proc: remove VMA rbtre=
e use from nommu
> git bisect good 3f2187cf9b93a58343dd01273afdab9df04b0ca3
> # bad: [7dbf1873ad5953d8cf732d5fd5a94c1b95c022b0] parisc: remove mmap lin=
ked list from cache handling
> git bisect bad 7dbf1873ad5953d8cf732d5fd5a94c1b95c022b0
> # bad: [c6e0b59766907a73be6cb77683f3ba60d0115495] mm/mmap: use advanced m=
aple tree API for mmap_region()
> git bisect bad c6e0b59766907a73be6cb77683f3ba60d0115495
> # good: [f461d9862fdab8e6aea51094e7286f3ec1b25402] mm: optimize find_exac=
t_vma() to use vma_lookup()
> git bisect good f461d9862fdab8e6aea51094e7286f3ec1b25402
> # bad: [c19a5ccbcbc6fe2c422fd85b22b40abed96c6f6b] mm/mmap: change do_brk_=
flags() to expand existing VMA and add do_brk_munmap()
> git bisect bad c19a5ccbcbc6fe2c422fd85b22b40abed96c6f6b
> # good: [993adc76c4d7afb40133be90333b5303b02115b6] mm/khugepaged: optimiz=
e collapse_pte_mapped_thp() by using vma_lookup()
> git bisect good 993adc76c4d7afb40133be90333b5303b02115b6
> # first bad commit: [c19a5ccbcbc6fe2c422fd85b22b40abed96c6f6b] mm/mmap: c=
hange do_brk_flags() to expand existing VMA and add do_brk_munmap()
> =