Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1388352iob; Fri, 29 Apr 2022 04:31:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyW0gMCqpszIMBW8qiBENGQLe8cDZ9OzopPab2cw9lYC6b7LHDmFoESOmCgY7GpPyhcuqAI X-Received: by 2002:a05:651c:311:b0:246:1250:d6f with SMTP id a17-20020a05651c031100b0024612500d6fmr23448349ljp.455.1651231886116; Fri, 29 Apr 2022 04:31:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651231886; cv=none; d=google.com; s=arc-20160816; b=YIafxZlxSKDRa+31/61WuqMJTlqkBGT0cwrVbb2tOdnsLSTerKzIC1ArJqgDAv0f0p oo+Ubm86EjEc1ROgYxGq+nJnzKNBYVF62zn4K861ya+eiiHkxomR/KEEmgOQYT0zSBzy 59jyiYaxbSVLJCi0LTRLYVHKo60vE5yIA3sOiQTncGoMK+b9sVO2nGmME5yKiCyJ73+4 gX2/mXw2+4xY2FuAqluykJfo2HjjXabrOAih2+0gNaUXcexSmdX/tMSkugByYGYMGVp3 0PHgxnzFVYyVq5/SnEKkw7mfbJUcjMm4EFOzyNx8yHsHN+rb8Yfd2No5ycCNQuzTgiqs QqHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=6XrbVTuaegQwAcERTwpElpvx4fzNLu9i3rDPIddfV0M=; b=d4tq+2w9erHwq/0vfdBBqrgiVio8UyBj8vkvrXjRP2gWbfcz9dDlNUY/00yzldTTGh i6yv4eB/+E2G64uYBI1vQs0U7dSEGN9HfYobN2WmyVf3IqwBPwPc1UpX00t7znAilDKo /FV9wZ4R+4Y3E14ZceSlFGVOr5ct2MnmLqhuKWoL/F8cESP0KvLHukkDTWdbOs4rmXuP /hpprU+mhQDextSol/8JxFnJS+B3dgvzWInWk6IdibXIM3RpGLvup+CY9MjdcQzgW1LM aelOZvtwUEUXV+1xwli5Jxrmn95RVKzxAFzaeVuS0gZqBQWRvnYJCa/ABhhAGJBUMjkL 7OqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u7-20020a196007000000b0046d77b21b0bsi6454407lfb.386.2022.04.29.04.30.57; Fri, 29 Apr 2022 04:31:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236912AbiD2EHa (ORCPT + 99 others); Fri, 29 Apr 2022 00:07:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230133AbiD2EH3 (ORCPT ); Fri, 29 Apr 2022 00:07:29 -0400 Received: from nksmu.kylinos.cn (mailgw.kylinos.cn [123.150.8.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5B3DB9F3F for ; Thu, 28 Apr 2022 21:04:08 -0700 (PDT) X-UUID: d2eb80d31af748789493127fc21f493c-20220429 X-UUID: d2eb80d31af748789493127fc21f493c-20220429 Received: from cs2c.com.cn [(172.17.111.24)] by nksmu.kylinos.cn (envelope-from ) (Generic MTA) with ESMTP id 2146502266; Fri, 29 Apr 2022 12:02:33 +0800 X-ns-mid: postfix-626B63B4-5096043818 Received: from localhost.localdomain (unknown [172.20.108.41]) by cs2c.com.cn (NSMail) with ESMTPA id 40EBE3844000; Fri, 29 Apr 2022 04:04:04 +0000 (UTC) From: Zhenneng Li To: David Airlie , Daniel Vetter Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Zhenneng Li Subject: [PATCH] drm/i915: remove unnecessary spin_lock_irq Date: Fri, 29 Apr 2022 12:03:55 +0800 Message-Id: <20220429040355.2644322-1-lizhenneng@kylinos.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KHOP_HELO_FCRDNS, SPF_HELO_NONE,T_SPF_PERMERROR,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This code will not be called by interrupt handler, so change it to spin_lock. Signed-off-by: Zhenneng Li --- drivers/gpu/drm/i915/i915_scheduler.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_scheduler.c b/drivers/gpu/drm/i915/i915_scheduler.c index 762127dd56c5..6615102a1568 100644 --- a/drivers/gpu/drm/i915/i915_scheduler.c +++ b/drivers/gpu/drm/i915/i915_scheduler.c @@ -288,9 +288,9 @@ static void __i915_schedule(struct i915_sched_node *node, void i915_schedule(struct i915_request *rq, const struct i915_sched_attr *attr) { - spin_lock_irq(&schedule_lock); + spin_lock(&schedule_lock); __i915_schedule(&rq->sched, attr); - spin_unlock_irq(&schedule_lock); + spin_unlock(&schedule_lock); } void i915_sched_node_init(struct i915_sched_node *node) -- 2.25.1