Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220428014022.v1.1.I08a15a73996211d37dff16810c40ee1539658601@changeid>
In-Reply-To: <20220428014022.v1.1.I08a15a73996211d37dff16810c40ee1539658601@changeid>
From:   Doug Anderson <dianders@chromium.org>
Date:   Thu, 28 Apr 2022 08:37:44 -0700
Message-ID: <CAD=FV=W716PePPFRJ+tjyKWg5CGtC7qz1+amVpq=iVk7neqkqg@mail.gmail.com>
Subject: Re: [PATCH v1] arm64: dts: qcom: sc7180: Add mrbland dts files
To:     "Joseph S. Barrera III" <joebar@chromium.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Alexandru M Stan <amstan@chromium.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Thu, Apr 28, 2022 at 1:41 AM Joseph S. Barrera III
<joebar@chromium.org> wrote:
>
> +&i2c4 {
> +       status = "okay";
> +       clock-frequency = <400000>;
> +
> +       ap_ts: touchscreen@5d {
> +               compatible = "goodix,gt7375p";
> +               reg = <0x5d>;
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&ts_int_l>, <&ts_reset_l>;
> +
> +               interrupt-parent = <&tlmm>;
> +               interrupts = <9 IRQ_TYPE_LEVEL_LOW>;
> +
> +               reset-gpios = <&tlmm 8 GPIO_ACTIVE_LOW>;
> +
> +               vdd-supply = <&pp3300_ts>;
> +       };
> +};

This is a detachable, right? So can you add these to match what
Stephen is doing for existing detachables [1]

&keyboard_controller {
       /delete-property/keypad,num-rows;
       /delete-property/keypad,num-columns;
};

It should be sorted based on the name of the node you're overriding,
so it should come right after &i2c4 I believe.


> +tp_en: &en_pp3300_dx_edp {
> +       pinmux {
> +               pins = "gpio85";
> +               };
> +       pinconf {
> +               pins = "gpio85";
> +       };
> +};

The above has the exact same problem that Stephen asked you to fix on
wormdingler [2] about indentation / blank lines. Can you fix it here
too?

In addition to the changes requested above, it's probably nicer to
keep all 3 patches you're sending in one series just because they all
touch the Makefile.

[1] https://lore.kernel.org/r/20220426225748.324759-1-swboyd@chromium.org
[2] https://lore.kernel.org/r/CAE-0n53juQ8--Sai=wKypj8URw+V1giOOhzd-p13fVbe_vxZ0Q@mail.gmail.com/