Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 28 Apr 2022 17:19:49 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Cai Huoqing <cai.huoqing@linux.dev>
Cc:     Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org,
        Christian =?utf-8?B?S8O2bmln?= <christian.koenig@amd.com>,
        linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org,
        Sumit Semwal <sumit.semwal@linaro.org>,
        linux-media@vger.kernel.org
Subject: Re: [PATCH v2 2/4] drm/nvdla: Add driver support for NVDLA
Message-ID: <YmqwlbLcFgTDUpkX@orome>
References: <20220426060808.78225-1-cai.huoqing@linux.dev>
 <20220426060808.78225-3-cai.huoqing@linux.dev>
 <YmqwNVoTZZFaIM9S@orome>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="xJwzd/BOTwcSuCe5"
Content-Disposition: inline
In-Reply-To: <YmqwNVoTZZFaIM9S@orome>
User-Agent: Mutt/2.2.1 (c8109e14) (2022-02-19)
Precedence: bulk


--xJwzd/BOTwcSuCe5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 28, 2022 at 05:18:13PM +0200, Thierry Reding wrote:
> On Tue, Apr 26, 2022 at 02:07:59PM +0800, Cai Huoqing wrote:
> [...]
> > diff --git a/drivers/gpu/drm/nvdla/nvdla_drv.c b/drivers/gpu/drm/nvdla/=
nvdla_drv.c
>=20
> I'll look at this from an architectural level and leave it to other
> experts to review the more technical things.
>=20
> [...]
> > +static struct nvdla_config nvdla_config_os_initial =3D {
> > +	.atom_size =3D 32,
> > +	.bdma_enable =3D true,
> > +	.rubik_enable =3D true,
> > +	.weight_compress_support =3D true,
> > +};
> > +
> > +static struct nvdla_config nvdla_config_small =3D {
> > +	//.atom_size =3D 8,
> > +	.atom_size =3D 32,  // nv_large config
> > +	.bdma_enable =3D false,
> > +	.rubik_enable =3D false,
> > +	.weight_compress_support =3D false,
> > +};
> > +
> [...]
> > +static union nvdla_operation_container operation_desc[NVDLA_OP_NUM][NV=
DLA_NUM_GROUPS];
> > +static union nvdla_surface_container surface_desc[NVDLA_OP_NUM][NVDLA_=
NUM_GROUPS];
> > +
> > +static struct nvdla_task_desc global_task;
> > +
> > +static struct nvdla_engine engine =3D {
> > +	.processors[NVDLA_OP_BDMA] =3D {
> > +		.name =3D "BDMA",
> > +		.op_type =3D NVDLA_OP_BDMA,
> > +		.program =3D nvdla_bdma_program,
> > +		.enable =3D nvdla_bdma_enable,
> > +		.set_producer =3D nvdla_bdma_set_producer,
> > +		.is_ready =3D nvdla_bdma_is_ready,
> > +		.dump_config =3D nvdla_bdma_dump_config,
> > +		.rdma_check =3D nvdla_bdma_rdma_check,
> > +		.consumer_ptr =3D 0,
> > +		.roi_index =3D 0,
> > +		.group_status =3D 0,
> > +		.rdma_status =3D 0,
> > +		.last_group =3D 1,
> > +		.groups[0] =3D {
> > +			.id =3D 0,
> > +			.rdma_id =3D 0,
> > +			.active =3D 0,
> > +			.events =3D 0,
> > +			.roi_index =3D 0,
> > +			.is_rdma_needed =3D 0,
> > +			.lut_index =3D -1,
> > +			.operation_desc =3D &operation_desc[NVDLA_OP_BDMA][0],
> > +			.surface_desc =3D &surface_desc[NVDLA_OP_BDMA][0],
> > +		},
> > +		.groups[1] =3D {
> > +			.id =3D 1,
> > +			.rdma_id =3D 0,
> > +			.active =3D 0,
> > +			.events =3D 0,
> > +			.roi_index =3D 0,
> > +			.is_rdma_needed =3D 0,
> > +			.lut_index =3D -1,
> > +			.operation_desc =3D &operation_desc[NVDLA_OP_BDMA][1],
> > +			.surface_desc =3D &surface_desc[NVDLA_OP_BDMA][1],
> > +		},
> > +	},
> > +	.processors[NVDLA_OP_CONV] =3D {
> > +		.name =3D "Convolution",
> > +		.op_type =3D NVDLA_OP_CONV,
> > +		.program =3D nvdla_conv_program,
> > +		.enable =3D nvdla_conv_enable,
> > +		.set_producer =3D nvdla_conv_set_producer,
> > +		.is_ready =3D nvdla_conv_is_ready,
> > +		.dump_config =3D nvdla_conv_dump_config,
> > +		.rdma_check =3D nvdla_conv_rdma_check,
> > +		.consumer_ptr =3D 0,
> > +		.roi_index =3D 0,
> > +		.group_status =3D 0,
> > +		.rdma_status =3D 0,
> > +		.last_group =3D 1,
> > +		.groups[0] =3D {
> > +			.id =3D 0,
> > +			.rdma_id =3D 0,
> > +			.active =3D 0,
> > +			.events =3D 0,
> > +			.roi_index =3D 0,
> > +			.is_rdma_needed =3D 0,
> > +			.lut_index =3D -1,
> > +			.operation_desc =3D &operation_desc[NVDLA_OP_CONV][0],
> > +			.surface_desc =3D &surface_desc[NVDLA_OP_CONV][0],
> > +		},
> > +		.groups[1] =3D {
> > +			.id =3D 1,
> > +			.rdma_id =3D 0,
> > +			.active =3D 0,
> > +			.events =3D 0,
> > +			.roi_index =3D 0,
> > +			.is_rdma_needed =3D 0,
> > +			.lut_index =3D -1,
> > +			.operation_desc =3D &operation_desc[NVDLA_OP_CONV][1],
> > +			.surface_desc =3D &surface_desc[NVDLA_OP_CONV][1],
> > +		},
> > +	},
> > +	.processors[NVDLA_OP_SDP] =3D {
> > +		.name =3D "SDP",
> > +		.op_type =3D NVDLA_OP_SDP,
> > +		.program =3D nvdla_sdp_program,
> > +		.enable =3D nvdla_sdp_enable,
> > +		.set_producer =3D nvdla_sdp_set_producer,
> > +		.is_ready =3D nvdla_sdp_is_ready,
> > +		.dump_config =3D nvdla_sdp_dump_config,
> > +		.rdma_check =3D nvdla_sdp_rdma_check,
> > +		.consumer_ptr =3D 0,
> > +		.roi_index =3D 0,
> > +		.group_status =3D 0,
> > +		.rdma_status =3D 0,
> > +		.last_group =3D 1,
> > +		.groups[0] =3D {
> > +			.id =3D 0,
> > +			.rdma_id =3D 0,
> > +			.active =3D 0,
> > +			.events =3D 0,
> > +			.roi_index =3D 0,
> > +			.is_rdma_needed =3D 0,
> > +			.lut_index =3D -1,
> > +			.operation_desc =3D &operation_desc[NVDLA_OP_SDP][0],
> > +			.surface_desc =3D &surface_desc[NVDLA_OP_SDP][0],
> > +		},
> > +		.groups[1] =3D {
> > +			.id =3D 1,
> > +			.rdma_id =3D 0,
> > +			.active =3D 0,
> > +			.events =3D 0,
> > +			.roi_index =3D 0,
> > +			.is_rdma_needed =3D 0,
> > +			.lut_index =3D -1,
> > +			.operation_desc =3D &operation_desc[NVDLA_OP_SDP][1],
> > +			.surface_desc =3D &surface_desc[NVDLA_OP_SDP][1],
> > +		},
> > +	},
> > +	.processors[NVDLA_OP_PDP] =3D {
> > +		.name =3D "PDP",
> > +		.op_type =3D NVDLA_OP_PDP,
> > +		.program =3D nvdla_pdp_program,
> > +		.enable =3D nvdla_pdp_enable,
> > +		.set_producer =3D nvdla_pdp_set_producer,
> > +		.is_ready =3D nvdla_pdp_is_ready,
> > +		.dump_config =3D nvdla_pdp_dump_config,
> > +		.rdma_check =3D nvdla_pdp_rdma_check,
> > +		.consumer_ptr =3D 0,
> > +		.roi_index =3D 0,
> > +		.group_status =3D 0,
> > +		.rdma_status =3D 0,
> > +		.last_group =3D 1,
> > +		.groups[0] =3D {
> > +			.id =3D 0,
> > +			.rdma_id =3D 0,
> > +			.active =3D 0,
> > +			.events =3D 0,
> > +			.roi_index =3D 0,
> > +			.is_rdma_needed =3D 0,
> > +			.lut_index =3D -1,
> > +			.operation_desc =3D &operation_desc[NVDLA_OP_PDP][0],
> > +			.surface_desc =3D &surface_desc[NVDLA_OP_PDP][0],
> > +		},
> > +		.groups[1] =3D {
> > +			.id =3D 1,
> > +			.rdma_id =3D 0,
> > +			.active =3D 0,
> > +			.events =3D 0,
> > +			.roi_index =3D 0,
> > +			.is_rdma_needed =3D 0,
> > +			.lut_index =3D -1,
> > +			.operation_desc =3D &operation_desc[NVDLA_OP_PDP][1],
> > +			.surface_desc =3D &surface_desc[NVDLA_OP_PDP][1],
> > +		},
> > +	},
> > +	.processors[NVDLA_OP_CDP] =3D {
> > +		.name =3D "CDP",
> > +		.op_type =3D NVDLA_OP_CDP,
> > +		.program =3D nvdla_cdp_program,
> > +		.enable =3D nvdla_cdp_enable,
> > +		.set_producer =3D nvdla_cdp_set_producer,
> > +		.is_ready =3D nvdla_cdp_is_ready,
> > +		.dump_config =3D nvdla_cdp_dump_config,
> > +		.rdma_check =3D nvdla_cdp_rdma_check,
> > +		.consumer_ptr =3D 0,
> > +		.roi_index =3D 0,
> > +		.group_status =3D 0,
> > +		.rdma_status =3D 0,
> > +		.last_group =3D 1,
> > +		.groups[0] =3D {
> > +			.id =3D 0,
> > +			.rdma_id =3D 0,
> > +			.active =3D 0,
> > +			.events =3D 0,
> > +			.roi_index =3D 0,
> > +			.is_rdma_needed =3D 0,
> > +			.lut_index =3D -1,
> > +			.operation_desc =3D &operation_desc[NVDLA_OP_CDP][0],
> > +			.surface_desc =3D &surface_desc[NVDLA_OP_CDP][0],
> > +		},
> > +		.groups[1] =3D {
> > +			.id =3D 1,
> > +			.rdma_id =3D 0,
> > +			.active =3D 0,
> > +			.events =3D 0,
> > +			.roi_index =3D 0,
> > +			.is_rdma_needed =3D 0,
> > +			.lut_index =3D -1,
> > +			.operation_desc =3D &operation_desc[NVDLA_OP_CDP][1],
> > +			.surface_desc =3D &surface_desc[NVDLA_OP_CDP][1],
> > +		},
> > +	},
> > +
> > +	.processors[NVDLA_OP_RUBIK] =3D {
> > +		.name =3D "RUBIK",
> > +		.op_type =3D NVDLA_OP_RUBIK,
> > +		.program =3D nvdla_rubik_program,
> > +		.enable =3D nvdla_rubik_enable,
> > +		.set_producer =3D nvdla_rubik_set_producer,
> > +		.is_ready =3D nvdla_rubik_is_ready,
> > +		.dump_config =3D nvdla_rubik_dump_config,
> > +		.rdma_check =3D nvdla_rubik_rdma_check,
> > +		.consumer_ptr =3D 0,
> > +		.roi_index =3D 0,
> > +		.group_status =3D 0,
> > +		.rdma_status =3D 0,
> > +		.last_group =3D 1,
> > +		.groups[0] =3D {
> > +			.id =3D 0,
> > +			.rdma_id =3D 0,
> > +			.active =3D 0,
> > +			.events =3D 0,
> > +			.roi_index =3D 0,
> > +			.is_rdma_needed =3D 0,
> > +			.lut_index =3D -1,
> > +			.operation_desc =3D &operation_desc[NVDLA_OP_RUBIK][0],
> > +			.surface_desc =3D &surface_desc[NVDLA_OP_RUBIK][0],
> > +		},
> > +		.groups[1] =3D {
> > +			.id =3D 1,
> > +			.rdma_id =3D 0,
> > +			.active =3D 0,
> > +			.events =3D 0,
> > +			.roi_index =3D 0,
> > +			.is_rdma_needed =3D 0,
> > +			.lut_index =3D -1,
> > +			.operation_desc =3D &operation_desc[NVDLA_OP_RUBIK][1],
> > +			.surface_desc =3D &surface_desc[NVDLA_OP_RUBIK][1],
> > +		},
> > +	},
> > +
> > +};
>=20
> These global variables aren't going to work because Tegra234 (Tegra194's
> successor) has two instances of NVDLA.

Small correction: I just recalled that even Tegra194 has two DLA
instances, so if we want both supported we'll need to get rid of those
global variables for that chip already.

Thierry

--xJwzd/BOTwcSuCe5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmJqsJUACgkQ3SOs138+
s6Gpgg/9H+U035AscZ+rM3Mw++AKhE951GQ8tIbJxV6LwTW1JahCazVsrOZ/fTPL
GHMAq5XhOcoyQuolcfAyMu4F9Rb+5TiVVJTfHq0TuA3rVdYeP8czuiY6Bsch0HHM
ZU4TjTyZL2VMvECeXZfRHWQvU7FCMQ+ms8uKs6cWs5CQNSFF10Ve/FjpistPRv82
VBDJzD2UUfPA7D41OdMuaQy8z0MrTnksI+H3v50AS8PBaenF7yk0BmK5/km88X+b
dXrElDAJ1ntH8HrQyntNq+fBPoWiExdz8gXiM0PWMnW1UZRoFKraLrW3FCzl28Uy
SK5ezIatixWLdpdWfA49LxpBlKPGLoWzHGyQCrTdpFxP8rfRIpuMUtbvFfhYEkNU
N94Pb28CKyG7eWo+pg5Umc3AlWjsg8LtgC44zDYLnXymVicKHzKFs/RP0Mo6Fj6m
z+pAYZtgQnSjLqAeIUVTdrJUYgnpQ00MA3Zl1U2nJjBHZgWGyXj71fBOf4v6Ar/c
o/WoMwSbME87hEtyFzEmQGk95ed2ZlCeNACykyF9ZEPBDv1CprEzZQeDg21tM3Z1
HaZrHL1U0VFJwLnIkyFYp023OwCPQqQoXgHd3zCyOL4gp1boROMmCQYzxHxBGxeH
KJ519K56LvO/S0VRWiASqmAK2kDkfWZ15M/tR0BtDImCz4lDJ7Q=
=KfCd
-----END PGP SIGNATURE-----

--xJwzd/BOTwcSuCe5--