Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Prakash Sangappa <prakash.sangappa@oracle.com>
To:     Thomas Gleixner <tglx@linutronix.de>
CC:     Davidlohr Bueso <dave@stgolabs.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "manfred@colorfullife.com" <manfred@colorfullife.com>
Subject: Re: [PATCH v3] ipc: Update semtimedop() to use hrtimer
Thread-Topic: [PATCH v3] ipc: Update semtimedop() to use hrtimer
Thread-Index: AQHYW0ECZ628czOVi0maPFqsoUiRXq0FzIyAgAAUO4CAAAXtAA==
Date:   Thu, 28 Apr 2022 22:23:40 +0000
Message-ID: <5FEE7AB6-7560-4998-A7A3-B60A4B32E1DE@oracle.com>
References: <1651178767-447-1-git-send-email-prakash.sangappa@oracle.com>
 <20220428205001.hiuzwpn5emxtrh4s@offworld> <87zgk4ooi6.ffs@tglx>
In-Reply-To: <87zgk4ooi6.ffs@tglx>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 2
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bP2y4jZgoLXE3Fo3F45Zi8szx3NrYQgGI6trXhxCjx5BBsl/AXOjRyMLo2ES?=
 =?us-ascii?Q?kqYDHVykNL4F6BfBbIXehvZH1Q5fDAWcLdHXwOpdzQYsoAq7M7JTHh4ixHzQ?=
 =?us-ascii?Q?ks/e2cHkojf5ZIaF73zCkvyUt7T0WP/4kOeoUMyw9Lu/YGtEq83YutSLOl/k?=
 =?us-ascii?Q?ZfkJ2uC5/nV4oDs2NGz2DFtfGmwcrD6yVwJqz2VmAeSQYtQStGXsUk3k0phS?=
 =?us-ascii?Q?chod1BZTqIOtFOFsF8vzX3HjP2ochTT7wvRKhBG7OEpZNv8+TE8GQpdmFOai?=
 =?us-ascii?Q?bp/9PrhOeOaVfmAQSH1k8QcfbTyX4W1WqMaVz+RtjZyepD4O65pFpYwJmG54?=
 =?us-ascii?Q?qq+sJEJZWjD2IwNoulsd1sJ66NUILLHutskAkK+fQtvELdl7p5B/N7eEXun5?=
 =?us-ascii?Q?CkQnSILmFEkPo67SWcx5d2pyiDSGctkfxypiIHaX80xs8YPFvL+/5S3iPdvJ?=
 =?us-ascii?Q?79/wp5klqCiRL1uKRUiIQ4RlEBIMbpuD3pO0R4KE+j+m2D3NjDtqe9n1piUE?=
 =?us-ascii?Q?OmwcH4ITgtmNP1rteWcx/lfSL4z2agoOUPko+oxIvQcIFPvyNoP15H+o1GNs?=
 =?us-ascii?Q?uluRviWofwEw/usqtJawvurfLBJBvJ/S1ZZIRfRfaMIVxkvbU2OjYV4ACz6F?=
 =?us-ascii?Q?8nXP63ef32dFugvlaq5UNO1i5TW+JGFi/8PKlq11pochjdpErlW0fsfWzsEF?=
 =?us-ascii?Q?Vcgn1zIjXmhg0aDB674E4ehB7urzsFopWWULVNyQmBGU4XCdVONPie2zNccR?=
 =?us-ascii?Q?g2jB6XSBIDQ5batqnjK1ohQC+hHeHdGDi/DJYC3EulB5+PdbmpVPXLYB9xiL?=
 =?us-ascii?Q?SrLAo8PS9V6d+bxNQ3BRPfWSiil5vXv/Pfr/2U/FgS0aNgjR+4UMXbAvs9Mg?=
 =?us-ascii?Q?Xiu0cMgjn0ogbT3gHm+eL2otnZwMbCiSRR2wSE7m8EB18HKTjw8E6FwDAyDs?=
 =?us-ascii?Q?ox0TkeBXCE0R4NTQoI+PocGcrCtKUIEBvBI1JN8XbdPJyY6IsVb+rrBVuCKn?=
 =?us-ascii?Q?UqrkkAuIV0hCCY2a5bDPL3R42gopkYHpXuedpb2P2ORpypXST6G3QOJE6iqx?=
 =?us-ascii?Q?8vPcef284C+SHf0rTL31f6h40qirPRsQqDlHwn3wwW9f5XEmJb/NMxVpKOif?=
 =?us-ascii?Q?glCwQUANeOJx0EvbSTBiXcMrHo5CyYBRM6eF47f5pZhXKC0xWFqk4PHPcsbR?=
 =?us-ascii?Q?GPo9xYD3vVPJWCppjnpsE08b6Gu7Xbb22iMoZFn+eM1Gdnat+rpCpfVqaCUy?=
 =?us-ascii?Q?H230v8eQhK4fauTcHzgxTLfBNms2Qzwr6yauRMlLOCAqYVlm0NSTgJFTrJ8q?=
 =?us-ascii?Q?xBwX/IffeprcwhLFa6K0C+Tgu4MaKflTNR/V2QReR5zWsMsFZREdWSAJFlmf?=
 =?us-ascii?Q?1QfDJWd2a7LrA2+aLWhsC/nYvYrs6Vqr5uHCHNtP6k5Ko7x2M9JUDnNOO+U5?=
 =?us-ascii?Q?CY7diWiOkpYJO1Jz64hQ0DptBJNzRLGZfEyUOUUqX8pit0jG8Aq5Ib5OWlBd?=
 =?us-ascii?Q?ze9hOYB3XCF8ItskVCBYbv/Q7eQC7EdpuIUFKNK+nUIOGLh8t8uRGadPaNw/?=
 =?us-ascii?Q?Rh40V8SRHD2ICHRrr4ObB3S8PzbneYVajlU8jd0Mk7x4tQH56zoKAYsJVJnr?=
 =?us-ascii?Q?C7fgis/3PjMTnGmDufucN8BB63o3ZYaNQJFMF91LegxJpwAzFJPc8395bioQ?=
 =?us-ascii?Q?UJswr0v6Guz9ogiLULdOYRel26gyTJXeMQHS+nvo/ulpurnXPiFpV7RAxMCw?=
 =?us-ascii?Q?4fShktG6L04Vjotf996Kvr7C/fm0aQvyTNcDdzOo9k7wyscNEruo35lozI8p?=
x-ms-exchange-antispam-messagedata-1: 9qrsGbq5O1ME4g==
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0F6904B476043748B4087A1EE053353B@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2629.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 130092b6-0b29-4bd4-52da-08da2965bf19
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2022 22:23:40.0265
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Gs+YaAZul4szpHvtg17eO3IfUIzbSWp/dfkPSvrbgFLMjeiQD2SMj1iJuJPx4OxzQNhtZXYMXioV/1UINL3ATyzC94iDevBaRYFEq7qqcQI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3020
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-28_05:2022-04-28,2022-04-28 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=848 mlxscore=0
 suspectscore=0 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204280129
X-Proofpoint-ORIG-GUID: YHih4_4Utf-NZocrL3SwIDw69nwOtP2B
X-Proofpoint-GUID: YHih4_4Utf-NZocrL3SwIDw69nwOtP2B
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Apr 28, 2022, at 3:02 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
>=20
> On Thu, Apr 28 2022 at 13:50, Davidlohr Bueso wrote:
>> On Thu, 28 Apr 2022, Prakash Sangappa wrote:
>>> -		if (timeout)
>>> -			jiffies_left =3D schedule_timeout(jiffies_left);
>>> -		else
>>> -			schedule();
>>> +		timed_out =3D !schedule_hrtimeout_range(exp,
>>> +				current->timer_slack_ns, HRTIMER_MODE_ABS);
>>=20
>> I'm wondering if the slack parameter instead of passing the timer_slack_=
ns
>> value immediately, we should do a rt_task() check and pass zero if so.
>=20
> We should have a wrapper function which takes care of that instead of
> having checks all over the place.

Ok  it can be an inline function in sched.h which returns appropriate=20
slack time. Use that in  futex_wait() and sigtimedwait() also in addition t=
o=20
semtimedop() & mqueue codepath?

Should that be a separate patch?

Thanks,
-Prakash

>=20
> Thanks,
>=20
>        tglx