Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755936AbXEIJwB (ORCPT ); Wed, 9 May 2007 05:52:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754894AbXEIJvv (ORCPT ); Wed, 9 May 2007 05:51:51 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:57422 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754783AbXEIJvu (ORCPT ); Wed, 9 May 2007 05:51:50 -0400 Date: Wed, 9 May 2007 02:53:02 -0700 From: Greg KH To: Cornelia Huck Cc: Linus Torvalds , Adrian Bunk , linux-kernel Subject: Re: Please revert 5adc55da4a7758021bcc374904b0f8b076508a11 (PCI_MULTITHREAD_PROBE) Message-ID: <20070509095302.GA13053@kroah.com> References: <20070508153713.344cc881@gondolin.boeblingen.de.ibm.com> <20070508141149.GJ4226@stusta.de> <20070508183846.28a94797@gondolin.boeblingen.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070508183846.28a94797@gondolin.boeblingen.de.ibm.com> User-Agent: Mutt/1.5.15 (2007-04-06) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1365 Lines: 37 On Tue, May 08, 2007 at 06:38:46PM +0200, Cornelia Huck wrote: > On Tue, 8 May 2007 08:27:34 -0700 (PDT), > Linus Torvalds wrote: > > > And no, we should not do it at the device core level. In fact, I don't > > think we should do it at that level at all. > > > > I'm pretty sure that the performance problems are at individual device > > drivers, and that the right solution is to thread at *that* level. Not > > higher up. > > These are two different problems: > > 1. Probing taking long for individual device drivers. I agree, this > should be solved at the driver level. For your bus perhaps, but not for PCI. > 2. Sheer volume of devices on a bus. Even if the indivdual probing > doesn't take long, having all devices probed one after the other may > take a lot of time. Putting the actual probe on a thread makes it > possible to run several probes in parallel, thereby cutting probing > time. Again, not for PCI, right? If you want to implement this for your bus type, fine, I have no objection to that at all, but not for PCI, it's just not worth it. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/