Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a2d1bd9f-2bb4-bea9-f59a-08d91db5572a@quicinc.com>
Date:   Thu, 28 Apr 2022 10:00:43 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCHv12 8/9] serial: qcom_geni_serial: Disable MMIO tracing for
 geni serial
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     Sai Prakash Ranjan <quic_saipraka@quicinc.com>, <arnd@arndb.de>,
        <catalin.marinas@arm.com>, <rostedt@goodmis.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <maz@kernel.org>, <quic_psodagud@quicinc.com>, <will@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>
References: <cover.1651139070.git.quic_saipraka@quicinc.com>
 <3fef68a94e4947d58a199709929d30e0e2bf2e44.1651139070.git.quic_saipraka@quicinc.com>
 <Ympxa0ZY0VxZGEjA@kroah.com>
 <e11455d8-78c2-68e8-215e-a4e3587f3e4a@quicinc.com>
 <YmrFlce26p2uvtDZ@kroah.com>
From:   Trilok Soni <quic_tsoni@quicinc.com>
In-Reply-To: <YmrFlce26p2uvtDZ@kroah.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/28/2022 9:49 AM, Greg KH wrote:
> On Thu, Apr 28, 2022 at 09:31:43AM -0700, Trilok Soni wrote:
>> On 4/28/2022 3:50 AM, Greg KH wrote:
>>> On Thu, Apr 28, 2022 at 03:25:31PM +0530, Sai Prakash Ranjan wrote:
>>>> Disable MMIO tracing for geni serial driver as it is a high
>>>> frequency operation for serial driver with many register reads/
>>>> writes and not very useful to log all MMIO traces and prevent
>>>> excessive logging.
>>>>
>>>> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
>>>> Signed-off-by: Sai Prakash Ranjan <quic_saipraka@quicinc.com>
>>>> ---
>>>>    drivers/tty/serial/qcom_geni_serial.c | 8 +++++++-
>>>>    1 file changed, 7 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
>>>> index 1543a6028856..5b48e6c2bf3c 100644
>>>> --- a/drivers/tty/serial/qcom_geni_serial.c
>>>> +++ b/drivers/tty/serial/qcom_geni_serial.c
>>>> @@ -1,5 +1,11 @@
>>>>    // SPDX-License-Identifier: GPL-2.0
>>>> -// Copyright (c) 2017-2018, The Linux foundation. All rights reserved.
>>>> +/*
>>>> + * Copyright (c) 2017-2018, The Linux Foundation. All rights reserved.
>>>> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
>>>> + */
>>>
>>> I strongly disagree that adding a single line here warrants a copyright
>>> update.  If your lawyers will sign off on this change, I am willing to
>>> reconsider.
>>
>> I am not a lawyer, we can skip adding QuIC copyright here since it is just
>> one line change, but at the same time we can't add 2022 year in the existing
>> copyright.
> 
> That is correct, because you are not making a copyrightable change,
> otherwise the single line addition would be ok.
> 
> Talk to your lawyers about this :)
> 
>> If that is fine, we can skip the copyright year update entirely.
> 
> Please do.
> 

Sai, please go ahead and remove QuIC copyright line here.

---Trilok Soni