Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b279040a-a782-a2ca-2acb-2d8f07709081@linaro.org>
Date:   Fri, 29 Apr 2022 08:46:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 1/2] dt-bindings: mtd: partitions: Add binding for
 Sercomm parser
Content-Language: en-US
To:     Mikhail Zhilkin <csharper2005@gmail.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc:     NOGUCHI Hiroshi <drvlabo@gmail.com>, Karim <Karimdplay@gmail.com>,
        M <x1@disroot.org>, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
References: <20220406195557.1956-1-csharper2005@gmail.com>
 <20220406195946.2019-1-csharper2005@gmail.com>
 <8d0d8b27-35ff-3693-cf80-897b80c26b4e@linaro.org>
 <57bebf2f-af4c-b2d9-10e5-19e5104946fb@gmail.com>
 <29cfa017-bbaf-3aba-fe1d-06771957dbaa@linaro.org>
 <1b391399-984b-7a63-3265-62ef09caec39@gmail.com>
 <bd533827-b575-caad-c230-af060851b231@gmail.com>
 <db70e53b-7484-43bf-e9c8-b6a2dce1fbb5@linaro.org>
 <25da3f43-c46e-8108-2da9-0e4f2b7cc1a4@gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <25da3f43-c46e-8108-2da9-0e4f2b7cc1a4@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 28/04/2022 17:24, Mikhail Zhilkin wrote:
> 
> Hi, Krzysztof,
> 
> On 4/10/2022 11:18 AM, Krzysztof Kozlowski wrote:
>> I am sorry, but you changed now a lot in the bindings and it looks
>> entirely different. Things previously being correct now are wrong, so
>> rather start from your old bindings...
> 
> 
> Looks like I'm a bit confused... I use dual "compatible" in my real dts
> and I realized that:
> 
> 1. Therefore I have to use  dual "compatible" in example too:
> 
> compatible = "sercomm,sc-partitions", "fixed-partitions";
> 
> 2. When I'm trying to reuse "fixed-partitions" compatible from
> fixed-partitions.yaml in my new .yaml I get "too long" errors.

Yes, the fixed-partitions.yaml would have to be changed to allow extension.

> 
> Real dts:
> 
> Link:
> https://github.com/openwrt/openwrt/blob/edcc1a9a734bb3fcdc9242025290d3f173e71b78/target/linux/ramips/dts/mt7621_beeline_smartbox-giga.dts#L79
> 
> So, I currently found another solution - to extend fixed-partitions.yaml
> with "sercomm,sc-partitions". Is It ok from your side? Can I use this
> code in v3?

Not really, I don't understand why do you need it and it does not
include our previous talks.

> 
> diff --git
> a/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml
> b/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml
> index ea4cace6a955..9eebe39a57fb 100644
> --- a/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml
> +++ b/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml
> @@ -19,7 +19,11 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: fixed-partitions
> +    oneOf:
> +      - const: fixed-partitions
> +      - items:
> +          - const: sercomm,sc-partitions
> +          - const: fixed-partitions
>  
>    "#address-cells": true
>  
> @@ -27,7 +31,18 @@ properties:
>  
>  patternProperties:
>    "@[0-9a-f]+$":
> -    $ref: "partition.yaml#"
> +    allOf:
> +      - $ref: "partition.yaml#"
> +      - if:
> +          properties:
> +            compatible:
> +              contains:
> +                const: sercomm,sc-partitions
> +        then:
> +          properties:
> +            scpart-id:

It still misses vendor prefix and we agreed you don't need it, didn't we?


Best regards,
Krzysztof