Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <917b4cc2-4bb0-d123-006b-ffec2226b79a@linaro.org>
Date:   Fri, 29 Apr 2022 10:34:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] nvmem: change sp_otp_v0 from global to static
Content-Language: en-US
To:     Tom Rix <trix@redhat.com>, vincent.sunplus@gmail.com
Cc:     linux-kernel@vger.kernel.org
References: <20220403133906.1379832-1-trix@redhat.com>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
In-Reply-To: <20220403133906.1379832-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 03/04/2022 14:39, Tom Rix wrote:
> Smatch reports this issue
> sunplus-ocotp.c:74:29: warning: symbol 'sp_otp_v0'
>    was not declared. Should it be static?
> 
> sp_otp_v0 is only used in sunplus-ocotp.c.  File
> scope variables used only in one file should
> be static. Change sp_otp_v0's storage-class-specifier
> from global to static.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---

There is already a patch for this in next.


--srini
>   drivers/nvmem/sunplus-ocotp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvmem/sunplus-ocotp.c b/drivers/nvmem/sunplus-ocotp.c
> index 2dc59c22eb55..e0b11e13f5f8 100644
> --- a/drivers/nvmem/sunplus-ocotp.c
> +++ b/drivers/nvmem/sunplus-ocotp.c
> @@ -71,7 +71,7 @@ struct sp_ocotp_data {
>   	int size;
>   };
>   
> -const struct sp_ocotp_data  sp_otp_v0 = {
> +static const struct sp_ocotp_data  sp_otp_v0 = {
>   	.size = QAC628_OTP_SIZE,
>   };
>