Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220422162402.147958-1-adrian.hunter@intel.com>
 <20220422162402.147958-3-adrian.hunter@intel.com> <CAM9d7cgbxC_vF2A2JtnOV-we7kO1qB9W5g_X4-zAEyR=vF6AcA@mail.gmail.com>
 <7a8447da-9a3f-da37-93de-dacab5b79211@intel.com>
In-Reply-To: <7a8447da-9a3f-da37-93de-dacab5b79211@intel.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Thu, 28 Apr 2022 16:50:07 -0700
Message-ID: <CAM9d7chraAh6LS-RrQLA++gbAchcnEfBEQhEzCFTGOMmuLhHFg@mail.gmail.com>
Subject: Re: [PATCH RFC 02/21] libperf evsel: Add perf_evsel__enable_thread()
To:     Adrian Hunter <adrian.hunter@intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>, Ian Rogers <irogers@google.com>,
        Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>,
        Leo Yan <leo.yan@linaro.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Apr 27, 2022 at 9:15 PM Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> On 28/04/22 00:48, Namhyung Kim wrote:
> > Hi Adrian,
> >
> > On Fri, Apr 22, 2022 at 9:24 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
> >>
> >> Add perf_evsel__enable_thread() as a counterpart to
> >> perf_evsel__enable_cpu(), to enable all events for a thread.
> >>
> >> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> >> ---
> >>  tools/lib/perf/evsel.c              | 10 ++++++++++
> >>  tools/lib/perf/include/perf/evsel.h |  1 +
> >>  2 files changed, 11 insertions(+)
> >>
> >> diff --git a/tools/lib/perf/evsel.c b/tools/lib/perf/evsel.c
> >> index 20ae9f5f8b30..2a1f07f877be 100644
> >> --- a/tools/lib/perf/evsel.c
> >> +++ b/tools/lib/perf/evsel.c
> >> @@ -360,6 +360,16 @@ int perf_evsel__enable_cpu(struct perf_evsel *evsel, int cpu_map_idx)
> >>         return perf_evsel__run_ioctl(evsel, PERF_EVENT_IOC_ENABLE, NULL, cpu_map_idx);
> >>  }
> >>
> >> +int perf_evsel__enable_thread(struct perf_evsel *evsel, int thread)
> >> +{
> >> +       int err = 0;
> >> +       int i;
> >> +
> >> +       for (i = 0; i < xyarray__max_x(evsel->fd) && !err; i++)
> >> +               err = perf_evsel__ioctl(evsel, PERF_EVENT_IOC_ENABLE, NULL, i, thread);
> >
> > You might want to break the loop when it fails.
>
> Thanks for looking at this.  It should break because of " && !err".

Oh, I missed that part, sorry!

Thanks,
Namhyung