Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <85bb3cde-2b62-c15a-46f6-251eb06daeb1@roeck-us.net>
Date:   Thu, 28 Apr 2022 22:38:17 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] hwmon: (pmbus) add missing definitions of pmbus registers
Content-Language: en-US
To:     wujek dev <dev_public@wujek.eu>
Cc:     Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220428134634.1610241-1-dev_public@wujek.eu>
 <f8ba6a46-bbdb-b8ba-7b27-d43f2e05426d@roeck-us.net>
 <hGgSY5dLHFlYeXpEkcTTRThFR76Eevb391giqk_CiNorL3WfRpH44if4pfaOu1jMc2GuB0T51wfbHj0Aiawd28p6HvuWN9t1bzY2S_D1_fM=@wujek.eu>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <hGgSY5dLHFlYeXpEkcTTRThFR76Eevb391giqk_CiNorL3WfRpH44if4pfaOu1jMc2GuB0T51wfbHj0Aiawd28p6HvuWN9t1bzY2S_D1_fM=@wujek.eu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/28/22 18:04, wujek dev wrote:
> 
>>
>>
>> On 4/28/22 06:46, Adam Wujek wrote:
>>
>>> Definitions are taken from the table 31 of the PMBUS specification
>>> revision 1.3.1, 13 March 2015.
>>
>>
>> Do you plan to do anything with those registers, or a subset of it ?
> yes, some of PMBUS_MFR_SPECIFIC_*, but in a driver that will not be published in the near future.
> 

Adding defines just to add defines without using them only increases
source code size and compile time. Let's not do that. We can add
missing defines as they are needed.

Guenter