Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1621252iob; Fri, 29 Apr 2022 09:07:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7aq7o4HAKowkRN6DyiG05cOblrudwV1H3581sm5yHEv9gSpcLYFJDRXoQCh+OZZZTgVI2 X-Received: by 2002:a2e:8245:0:b0:24b:48b1:a1ab with SMTP id j5-20020a2e8245000000b0024b48b1a1abmr24855607ljh.152.1651248474703; Fri, 29 Apr 2022 09:07:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651248474; cv=none; d=google.com; s=arc-20160816; b=fnLKoko4i8KLWARc5hupA5ISHeQRZp4Ti64WFGSL3N8IC09MwC6iZmhT0lw5EGWxYs RhvZVdeRpjIXDxaMPuDv5ZDUuV9OgEQw4POWTg1Q1CcaIW5xO6++gDQUUrYM/5hUGXrJ MYd0v/xUoM3pxf2GPxGlBeCmhdbQPDon6EuytVNNSso1Y/aEtlaY0ojsTblWCZnymNuC auKcr8ee5HxXcqIwCNQHvs93WIBpR0dMTOnkyZkZqmYxuVHGnFMO6JzJZNZD0r6tZt3J pg/TnhEDON+NeoQoMHyuygyHSfQaBZ2KTcljz+WGgsDSrXg6+fyaORGM0pVYuIEkvbgx DHNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=F2FSC0hRsA8+n019LPklPzknF+AllKhEx1dZ7N/lS1I=; b=DstErizz1XgLucLC31H/DZEJiFBEV19ACGYqpqpLKLjXbgisjiTLGusf0fkH8HTqqm WiVfobM4c6vxkDrmyb37NC5iVMT5pkeQhXkt1ijjC8CVvj48/cIumy7hdlFFsmErTWM9 uqoXsc871Bjc1RlNRDQjxDzO93lS+tlumlf8Q5df6Ts+xi0W5atHoXKLAD7bX6wMs8/r pFLmHxTf6LG60ha28uPMV6WtI+uNSV0cVhadOD5mS7/SUEaQovasn1wkDVQY7xtnrcbJ doCfRC9mFNNgrDBegtRsJ5mpSwb7AA0yxUoFUF7Hn7oxHsdP+bT1TDd0r01/e+PJPpPU Vkgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gentwo.de header.s=default header.b=ruOivHid; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gentwo.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k21-20020a05651210d500b0046eed8d0600si8539511lfg.297.2022.04.29.09.07.26; Fri, 29 Apr 2022 09:07:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gentwo.de header.s=default header.b=ruOivHid; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gentwo.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355204AbiD2Hfn (ORCPT + 99 others); Fri, 29 Apr 2022 03:35:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240036AbiD2Hfm (ORCPT ); Fri, 29 Apr 2022 03:35:42 -0400 Received: from gentwo.de (gentwo.de [IPv6:2a02:c206:2048:5042::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5733CBE9C6 for ; Fri, 29 Apr 2022 00:32:24 -0700 (PDT) Received: by gentwo.de (Postfix, from userid 1001) id 1AC78B00482; Fri, 29 Apr 2022 09:32:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.de; s=default; t=1651217541; bh=F2FSC0hRsA8+n019LPklPzknF+AllKhEx1dZ7N/lS1I=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ruOivHidCS4FDrYYnhBEJ9lBinlWDO0c+g0CSH6FBl5PiaaeHEEC6yXiYfvfbomY0 C62qJSB1h5UU5wmnrhM1kfHYNYiYuNtlahdLg1PcX0jVqkCsV5BbbX8DxEcP07L+Oc sq8x2VbJzHOUtxA+8D1fPX2QjNn8HKKOrs24AFERi3YOkTrwMQ4akgbjj6mQyx7sE+ qRvMD0Y/L78XE/Lk6Q0M+961wBOBcm470aHMbcQIp5Y7ToMNh9Z3AHt4eXCxQUeE3G 3yNmq1WY1eCgV7jFL974N1KDQPmf5uhqfblBBFhoQolyfPnfwOsU47qPeWM3PtL9jB lDsV5l5+h9Lpw== Received: from localhost (localhost [127.0.0.1]) by gentwo.de (Postfix) with ESMTP id 1983CB00127; Fri, 29 Apr 2022 09:32:21 +0200 (CEST) Date: Fri, 29 Apr 2022 09:32:21 +0200 (CEST) From: Christoph Lameter To: andrey.konovalov@linux.dev cc: Andrew Morton , Andrey Konovalov , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Peter Collingbourne , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH 1/2] mm: slab: fix comment for ARCH_KMALLOC_MINALIGN In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Apr 2022, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > The comment next to the ARCH_KMALLOC_MINALIGN definition says that > ARCH_KMALLOC_MINALIGN can be defined in arch headers. This is incorrect: > it's actually ARCH_DMA_MINALIGN that can be defined there. The section is talking about kmalloc and not general kmem_cache_alloc() and there was the intention of separating the alignment requirements between these two groups of caches in the slab allocators.