Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220428073340.224391-1-imagedong@tencent.com>
 <20220428073340.224391-3-imagedong@tencent.com> <87fslxgx6r.fsf@toke.dk>
In-Reply-To: <87fslxgx6r.fsf@toke.dk>
From:   Menglong Dong <menglong8.dong@gmail.com>
Date:   Fri, 29 Apr 2022 09:27:11 +0800
Message-ID: <CADxym3Z0bktRmOACS1eayh3batVBuGefKZEoYgRE2Cn6DJfr_A@mail.gmail.com>
Subject: Re: [PATCH net-next v2 2/2] net: tcp: add skb drop reasons to route_req()
To:     =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@redhat.com>
Cc:     Eric Dumazet <edumazet@google.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>,
        David Miller <davem@davemloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        David Ahern <dsahern@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Biao Jiang <benbjiang@tencent.com>,
        Hao Peng <flyingpeng@tencent.com>,
        Menglong Dong <imagedong@tencent.com>,
        Martin Lau <kafai@fb.com>, Talal Ahmad <talalahmad@google.com>,
        Kees Cook <keescook@chromium.org>,
        Mengen Sun <mengensun@tencent.com>,
        Dongli Zhang <dongli.zhang@oracle.com>,
        LKML <linux-kernel@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Apr 28, 2022 at 9:22 PM Toke H=C3=B8iland-J=C3=B8rgensen <toke@redh=
at.com> wrote:
>
> menglong8.dong@gmail.com writes:
>
> > From: Menglong Dong <imagedong@tencent.com>
> >
> > Add skb drop reasons to the route_req() in struct tcp_request_sock_ops.
> > Following functions are involved:
> >
> >   tcp_v4_route_req()
> >   tcp_v6_route_req()
> >   subflow_v4_route_req()
> >   subflow_v6_route_req()
> >
> > And the new reason SKB_DROP_REASON_SECURITY is added, which is used whe=
n
> > skb is dropped by LSM.
>
> Could we maybe pick a slightly less generic name? If I saw
> "SKB_DROP_REASON_SECURITY" my first thought would be something related
> to *network* security, like a firewall. Maybe just SKB_DROP_REASON_LSM?
>

Thanks for your suggestion, and I think SKB_DROP_REASON_LSM is fine.
I'll change it in the next version.

Menglong Dong

> -Toke
>