Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 28 Apr 2022 14:25:08 +0000
From:   Sean Christopherson <seanjc@google.com>
To:     "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc:     Maxim Levitsky <mlevitsk@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 05/11] KVM: SVM: Re-inject INT3/INTO instead of
 retrying the instruction
Message-ID: <YmqjxNQiMABl+tX7@google.com>
References: <20220423021411.784383-1-seanjc@google.com>
 <20220423021411.784383-6-seanjc@google.com>
 <051f508121bcf47d8cbc79ee2c0817aafbe5af48.camel@redhat.com>
 <9553b164-67a6-3634-34c5-f7319ce2dc60@maciej.szmigiero.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9553b164-67a6-3634-34c5-f7319ce2dc60@maciej.szmigiero.name>
Precedence: bulk

On Thu, Apr 28, 2022, Maciej S. Szmigiero wrote:
> On 28.04.2022 11:37, Maxim Levitsky wrote:
> > On Sat, 2022-04-23 at 02:14 +0000, Sean Christopherson wrote:
> > > @@ -1618,7 +1644,7 @@ static int svm_set_nested_state(struct kvm_vcpu *vcpu,
> > >   	nested_copy_vmcb_control_to_cache(svm, ctl);
> > >   	svm_switch_vmcb(svm, &svm->nested.vmcb02);
> > > -	nested_vmcb02_prepare_control(svm, save->rip);
> > > +	nested_vmcb02_prepare_control(svm, svm->vmcb->save.rip);
> > 
> > Is this change intentional?
> 
> It looks to me the final code is correct since "svm->vmcb->save"
> contains L2 register save, while "save" has L1 register save.
> 
> It was the patch 1 from this series that was incorrect in
> using "save->rip" here instead.

Yeah, I botched the fixup.