Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <tencent_6A5CCC9FB9221C4A1414E1534A3DFFC62008@qq.com>
In-Reply-To: <tencent_6A5CCC9FB9221C4A1414E1534A3DFFC62008@qq.com>
From:   Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Date:   Thu, 28 Apr 2022 08:51:30 -0600
Message-ID: <CAOCk7Np+tVPtSXGzdwHJZqfgVseVKKZ4znThPx_9ApxMOqRZyA@mail.gmail.com>
Subject: Re: [PATCH] iommu/msm: add a check for the return of kzalloc()
To:     xkernel.wang@foxmail.com
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        MSM <linux-arm-msm@vger.kernel.org>,
        iommu@lists.linux-foundation.org,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Mar 25, 2022 at 2:13 PM <xkernel.wang@foxmail.com> wrote:
>
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
>
> kzalloc() is a memory allocation function which can return NULL when
> some internal memory errors happen. So it is better to check it to
> prevent potential wrong memory access.
>
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
> ---
>  drivers/iommu/msm_iommu.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c
> index 3a38352..697ad63 100644
> --- a/drivers/iommu/msm_iommu.c
> +++ b/drivers/iommu/msm_iommu.c
> @@ -597,6 +597,10 @@ static void insert_iommu_master(struct device *dev,
>
>         if (list_empty(&(*iommu)->ctx_list)) {
>                 master = kzalloc(sizeof(*master), GFP_ATOMIC);
> +               if (!master) {
> +                       dev_err(dev, "Failed to allocate iommu_master\n");

How do you reconcile this with chapter 14 of the coding style document?

"These generic allocation functions all emit a stack dump on failure when used
without __GFP_NOWARN so there is no use in emitting an additional failure
message when NULL is returned."

> +                       return;
> +               }
>                 master->of_node = dev->of_node;
>                 list_add(&master->list, &(*iommu)->ctx_list);
>                 dev_iommu_priv_set(dev, master);
> --