Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1790258iob; Fri, 29 Apr 2022 12:58:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/MamburVWHvDPuO4XwKb1BbcFHhAv0Yuws8LqpCNWmCqXyumHoOJndmNp6M/qLH0XEx06 X-Received: by 2002:a2e:98d8:0:b0:24f:2593:c1ae with SMTP id s24-20020a2e98d8000000b0024f2593c1aemr519652ljj.224.1651262333073; Fri, 29 Apr 2022 12:58:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651262333; cv=none; d=google.com; s=arc-20160816; b=MVrZAiN4CmoHlXuUuPBXhUMGmw+dUPdCDgKWxT5yxEgiICLwVnbIDdUmITmBFDrSoE KkyTxE1h7UpPzdfv0OkqG97+n/8JmFo8wqmwa/huavVzjWTvyVOKSOd6WzVjWkonHlCB 8GizQjWctWR7yHXb/vpR46EcLsUh5T0gOI9a0xJR63i+p1Pi4qe07Dikvv1rkzEMjCKF 2xjmwo/QpsaADfueeQSDlidA4ZIU+fJQ39kxZdbrGYWjjjhKb/PTgZ9jqzxT60x52/3u 1M0EPv/AWi2EonDsxWqyU3Vh5VKuIaUOeAZPEEeANLkfzrWx4GXZP2U+FesXqSkyrnNz qnbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=A1VTFJE968v5GHpvmbVSvv7tzCFKNqranep89YCahco=; b=EiiL5LHPlj6C/4UOlQb1iPlBWsQfcBgS68FCfqmiBiURtVezzBrHX236pyHFn6Nw90 4I64QYieyzgryZX5kN64Ipww0JvuI7a1qGIyzmP65P0/ekmsmEqwqchtgIc21DFsMz/+ +sQ12sS9KSU3d6ZaqTdSfMYz6iMnFJVT1r3rGAeDAQJoBgOEb3SX+dNIQ4mIdxM1qRGG z62IRl/2gOQWDVRlyrMXnHbNvulNzmwSLoCp/RA4fjAmz2alEXSZ5yynK4MxIGEKHgCv iqFEuVNPo7wCVfXKZu8WBczM97OcUkwPa6ZTH7rmp86Nceqx6GgZQXJy5El68mdTOgBi 0h2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=FgZVFGyK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c1-20020a056512104100b00471f866b3d9si7750465lfb.607.2022.04.29.12.58.25; Fri, 29 Apr 2022 12:58:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=FgZVFGyK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379712AbiD2Rhf (ORCPT + 99 others); Fri, 29 Apr 2022 13:37:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379029AbiD2Rha (ORCPT ); Fri, 29 Apr 2022 13:37:30 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BEAD4132A for ; Fri, 29 Apr 2022 10:34:12 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id j4so15253678lfh.8 for ; Fri, 29 Apr 2022 10:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A1VTFJE968v5GHpvmbVSvv7tzCFKNqranep89YCahco=; b=FgZVFGyKAlcmm7+KHCsydqDe/OWhm1Tfax+GzbxCKfwolWa55sMS5nG0dA9rPZgq2m EJkl4ahYxA3niUEu2nWkdFhhPQk+svsaX/K17RXYIt57xc/go9cBRWPSY25hcd9MvN5N XdYX9/C44U0Dqv3sAPePvqB17Qft4wMIdoKGwz9UfG4Lbi4Th6xvMONGoS8yfEgNsqxT NsygHY2Lao2TgkbBUCIEwXWMk3icUslJeTR8MyVh5sDcsfU2Qj2P5QA6ua64sGvlOj/p D3cks9hLuyfEM2E2I6Mc58SkX5SrOjJo97N97Ye4zs2KDRKRO6ToWYCVFqjwCXM3I9pW nIsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A1VTFJE968v5GHpvmbVSvv7tzCFKNqranep89YCahco=; b=AxwOF/+6/VXwhQnNtVWKHGpB9bmhOBdjCe+C/GPRvqtqsjMuAvL2HoaPK6Mn0QL6IC y4IsdrK6QbouCHzyiXZmJ+toewdQYdOpdY++vFFsZ20cbJU3saRHiYYOhTOegiqu8dzy jRU2RTyW+B8CwcttTBQlxf9ynwgzKSMgt6L5mp4fQrn35WxvDcdx3HqfLTl4jPDL+9TV hqKxYVYEbzkZaq+/2LcCDw+WttIfRkS4uhiBg+BuBd7TybNbicjTeiQ5PGBJ/JMGRn3m 2Ev6N8rx45otzfZNJUoreya6r5GRn+F7/vlaNyz0i8p6uLDgE4/mI7bNmaPZ3JwKBmKt rcfQ== X-Gm-Message-State: AOAM531f6H0wblXKrSZ/FUtVBdkMNVHNhZdvt0z3156TWfuBudex6ZJ+ HoD1ZUklSMjPhjlJvoSdlAW8MHttDVaS/lG9Z84Q0Q== X-Received: by 2002:a05:6512:12c6:b0:44a:650f:3b86 with SMTP id p6-20020a05651212c600b0044a650f3b86mr211123lfg.79.1651253650122; Fri, 29 Apr 2022 10:34:10 -0700 (PDT) MIME-Version: 1.0 References: <20220407195908.633003-1-pgonda@google.com> <62e9ece1-5d71-f803-3f65-2755160cf1d1@redhat.com> <4c0edc90-36a1-4f4c-1923-4b20e7bdbb4c@redhat.com> <0d282be4-d612-374d-84ba-067994321bab@redhat.com> <8a2c5f8c-503c-b4f0-75e7-039533c9852d@redhat.com> <4afce434-ab25-66d6-76f4-3a987f64e88e@redhat.com> In-Reply-To: From: Peter Gonda Date: Fri, 29 Apr 2022 11:33:58 -0600 Message-ID: Subject: Re: [PATCH v3] KVM: SEV: Mark nested locking of vcpu->lock To: Paolo Bonzini Cc: John Sperbeck , kvm list , David Rientjes , Sean Christopherson , LKML Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 29, 2022 at 11:32 AM Paolo Bonzini wrote: > > On 4/29/22 19:27, Peter Gonda wrote: > > Ah yes I missed that. I would suggest `role = SEV_NR_MIGRATION_ROLES` > > or something else instead of role++ to avoid leaking this > > implementation detail outside of the function signature / enum. > > Sure. OK. I'll get that tested and get a V4 out. Thank you for all the help here Paolo!! > > Paolo >