Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a04e9d8e-33e4-a8a3-e4be-e4c098fe4b07@linaro.org>
Date:   Fri, 29 Apr 2022 10:29:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 1/3] nvmem: bcm-ocotp: mark ACPI device ID table as maybe
 unused
Content-Language: en-US
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        Vincent Shih <vincent.sunplus@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
References: <20220321110326.44652-1-krzk@kernel.org>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
In-Reply-To: <20220321110326.44652-1-krzk@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 21/03/2022 11:03, Krzysztof Kozlowski wrote:
> "bcm_otpc_acpi_ids" is used with ACPI_PTR, so a build with !CONFIG_ACPI
> has a warning:
> 
>    drivers/nvmem/bcm-ocotp.c:247:36: error:
>      ‘bcm_otpc_acpi_ids’ defined but not used [-Werror=unused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>


Applied all thanks,
--srini
> ---
>   drivers/nvmem/bcm-ocotp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvmem/bcm-ocotp.c b/drivers/nvmem/bcm-ocotp.c
> index a8097511582a..dfea96c52463 100644
> --- a/drivers/nvmem/bcm-ocotp.c
> +++ b/drivers/nvmem/bcm-ocotp.c
> @@ -244,7 +244,7 @@ static const struct of_device_id bcm_otpc_dt_ids[] = {
>   };
>   MODULE_DEVICE_TABLE(of, bcm_otpc_dt_ids);
>   
> -static const struct acpi_device_id bcm_otpc_acpi_ids[] = {
> +static const struct acpi_device_id bcm_otpc_acpi_ids[] __maybe_unused = {
>   	{ .id = "BRCM0700", .driver_data = (kernel_ulong_t)&otp_map },
>   	{ .id = "BRCM0701", .driver_data = (kernel_ulong_t)&otp_map_v2 },
>   	{ /* sentinel */ }