Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 29 Apr 2022 13:30:14 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Fabio Estevam <festevam@gmail.com>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org,
        Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: [sailus-media-tree:master 55/60] drivers/media/i2c/adv7180.c:573
 adv7180_test_pattern() error: uninitialized symbol 'reg'.
Message-ID: <202204290610.SVJgr8qV-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?A0JJqrSQ+rVTbzFkZLL9Gex5ayD2c4VQ0GI2Yv1C6rKpuD+JRjPhDKfmZgzb?=
 =?us-ascii?Q?yIa7PUDOhstnehIIdsbUzgabx2F7YioUOjjOH3K5JkDJ03Lmw/hwJn2uU30I?=
 =?us-ascii?Q?Mq1QzFJ7IYy71YLvYUSBx61hz0OVF39mI3YjWbNodhOiZusgQctPTal0yZqV?=
 =?us-ascii?Q?lKIIb86BRynJTE4GvC9B02pmGNEk/rFH6Bwv3y8BUgYC3W4VjBesn5Rq5LWM?=
 =?us-ascii?Q?MQsQjtzEBMDwDOojLC9oZBaOkqSNI5DJ8tltO6snNv+WUs/OtDqGVuevMPmC?=
 =?us-ascii?Q?mBrDuN/bXuvGYEwDJep5ruZRK3NJym4mgb5OTZuCdhNM8uzzNynzo12eO+Aa?=
 =?us-ascii?Q?+h90yzjbJutqKvDCGZwOfQUPqc4+4pz4rAxTdwsjR9PYp3fw/8cqngB/l+gf?=
 =?us-ascii?Q?H3DZACCK7kqkmlkpU2fNCa+BBL+Sn+mcEkrl0i//NCV3ubqeVMkvyWspg9tD?=
 =?us-ascii?Q?HfdOjXCuRss5PtR+lOF/Za5B//Qb30lMU5+aq3XTlHqTiYnz+V3ICAQRUg4c?=
 =?us-ascii?Q?TIE3B2tyakPDccaAR9kpJSalTS3ZkPwatFNlA8BcCaVJMwHMl5VVc3fNmgw3?=
 =?us-ascii?Q?5qDpdMn7VebBxTPvM7WIERxeGe46MQ4fpXXkV5yoFKEf8tRLxdiEaM54pegE?=
 =?us-ascii?Q?vjGrPQvBFAx038PtRJaMpDCc/IihGh7o85lZcRVu7I86zh7K62nzYC7uUvxy?=
 =?us-ascii?Q?x3MTbFUiJ4d/TvcTg7WV8FQZYR9xh+9mF47j9P23qcpa3DAw9915p0tAjLTN?=
 =?us-ascii?Q?jwF6pMrJX/v+eSAwzWHBS+PRnAzFHWUDsmd0wuWtIn5dHCq8G2EBIz3xMoSO?=
 =?us-ascii?Q?vPVHucD3CTM8lNPJ+TDYKKq2Y+tdvtWUat4X/ZzFI54xYc8Y++GQ9+Nq4nb7?=
 =?us-ascii?Q?Nv8MtUL66hIS7X6JvuJThqv2N2wboyON4ls50eXLvCfKoqZBMFuRkQaMW+Is?=
 =?us-ascii?Q?zahqwCO86clI5HAl4lsxhsrjUJSPNZoJKklKL+dJ/KbCog6z7z6O+iiQ58TN?=
 =?us-ascii?Q?bHzZ0alnxM9MLeE/vbtVKQ8gXLHPAQ3A8y/5BkKR3TdAaEzRPazZqByGC65h?=
 =?us-ascii?Q?bYL+1OiMFjfnWYS59rtE6jylYqGlyTe+Ua6004D6HDWZrthKK8Ms99SfFcx3?=
 =?us-ascii?Q?zWzCncy/3RsaHmckosGBQz9NqJNIO3E3snF3Wrhf6GfNOLRqOT9pMQ9bQFAi?=
 =?us-ascii?Q?OOteQaYd16RGzwrrASt+M3Dm0ErV6uJelK/EcBzl9cIS5TBObRqgtXZp6XJq?=
 =?us-ascii?Q?DzSqr8aOI2oA6DKuY+mI/GvEPfTVN0Kp9Qvv0y8pku8N8zNXbPhey5RFrWqq?=
 =?us-ascii?Q?xVfgoP6rp6tcIYLET/vIBcPAl/O3bRwl+1asP4bP9rfUCuCII/uFAEWI/Kbs?=
 =?us-ascii?Q?RF/6EHR8pc1zBLE7raThuobjky1/rZUa22jJABUX3VJ3D3sVwH/AyKogfgri?=
 =?us-ascii?Q?1n/tY3tQ0HLUNvyTOxJr4SUw72nDlSLqsneYFJ+O94h1Ubwa69X6sWep/yz4?=
 =?us-ascii?Q?EUg63WNek0Vf3xr2EsGQsyXndp28US443P7jUYs47SWvGi/Bgo/tccn/lEEI?=
 =?us-ascii?Q?JL96LlkbrbVgXq5x5u1h05g288002VPtVdh04+LzyFTJl8JOBrYx6N0I4Mrz?=
 =?us-ascii?Q?t5NNVWNL97Pbaf/njg7VYQUrW+ditfgGW/IKZmtqAGMYNBqPKQFKdfT6wDvD?=
 =?us-ascii?Q?B3PpJ33gWXjtH8SRJQqWV2fsTkEfluTZ56PC2yNs1dKYYLHIcy0irGcqcTQL?=
 =?us-ascii?Q?NsAzJx0FBauQ3q1MwMHOB5K3TofpVf8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bbb8cf68-26b9-48e8-7f1d-08da29cb4a87
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 10:30:33.4027
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ur5bXnMaichmZZ5itTWc7a2i9SMhNMaNJrUeZbgt5Pu6HiHk/G/LGiIIMGt0Q86WPGRF4Jwr377YlCsZPqYsm5dZZu9EUGy6X6Q2/WtGeBA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4674
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-29_03:2022-04-28,2022-04-29 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999
 malwarescore=0 mlxscore=0 phishscore=0 bulkscore=0 adultscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204290060
X-Proofpoint-GUID: pb0nB3Hnm3DzL09nWAyRq6HMh2-vx3ll
X-Proofpoint-ORIG-GUID: pb0nB3Hnm3DzL09nWAyRq6HMh2-vx3ll
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   git://linuxtv.org/sailus/media_tree.git master
head:   ea1280040a678f38a4ce6f1817933c04cfe74552
commit: f3b4b140d87dc7f256229f20a8d70429a7549aca [55/60] media: i2c: adv7180: Add support for the test patterns
config: microblaze-randconfig-m031-20220427 (https://download.01.org/0day-ci/archive/20220429/202204290610.SVJgr8qV-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 11.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/media/i2c/adv7180.c:573 adv7180_test_pattern() error: uninitialized symbol 'reg'.

vim +/reg +573 drivers/media/i2c/adv7180.c

f3b4b140d87dc7f Fabio Estevam 2022-04-27  563  static int adv7180_test_pattern(struct adv7180_state *state, int value)
f3b4b140d87dc7f Fabio Estevam 2022-04-27  564  {
f3b4b140d87dc7f Fabio Estevam 2022-04-27  565  	unsigned int reg;
f3b4b140d87dc7f Fabio Estevam 2022-04-27  566  
f3b4b140d87dc7f Fabio Estevam 2022-04-27  567  	/* Map menu value into register value */
f3b4b140d87dc7f Fabio Estevam 2022-04-27  568  	if (value < 3)
f3b4b140d87dc7f Fabio Estevam 2022-04-27  569  		reg = value;
f3b4b140d87dc7f Fabio Estevam 2022-04-27  570  	if (value == 3)
f3b4b140d87dc7f Fabio Estevam 2022-04-27  571  		reg = 5;

Just write something like:

	if (value < 3)
		reg = value;
	else
		reg = 3;

f3b4b140d87dc7f Fabio Estevam 2022-04-27  572  
f3b4b140d87dc7f Fabio Estevam 2022-04-27 @573  	adv7180_write(state, ADV7180_REG_ANALOG_CLAMP_CTL, reg);
                                                                                                   ^^^
Uninitialized

f3b4b140d87dc7f Fabio Estevam 2022-04-27  574  
f3b4b140d87dc7f Fabio Estevam 2022-04-27  575  	if (value == ARRAY_SIZE(test_pattern_menu) - 1) {
f3b4b140d87dc7f Fabio Estevam 2022-04-27  576  		reg = adv7180_read(state, ADV7180_REG_DEF_VALUE_Y);
f3b4b140d87dc7f Fabio Estevam 2022-04-27  577  		reg &= ~ADV7180_DEF_VAL_EN;
f3b4b140d87dc7f Fabio Estevam 2022-04-27  578  		adv7180_write(state, ADV7180_REG_DEF_VALUE_Y, reg);
f3b4b140d87dc7f Fabio Estevam 2022-04-27  579  		return 0;
f3b4b140d87dc7f Fabio Estevam 2022-04-27  580  	}
f3b4b140d87dc7f Fabio Estevam 2022-04-27  581  
f3b4b140d87dc7f Fabio Estevam 2022-04-27  582  	reg = adv7180_read(state, ADV7180_REG_DEF_VALUE_Y);
f3b4b140d87dc7f Fabio Estevam 2022-04-27  583  	reg |= ADV7180_DEF_VAL_EN | ADV7180_DEF_VAL_AUTO_EN;
f3b4b140d87dc7f Fabio Estevam 2022-04-27  584  	adv7180_write(state, ADV7180_REG_DEF_VALUE_Y, reg);
f3b4b140d87dc7f Fabio Estevam 2022-04-27  585  
f3b4b140d87dc7f Fabio Estevam 2022-04-27  586  	return 0;
f3b4b140d87dc7f Fabio Estevam 2022-04-27  587  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp