Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220427161717.v1.1.I300757d61810c5e9aa60ff964d09251cb4422c73@changeid>
In-Reply-To: <20220427161717.v1.1.I300757d61810c5e9aa60ff964d09251cb4422c73@changeid>
From:   Doug Anderson <dianders@chromium.org>
Date:   Thu, 28 Apr 2022 08:19:48 -0700
Message-ID: <CAD=FV=WwN-mANNGK_2Lo8u0kuBcG_UOLdKQVfxEVpnmn0pMbTQ@mail.gmail.com>
Subject: Re: [PATCH v1] arm64: dts: qcom: sc7180: Add kingoftown dts files
 from v5.4 branch
To:     "Joseph S. Barrera III" <joebar@chromium.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Alexandru M Stan <amstan@chromium.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Wed, Apr 27, 2022 at 4:17 PM Joseph S. Barrera III
<joebar@chromium.org> wrote:
>
> Kingoftown is a trogdor-based board, shipping to customers as the
> HP Fortis 11 G9 Q Chromebook. These dts files are unchanged copies
> from the downstream Chrome OS 5.4 kernel.
>
> Signed-off-by: Joseph S. Barrera III <joebar@chromium.org>
> ---
>
>  arch/arm64/boot/dts/qcom/Makefile             |   2 +
>  .../dts/qcom/sc7180-trogdor-kingoftown-r0.dts |  44 ++++
>  .../dts/qcom/sc7180-trogdor-kingoftown-r1.dts |  17 ++
>  .../dts/qcom/sc7180-trogdor-kingoftown.dtsi   | 223 ++++++++++++++++++
>  4 files changed, 286 insertions(+)

This looks reasonable to me, but I think it would actually be more
convenient to send the support for the 3 boards you're adding in one
series just to reduce the likelihood of conflicts in the Makefile. Can
just include all 3 patches at once and call it "v3"?

Also: for future reference, the first version is usually not called
"v1". Usually the first version simply has no version at all and then
the second version is v2. In patman you simply leave "Series-version"
off the first patch that'll work.

-Doug