Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 28 Apr 2022 18:16:21 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Liam Howlett <liam.howlett@oracle.com>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Yu Zhao <yuzhao@google.com>
Subject: Re: [PATCH v8 23/70] mm/mmap: change do_brk_flags() to expand
 existing VMA and add do_brk_munmap()
Message-Id: <20220428181621.636487e753422ad0faf09bd6@linux-foundation.org>
In-Reply-To: <20220429003841.cx7uenepca22qbdl@revolver>
References: <20220426150616.3937571-1-Liam.Howlett@oracle.com>
        <20220426150616.3937571-24-Liam.Howlett@oracle.com>
        <20220428201947.GA1912192@roeck-us.net>
        <20220429003841.cx7uenepca22qbdl@revolver>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 29 Apr 2022 00:38:50 +0000 Liam Howlett <liam.howlett@oracle.com> wrote:

> > mm/mmap.c: In function 'do_brk_flags':
> > mm/mmap.c:2908:17: error: implicit declaration of function
> > 	'khugepaged_enter_vma_merge'; did you mean 'khugepaged_enter_vma'?
> > 
> > It appears that this is later fixed, but it hurts bisectability
> > (and prevents me from finding the actual build failure in linux-next
> > when trying to build corenet64_smp_defconfig).
> 
> Yeah, that khugepaged_enter_vma_merge was renamed in another patch set.
> Andrew made the correction but kept the patch as it was.  I think the
> suggested change is right.. if you read the commit that introduced
> khugepaged_enter_vma(), it seems right at least.

Things are a bit crazy lately.  Merge issues with mapletree, merge
issues with mglru on mapletree, me doing a bunch of retooling to start
publishing/merging via git, mapletree runtime issues, etc.

I've dropped the mapletree patches again.  Please scoop up all known
fixes and redo against the (non-rebasing) mm-stable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

The mm-unstable branch is a rebasing tree which contains mm-stable as
well as all the quilt-based MM material which isn't final enough to get
into mm-stable.  So before sending please do a test merge with mm-unstable,
evaluate any issues which might be encountered.

I'd prefer to concentrate on getting mapletree stabilized and landed
for now, worry about mglru after that.