Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <e05ec742-c3dc-df7c-c5d7-29358d0a7081@linux.intel.com>
 <20220424015757.21993-1-surong.pang@gmail.com> <YmfdN97xtmwSOo59@kroah.com> <CAEDbmAQmYQdMNY8sANnSuauBcsemrV1MFR3bB83JJ7cHNdWGmA@mail.gmail.com>
In-Reply-To: <CAEDbmAQmYQdMNY8sANnSuauBcsemrV1MFR3bB83JJ7cHNdWGmA@mail.gmail.com>
From:   surong pang <surong.pang@gmail.com>
Date:   Fri, 29 Apr 2022 09:54:46 +0800
Message-ID: <CAEDbmARx0EvvUo_d7w5-gtTvSp3YiTatsMZoBJVZc2O7-M+cWw@mail.gmail.com>
Subject: Re: [PATCH V2] xhci-plat: Let usb phy shutdown later
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Mathias Nyman <mathias.nyman@linux.intel.com>,
        mathias.nyman@intel.com, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org, Orson.Zhai@unisoc.com,
        yunguo.wu@unisoc.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Dear Greg,
Sorry for html email response.
Yes, The subject should say "xhci-plat". And it didn't fix a specific commi=
t id.

surong pang <surong.pang@gmail.com> =E4=BA=8E2022=E5=B9=B44=E6=9C=8828=E6=
=97=A5=E5=91=A8=E5=9B=9B 14:26=E5=86=99=E9=81=93=EF=BC=9A
>
> Dear Greg,
> No,  It's just a patch to call usb_phy_shutdown later.
>
>
> Greg KH <gregkh@linuxfoundation.org> =E4=BA=8E2022=E5=B9=B44=E6=9C=8826=
=E6=97=A5=E5=91=A8=E4=BA=8C 19:53=E5=86=99=E9=81=93=EF=BC=9A
>>
>> On Sun, Apr 24, 2022 at 09:57:57AM +0800, Surong Pang wrote:
>> > From: Surong Pang <surong.pang@unisoc.com>
>> >
>> > Let usb phy shutdown later in xhci_plat_remove function.
>> > Some phy driver doesn't divide 3.0/2.0 very clear.
>> > If calls usb_phy_shutdown earlier than usb_remove_hcd(hcd),
>> > It will case 10s cmd timeout issue.
>> >
>> > Call usb phy shutdown later has better compatibility.
>> >
>> > Signed-off-by: Surong Pang <surong.pang@unisoc.com>
>>
>> The subject should say "xhci-plat", right?
>>
>> > ---
>> >  drivers/usb/host/xhci-plat.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat=
.c
>> > index 649ffd861b44..fe492ed99cb7 100644
>> > --- a/drivers/usb/host/xhci-plat.c
>> > +++ b/drivers/usb/host/xhci-plat.c
>> > @@ -390,13 +390,13 @@ static int xhci_plat_remove(struct platform_devi=
ce *dev)
>> >
>> >       usb_remove_hcd(shared_hcd);
>> >       xhci->shared_hcd =3D NULL;
>> > -     usb_phy_shutdown(hcd->usb_phy);
>> >
>> >       usb_remove_hcd(hcd);
>> >       usb_put_hcd(shared_hcd);
>> >
>> >       clk_disable_unprepare(clk);
>> >       clk_disable_unprepare(reg_clk);
>> > +     usb_phy_shutdown(hcd->usb_phy);
>> >       usb_put_hcd(hcd);
>>
>> Does this fix a specific commit id?
>>
>> thanks,
>>
>> greg k-h