Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Zixuan Fu <r33s3n6@gmail.com>, mathias.nyman@intel.com,
        gregkh@linuxfoundation.org
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        baijiaju1990@gmail.com, TOTE Robot <oslab@tsinghua.edu.cn>
References: <20220428092321.3011983-1-r33s3n6@gmail.com>
From:   Mathias Nyman <mathias.nyman@linux.intel.com>
Subject: Re: [PATCH v2 resend] drivers: usb: host: fix NULL pointer
 dereferences triggered by unhandled errors in xhci_create_rhub_port_array()
Message-ID: <eb417aeb-92f2-8910-378f-00031fbbcae5@linux.intel.com>
Date:   Thu, 28 Apr 2022 15:44:29 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20220428092321.3011983-1-r33s3n6@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 28.4.2022 12.23, Zixuan Fu wrote:
> In xhci_create_rhub_port_array(), when rhub->num_ports is zero, 
> rhub->ports would not be set; when kcalloc_node() fails, rhub->ports
> would be set to NULL. In these two cases, xhci_create_rhub_port_array()
> just returns void, and thus its callers are unaware of the error.
> 
> Then rhub->ports is dereferenced in xhci_usb3_hub_descriptor() or 
> xhci_usb2_hub_descriptor().

As it turned out this dereference is only an issue if kcalloc_node() failed,
not if rhub->num_ports is zero.

So this is more of a theoretical issue. Not urgent, not for stable.

So as Greg suggested its probably better to add this fix on top of
the one roothub support series it conflicts with.


Thanks
Mathias