Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 29 Apr 2022 13:12:49 -0700
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     x86@kernel.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org,
        linux-toolchains@vger.kernel.org
Subject: Re: [PATCH] linkage: Fix issue with missing symbol size
Message-ID: <20220429201249.5hjcutds4wmkhemr@treble>
References: <20220429091859.GS2731@worktop.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220429091859.GS2731@worktop.programming.kicks-ass.net>
Precedence: bulk

On Fri, Apr 29, 2022 at 11:18:59AM +0200, Peter Zijlstra wrote:
> 
> Occasionally, typically when a function doesn't end with 'ret', an
> alias on that function will have 0 size.
> 
> The difference between what GCC generates and our linkage magic, is
> that GCC doesn't appear to provide .size for the alias'ed symbol at
> all. And indeed, removing this directive cures the issue.
> 
> Additionally, GCC also doesn't emit .type for alias symbols either, so
> also omit that.
> 
> Fixes: e0891269a8c2 ("linkage: add SYM_FUNC_ALIAS{,_LOCAL,_WEAK}()")
> Suggested-by: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>

Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

-- 
Josh