Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4ff0ca7c-8f41-374a-9862-3cb30c7d8d66@linux.intel.com>
Date:   Fri, 29 Apr 2022 11:17:33 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 2/2] perf vendor events intel: Add cpuid for
 sapphirerapids
Content-Language: en-US
To:     Ian Rogers <irogers@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
        Andi Kleen <ak@linux.intel.com>,
        Jin Yao <yao.jin@linux.intel.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220428202912.1056444-1-irogers@google.com>
 <20220428202912.1056444-2-irogers@google.com>
From:   Xing Zhengjun <zhengjun.xing@linux.intel.com>
In-Reply-To: <20220428202912.1056444-2-irogers@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 4/29/2022 4:29 AM, Ian Rogers wrote:
> Fixes compile time warnings:
> 
> pmu-events/pmu-events.c:27238:31: error: ‘pme_sapphirerapids’ defined but not used [-Werror=unused-const-variable=]
> 27238 | static const struct pmu_event pme_sapphirerapids[] = {
>        |                               ^~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>   tools/perf/pmu-events/arch/x86/mapfile.csv | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/pmu-events/arch/x86/mapfile.csv b/tools/perf/pmu-events/arch/x86/mapfile.csv
> index 963a76fec277..4b47ac1b806d 100644
> --- a/tools/perf/pmu-events/arch/x86/mapfile.csv
> +++ b/tools/perf/pmu-events/arch/x86/mapfile.csv
> @@ -41,6 +41,7 @@ GenuineIntel-6-A7,v1,icelake,core
>   GenuineIntel-6-6A,v1,icelakex,core
>   GenuineIntel-6-6C,v1,icelakex,core
>   GenuineIntel-6-86,v1,tremontx,core
> +GenuineIntel-6-8F,v1,sapphirerapids,core

In 
https://lore.kernel.org/all/20220413210503.3256922-3-irogers@google.com/, it 
has already added the cpuid for sapphirerapids

>   GenuineIntel-6-96,v1,elkhartlake,core
>   GenuineIntel-6-97,v1,alderlake,core
>   GenuineIntel-6-9A,v1,alderlake,core

-- 
Zhengjun Xing