Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 30 Apr 2022 17:48:06 +1000 (AEST)
From:   Finn Thain <fthain@linux-m68k.org>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
cc:     Wan Jiabing <wanjiabing@vivo.com>,
        James Smart <james.smart@broadcom.com>,
        Ram Vegesna <ram.vegesna@broadcom.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Daniel Wagner <dwagner@suse.de>, linux-scsi@vger.kernel.org,
        target-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
        cocci@inria.fr
Subject: Re: [PATCH] scsi: elx: efct: remove unnecessary memset in efct_io
In-Reply-To: <794191df-e745-c591-bf1d-37945f96e73a@wanadoo.fr>
Message-ID: <eab847fe-8d17-1a38-b55e-e68a2f6a1829@linux-m68k.org>
References: <20220318145230.1031-1-wanjiabing@vivo.com> <794191df-e745-c591-bf1d-37945f96e73a@wanadoo.fr>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="-1463811774-987175101-1651304886=:14454"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

---1463811774-987175101-1651304886=:14454
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Sat, 30 Apr 2022, Christophe JAILLET wrote:

> Le 18/03/2022 =C3=A0 15:52, Wan Jiabing a =C3=A9crit=C2=A0:
> > io->sgl is allocated by kzalloc(). The memory is set to zero.
> > It is unnecessary to call memset again.
> >=20
>=20
> Hi,
>=20
> Nitpick: this kzalloc() should be a kcalloc() to avoid an open-coded
> multiplication when computing the size to allocate.
>=20

Seems like kcalloc() conversion could be a separate patch. Perhaps it=20
could be done everywhere using a coccinelle script.
---1463811774-987175101-1651304886=:14454--