Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
Subject: Re: [PATCH 1/2] perf bench: Fix two numa NDEBUG warnings
From:   Athira Rajeev <atrajeev@linux.vnet.ibm.com>
In-Reply-To: <20220428202912.1056444-1-irogers@google.com>
Date:   Fri, 29 Apr 2022 14:51:25 +0530
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Andi Kleen <ak@linux.intel.com>,
        Jin Yao <yao.jin@linux.intel.com>,
        Zhengjun Xing <zhengjun.xing@linux.intel.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <FDBE8FEC-CC4B-43C2-B2AA-3ECCFF95A98E@linux.vnet.ibm.com>
References: <20220428202912.1056444-1-irogers@google.com>
To:     Ian Rogers <irogers@google.com>
Precedence: bulk


> On 29-Apr-2022, at 1:59 AM, Ian Rogers <irogers@google.com> wrote:
>=20
> BUG_ON is a no-op if NDEBUG is defined, otherwise it is an assert.
> Compiling with NDEBUG yields:
>=20
> bench/numa.c: In function =E2=80=98bind_to_cpu=E2=80=99:
> bench/numa.c:314:1: error: control reaches end of non-void function =
[-Werror=3Dreturn-type]
>  314 | }
>      | ^
> bench/numa.c: In function =E2=80=98bind_to_node=E2=80=99:
> bench/numa.c:367:1: error: control reaches end of non-void function =
[-Werror=3Dreturn-type]
>  367 | }
>      | ^
>=20
> Add return statements to cover this case.

Looks fine to me

Reviewed-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>

Thanks
Athira
>=20
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/bench/numa.c | 2 ++
> 1 file changed, 2 insertions(+)
>=20
> diff --git a/tools/perf/bench/numa.c b/tools/perf/bench/numa.c
> index 44e1f8a44087..d5289fa58a4f 100644
> --- a/tools/perf/bench/numa.c
> +++ b/tools/perf/bench/numa.c
> @@ -311,6 +311,7 @@ static cpu_set_t *bind_to_cpu(int target_cpu)
>=20
> 	/* BUG_ON due to failure in allocation of orig_mask/mask */
> 	BUG_ON(-1);
> +	return NULL;
> }
>=20
> static cpu_set_t *bind_to_node(int target_node)
> @@ -364,6 +365,7 @@ static cpu_set_t *bind_to_node(int target_node)
>=20
> 	/* BUG_ON due to failure in allocation of orig_mask/mask */
> 	BUG_ON(-1);
> +	return NULL;
> }
>=20
> static void bind_to_cpumask(cpu_set_t *mask)
> --=20
> 2.36.0.464.gb9c8b46e94-goog
>=20