Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <538339829534d8ef10c68198016d198a9ec037fc.camel@nxp.com>
Subject: Re: [PATCH resend v8 1/5] drm/bridge: nwl-dsi: Set PHY mode in
 nwl_dsi_mode_set()
From:   Liu Ying <victor.liu@nxp.com>
To:     Guido =?ISO-8859-1?Q?G=FCnther?= <guido.gunther@puri.sm>
Cc:     linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org, kishon@ti.com,
        vkoul@kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org,
        andrzej.hajda@intel.com, narmstrong@baylibre.com,
        robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com,
        jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie,
        daniel@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        robert.chiras@nxp.com, martin.kepplinger@puri.sm
Date:   Fri, 29 Apr 2022 20:30:43 +0800
In-Reply-To: <YmLkv4PYsi+XiFr5@qwark.sigxcpu.org>
References: <20220419010852.452169-1-victor.liu@nxp.com>
         <20220419010852.452169-2-victor.liu@nxp.com>
         <YmLkv4PYsi+XiFr5@qwark.sigxcpu.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXR0dTVtNVRvL3pjODZlUXAxNHRSRG5oRHl3bzU5TUJkVlZaS0E2dHo0QXJj?=
 =?utf-8?B?U1pUN0czd2YyWXRaZDVKak8zKzdQWkxOWmdEVUlEU0dnNlMrVHlMODV0S3JY?=
 =?utf-8?B?RzBGbXNhOEdPcFYvM0p1bUtmWTBnbFVMSFB5QWpjWWlYYmNoUkszYkF5Mjhz?=
 =?utf-8?B?VXVKZVpLQmlhYWZJVTlYVU8vUzJsS25rNnpVTTVOUXJhc0RuZUhkcURBMytu?=
 =?utf-8?B?Q0xXVzlaK0cySDlkdktLcmJjNlhXU3RIQ3Rid3Bkdzg5aWxOU1dwZlpnL2J2?=
 =?utf-8?B?NWk5V3dtclBhbkZzK1dXOXpHMmlDWVJvQzFpdnMxamxQckdqNldMNGZEZXEr?=
 =?utf-8?B?OWRiRG9NenZQR2tjZEdrZGdhandCZkEzeFRXRVEwWjkvMlJ6R1ZRYmxuRk5O?=
 =?utf-8?B?TUJxVVJFZ2hFdm9KdVR5bUpKdlptNFNLeUxTdEI1UWF5T2NhcmFOaTVXdUY4?=
 =?utf-8?B?MTFUaEd2TlJjT1JaR0xOVzZtTjBHNUZrTSsxZlI1c1BXclNoSzJMT3JSNUJE?=
 =?utf-8?B?RlFCQ2I2WG95WXZDci9uMVpmckNrSjZCNlEyQ1VqaUZDdkNMZTJEc2FYUEJk?=
 =?utf-8?B?ME5NOVZOUVZ3OEMwc0wweDR1bWVOYmx5L1pqVzdRV3dIUEFjRmhqMHNVZmpw?=
 =?utf-8?B?WC9HMVlpb3JTd3dIT3ZvbDN3RlByZUExZzJkRjBiaDdlL0hQd1hYSThGV2c5?=
 =?utf-8?B?WXd2Tmh2ZE5LK3U4K09rUmxZSFR6YkZkM3VZS1RMZUNSeXdBbU51M3FNSjl1?=
 =?utf-8?B?Yk1TNWMxWWNaZVN2UWg5OWQxd0xhQzI2RnFjdDVhaGxJYjhNWE1FRk83b2ha?=
 =?utf-8?B?Vy94dmZ0dm94T0RkNWVHYmtIcnYyOUV4OTVpVS92djRXQzlDd3dndENRZmQw?=
 =?utf-8?B?S0lMN3R5Q0xEYUx5TWYrRWFtMnV2L05zbGtXVUowb1ZzUWw2aWNWd3VsZE5U?=
 =?utf-8?B?bHAva1NwS2RRYkYwMTJNZU1YVHNyRVRmamFDc0xVbEplQ21sSEwrMzdPWUVJ?=
 =?utf-8?B?MjFFU2dwMW1XUEloUUtjZkhNd0FVOVhYVExibmo2UVFRWmxuaVV1OFFmR1lX?=
 =?utf-8?B?cnpIc0FsUDB3TzZZU0p6a2U3RCsvVjU3SXJadks5bDJ0S0t1bHZYV3FlblU3?=
 =?utf-8?B?dVhDRkNUVk8wdzdmM1MzekhKT09hVUJxN3RnbVRES0hnZmZGd3JPNkdYVHlT?=
 =?utf-8?B?cytiVFlqSk5pT0JzNE5CK1FOVjJESVJkeDdxSytKU0tvUGdiKzMzSVZRMlF4?=
 =?utf-8?B?L3hiUyszQlZ0TWxkZnNrYll2VnMzZ2FVT0loVkVPdmloaEcxcUVxN0VMNmVl?=
 =?utf-8?B?U3QraTRVdytPajd5bVY3UVR0REJIZTdXdytHMEtUZzlSSWppTWd5ckxURU5S?=
 =?utf-8?B?T2VQSlorbnVFMFBkMkhyZjBBRnR2RE4wcnZuZklneFZVZEtJOWtkUFhITHhv?=
 =?utf-8?B?L3Buc1IwdzY3c1gyKytUMzNVVW9mOFgwUDM5TnNlNW1KT0F1SzN6Y1RqeUg4?=
 =?utf-8?B?WS81WmhDaUZHMysvcGkyY2FKc3REYk5wRDZkaHVSdjd6ajNaQ1k2Y2o2Tkwx?=
 =?utf-8?B?clBVUlBHOWoyTzYwRitNU1lpNytKR3JST1hxT2srK0xyRXJKT2ZyOW1XOUd0?=
 =?utf-8?B?b2RHVlpPVU5nTDAzb2s0RW5heWdVK0pkK1BKM3dDekNmclpKZ29rNnhrWEdk?=
 =?utf-8?B?Lzl1V0ZpTE1FWHhwSDlJNmtMUEsyTE50eTY2b1RlSFl3K05UbjJCU0RkMVBX?=
 =?utf-8?B?Wm9iYTAyamdOam1YTm1zSExmVldFbkpLN3NnU0c5NldwdTNlcmd5N2NhaU01?=
 =?utf-8?B?NHAzZXBZZmRtNkEzWGJ0NUNXcVNFWm5DUkhnd3N2SC95aVhrWlhic1VkTmE4?=
 =?utf-8?B?bGV0dzdYdjczL2tVVzlETWRTS1l4dVYveWtURS8vZG0yMi9YRVFrSVhYOFhE?=
 =?utf-8?B?SnplSlRXaEViTXczSkZsT3JUZzlySkI5QnpqaWowUTRZOGMrbGNheU4zT3lF?=
 =?utf-8?B?RU9jZWtrN2hqNzlneEtsMkJhd0c1cE9PQWsxV2JYb1oxRjllZVgrWG5zajdq?=
 =?utf-8?B?aFo1RklacVJHZ0k4V1VpUng1ZDZJQVZJTjlZSzBDZFI1bktXNzIyU2JzUDBI?=
 =?utf-8?B?TERKbHlaZnhjMnRnVWNaZExPc3piblI0RWFzbnlIeVNBVUN1amRXNERSYUdS?=
 =?utf-8?B?Vi9rMXNYdzJqTjkxN3Q1WERvRHd4RzA3bTc1b0todXNsSVIybmhzbnZKU2Y4?=
 =?utf-8?B?aTJtNkpvUkFXZ1FIQmI1bGNWWHpucVdwT3ZSN3hIcStVNFFZMFpoNDB1alQx?=
 =?utf-8?B?S0FCQm9aM21aSzRpRDhST3JydktYQks1ZFNOQ1VkZHE3OCtUNmgwQT09?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c03723eb-aa99-42d9-6dfc-08da29dc1b88
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 12:30:57.2371
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AFD3dnmoY4YQamWOL/SHZSxxf5i6EXvuipOJYkIRU78biPDWntoOzQVBodsx5DnheHrLpZznll9qA+2otlxMOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7646
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Fri, 2022-04-22 at 19:24 +0200, Guido Günther wrote:
> Hi,
> On Tue, Apr 19, 2022 at 09:08:48AM +0800, Liu Ying wrote:
> > The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp
> > works with a Mixel MIPI DPHY + LVDS PHY combo to support either
> > a MIPI DSI display or a LVDS display.  So, this patch calls
> > phy_set_mode() from nwl_dsi_mode_set() to set PHY mode to MIPI DPHY
> > explicitly.
> > 
> > Cc: Guido Günther <agx@sigxcpu.org>
> > Cc: Robert Chiras <robert.chiras@nxp.com>
> > Cc: Martin Kepplinger <martin.kepplinger@puri.sm>
> > Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> > Cc: Neil Armstrong <narmstrong@baylibre.com>
> > Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> > Cc: Jonas Karlman <jonas@kwiboo.se>
> > Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: NXP Linux Team <linux-imx@nxp.com>
> > Signed-off-by: Liu Ying <victor.liu@nxp.com>

Hope this patch won't fall through the cracks.
Can someone please apply it to drm-misc-next? Robert?

Thanks,
Liu Ying

> > ---
> > v7->v8:
> > * Resend with Andrzej's and Jernej's mail addressed updated.
> > 
> > v6->v7:
> > * No change.
> > 
> > v5->v6:
> > * Rebase the series upon v5.17-rc1.
> > * Set PHY mode in ->mode_set() instead of ->pre_enable() in the
> > nwl-dsi
> >   bridge driver due to the rebase.
> > * Drop Guido's R-b tag due to the rebase.
> > 
> > v4->v5:
> > * No change.
> > 
> > v3->v4:
> > * No change.
> > 
> > v2->v3:
> > * No change.
> > 
> > v1->v2:
> > * Add Guido's R-b tag.
> > 
> >  drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c
> > b/drivers/gpu/drm/bridge/nwl-dsi.c
> > index d5945501a5ee..85bab7372af1 100644
> > --- a/drivers/gpu/drm/bridge/nwl-dsi.c
> > +++ b/drivers/gpu/drm/bridge/nwl-dsi.c
> > @@ -666,6 +666,12 @@ static int nwl_dsi_mode_set(struct nwl_dsi
> > *dsi)
> >  		return ret;
> >  	}
> >  
> > +	ret = phy_set_mode(dsi->phy, PHY_MODE_MIPI_DPHY);
> > +	if (ret < 0) {
> > +		DRM_DEV_ERROR(dev, "Failed to set DSI phy mode: %d\n",
> > ret);
> > +		goto uninit_phy;
> > +	}
> > +
> >  	ret = phy_configure(dsi->phy, phy_cfg);
> >  	if (ret < 0) {
> >  		DRM_DEV_ERROR(dev, "Failed to configure DSI phy: %d\n",
> > ret);
> 
> I can't currently test this but it still looks good so
> 
> Reviewed-by: Guido Günther <agx@sigxcpu.org>
> 
> Cheers,
>  -- Guido
> 
> > -- 
> > 2.25.1
> >