Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 28 Apr 2022 10:25:58 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Thomas Richter <tmricht@linux.ibm.com>
Cc:     linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        irogers@google.com, svens@linux.ibm.com, gor@linux.ibm.com,
        sumanthk@linux.ibm.com, hca@linux.ibm.com
Subject: Re: [PATCH] perf test: Fix test case 81 on s390x
Message-ID: <YmqV5o0XFfewhNkC@kernel.org>
References: <20220428122821.3652015-1-tmricht@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220428122821.3652015-1-tmricht@linux.ibm.com>
Precedence: bulk

Em Thu, Apr 28, 2022 at 02:28:21PM +0200, Thomas Richter escreveu:
> perf test -F 81 -v fails on s390x on the linux-next branch.
> The test case is x86 specific can not be executed on s390x.
> The test case depends on x86 register names such as
> 
>   ... | egrep -q 'available registers: AX BX CX DX ....'

Thanks,

Ian, I guess this will break on other !x86 arches as well. Can you
please take a look?

- Arnaldo
 
> Skip this test case on s390x.
> 
> Output before:
>  # perf test -F 81
>  81: perf record tests                       : FAILED!
>  #
> 
> Output after:
>  # perf test -F 81
>  81: perf record tests                       : Skip
>  #
> 
> Fixes: 24f378e66021 ("perf test: Add basic perf record tests")
> Cc: Ian Rogers <irogers@google.com>
> Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
> ---
>  tools/perf/tests/shell/record.sh | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> index cd1cf14259b8..d98f4d4a00e1 100755
> --- a/tools/perf/tests/shell/record.sh
> +++ b/tools/perf/tests/shell/record.sh
> @@ -37,6 +37,8 @@ test_register_capture() {
>    echo "Register capture test [Success]"
>  }
>  
> +# Test for platform support and return TEST_SKIP
> +[ $(uname -m) = s390x ] && exit 2
>  test_per_thread
>  test_register_capture
>  exit $err
> -- 
> 2.35.1

-- 

- Arnaldo