Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <626c00df.1c69fb81.a5445.4d7c@mx.google.com>
Date:   Fri, 29 Apr 2022 17:12:13 +0200
From:   Ansuel Smith <ansuelsmth@gmail.com>
To:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: qcom: replace gcc PXO with pxo_board fixed
 clock
References: <20220429122951.13828-1-ansuelsmth@gmail.com>
 <20220429122951.13828-3-ansuelsmth@gmail.com>
 <f260cf81-9db9-710b-1242-45a232e7c7c4@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f260cf81-9db9-710b-1242-45a232e7c7c4@linaro.org>
Precedence: bulk

On Fri, Apr 29, 2022 at 06:11:21PM +0300, Dmitry Baryshkov wrote:
> On 29/04/2022 15:29, Ansuel Smith wrote:
> > Replace gcc PXO phandle to pxo_board fixed clock declared in the dts.
> > gcc driver doesn't provide PXO_SRC as it's a fixed-clock. This cause a
> > kernel panic if any driver actually try to use it.
> > 
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> 
> Fixes: 40cf5c884a96 ("ARM: dts: qcom: add L2CC and RPM for IPQ8064")
> 
> It would be nice if you add Fixes tags to your patches in future. Fixes tags
> allow picking up patches for stable/LTS trees.
> 
> For these two patches I'd suggest reordering them. A fix should go first
> (you'll have to define pxa_board label in it). It can then be accepted into
> other kernel without dependency on the other patch.
> 
> The gcc patch will come next, it will define cxo_board label and use both
> clocks in the gcc node. It is not fixing a bug, so there is no need about
> backporting it.
> 
> Generic rule: fixes go first (in the patch series), so that they have
> minimum inter-dependencies.
>

Didn't know about this. Thanks for the hint! Will do the change.

> > ---
> >   arch/arm/boot/dts/qcom-ipq8064.dtsi | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > index 9817448cfa95..ad30f7c8a5a7 100644
> > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > @@ -784,7 +784,7 @@ tcsr: syscon@1a400000 {
> >   		l2cc: clock-controller@2011000 {
> >   			compatible = "qcom,kpss-gcc", "syscon";
> >   			reg = <0x2011000 0x1000>;
> > -			clocks = <&gcc PLL8_VOTE>, <&gcc PXO_SRC>;
> > +			clocks = <&gcc PLL8_VOTE>, <&pxo_board>;
> >   			clock-names = "pll8_vote", "pxo";
> >   			clock-output-names = "acpu_l2_aux";
> >   		};
> 
> 
> -- 
> With best wishes
> Dmitry

-- 
	Ansuel